Sign upLogin

BigKeeper/big-keeper

View on GitHub
Star

Showing 109 of 109 total issues

Method recover_bigkeeper_config_file has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def recover_bigkeeper_config_file(bigkeeper_config_file)
      if !File.exist?(bigkeeper_config_file)
        return
      end
      temp_file = Tempfile.new('.bigkeeper_config.tmp', :encoding => 'UTF-8')
Severity: Minor
Found in lib/big_keeper/util/gradle_file_operator.rb - About 1 hr to fix

    Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def parse(main_path)
      self.main_path = main_path
      $mode = 'PODS'
      podfile_lock_lines = File.readlines("#{main_path}/Podfile.lock", :encoding => 'UTF-8')
      Logger.highlight("Analyzing Podfile.lock...")
    Severity: Minor
    Found in lib/big_keeper/util/lockfile_parser.rb - About 1 hr to fix

      Method start has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.start(path, version, user, name, modules, type)
    begin
      # Parse Bigkeeper file
      BigkeeperParser.parse("#{path}/Bigkeeper")
      Severity: Minor
      Found in lib/big_keeper/command/feature&hotfix/start.rb - About 1 hr to fix

        Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def initialize(sentence)
    if sentence.include?('#')
      list = sentence.split('#')
      @comment = list[1]
      sentence = list[0]
        Severity: Minor
        Found in lib/big_keeper/model/podfile_model.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method end_log has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def end_log(is_success, is_show_log)
      @end_timestamp = Time.new.to_i
      @is_success = is_success
      @version = BigkeeperParser.version if @version == 'Version in Bigkeeper file'
        Severity: Minor
        Found in lib/big_keeper/util/leancloud_logger.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method verify_rebase has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def verify_rebase(path, branch_name, name)

      # pull rebased branch
      pull(path, branch_name)
        Severity: Minor
        Found in lib/big_keeper/service/git_service.rb - About 1 hr to fix

          Method update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.update(path, user, modules, type)
    begin
      # Parse Bigkeeper file
      BigkeeperParser.parse("#{path}/Bigkeeper")
      branch_name = GitOperator.new.current_branch(path)
          Severity: Minor
          Found in lib/big_keeper/command/feature&hotfix/update.rb - About 1 hr to fix

            Method verify_home_branch has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def verify_home_branch(path, branch_name, type)
      Logger.highlight('Sync local branchs from remote, waiting...')
      git = GitOperator.new

      git.fetch(path)
            Severity: Minor
            Found in lib/big_keeper/service/git_service.rb - About 1 hr to fix

              Method find_and_lock has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def find_and_lock(podfile, dictionary)
      temp_file = Tempfile.new('.Podfile.tmp', :encoding => 'UTF-8')
      begin
        File.open(podfile, 'r') do |file|
          file.each_line do |line|
              Severity: Minor
              Found in lib/big_keeper/util/podfile_operator.rb - About 1 hr to fix

                Method get_unlock_pod_list has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                     def get_unlock_pod_list(is_all)
       result = {}
       pod_parser = PodfileParser.instance
       #podfile 中 unlock pods
       unlock_pods = pod_parser.get_unlock_pod_list
                Severity: Minor
                Found in lib/big_keeper/util/lockfile_parser.rb - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        c.command :finish do |finish|
        finish.action do |global_options, options, args|
          path = File.expand_path(global_options[:path])
          version = global_options[:ver]
          user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
                  Severity: Minor
                  Found in lib/big_keeper/command/release.rb and 1 other location - About 55 mins to fix
                  lib/big_keeper/command/release.rb on lines 14..20

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        c.command :start do |start|
        start.action do |global_options, options, args|
          path = File.expand_path(global_options[:path])
          version = global_options[:ver]
          user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
                  Severity: Minor
                  Found in lib/big_keeper/command/release.rb and 1 other location - About 55 mins to fix
                  lib/big_keeper/command/release.rb on lines 25..31

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method recover_bigkeeper_config_file has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def recover_bigkeeper_config_file(bigkeeper_config_file)
      if !File.exist?(bigkeeper_config_file)
        return
      end
      temp_file = Tempfile.new('.bigkeeper_config.tmp', :encoding => 'UTF-8')
                  Severity: Minor
                  Found in lib/big_keeper/util/gradle_file_operator.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method deal_pod has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def deal_pod(s)
      pod_name = get_lock_podname(s)
      return if pod_name == nil
      pod_version = get_lock_version(s)
      if self.pods.keys.include?(pod_name)
                  Severity: Minor
                  Found in lib/big_keeper/util/lockfile_parser.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                        c.command :finish do |finish|
        finish.action do |global_options, options, args|
          path = File.expand_path(global_options[:path])
          user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
          LeanCloudLogger.instance.set_command("#{GitflowType.command(type)}/finish")
                  Severity: Major
                  Found in lib/big_keeper/command/feature&hotfix.rb and 3 other locations - About 55 mins to fix
                  lib/big_keeper/command/feature&hotfix.rb on lines 62..69
                  lib/big_keeper/command/feature&hotfix.rb on lines 89..96
                  lib/big_keeper/command/feature&hotfix.rb on lines 113..120

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                        c.command :rebase do |rebase|
        rebase.action do |global_options, options, args|
          path = File.expand_path(global_options[:path])
          user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
          LeanCloudLogger.instance.set_command("#{GitflowType.command(type)}/rebase")
                  Severity: Major
                  Found in lib/big_keeper/command/feature&hotfix.rb and 3 other locations - About 55 mins to fix
                  lib/big_keeper/command/feature&hotfix.rb on lines 62..69
                  lib/big_keeper/command/feature&hotfix.rb on lines 101..108
                  lib/big_keeper/command/feature&hotfix.rb on lines 113..120

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                        c.command :publish do |publish|
        publish.action do |global_options, options, args|
          path = File.expand_path(global_options[:path])
          user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
          LeanCloudLogger.instance.set_command("#{GitflowType.command(type)}/publish")
                  Severity: Major
                  Found in lib/big_keeper/command/feature&hotfix.rb and 3 other locations - About 55 mins to fix
                  lib/big_keeper/command/feature&hotfix.rb on lines 62..69
                  lib/big_keeper/command/feature&hotfix.rb on lines 89..96
                  lib/big_keeper/command/feature&hotfix.rb on lines 101..108

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                        c.command :pull do |pull|
        pull.action do |global_options, options, args|
          path = File.expand_path(global_options[:path])
          user = global_options[:user].gsub(/[^0-9A-Za-z]/, '').downcase
          LeanCloudLogger.instance.set_command("#{GitflowType.command(type)}/pull")
                  Severity: Major
                  Found in lib/big_keeper/command/feature&hotfix.rb and 3 other locations - About 55 mins to fix
                  lib/big_keeper/command/feature&hotfix.rb on lines 89..96
                  lib/big_keeper/command/feature&hotfix.rb on lines 101..108
                  lib/big_keeper/command/feature&hotfix.rb on lines 113..120

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method verify_special_branch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def verify_special_branch(path, name)
      git = GitOperator.new

      if git.has_remote_branch(path, name)
        if git.has_local_branch(path, name)
                  Severity: Minor
                  Found in lib/big_keeper/service/git_service.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                                    if keyword.include?(".h") && line.include?("import") && line.include?("/"+keyword+">")
                    dependence_library_name = line[line.index("<")+1...line.index("/"+keyword+">")]
                    if dependence_library_name == library_name
                      tip = " [file]:"+File.basename(file_path)+" [line]: "+line.strip+" [keyword]: "+keyword
                      is_dependence = true
                  Severity: Major
                  Found in lib/big_keeper/model/library_model.rb - About 45 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language