Sign upLogin

BigKeeper/big-keeper

View on GitHub
Star

Showing 109 of 109 total issues

Method module_info has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def module_info(module_path, home_branch_name, user, type, module_name, version)
Severity: Minor
Found in lib/big_keeper/service/module_service.rb - About 45 mins to fix

    Method start has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def self.start(path, version, user, name, modules, type)
    Severity: Minor
    Found in lib/big_keeper/command/feature&hotfix/start.rb - About 45 mins to fix

      Method in_note_code has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def in_note_code(line_hash)
      line = line_hash["line"]
      in_note = line_hash["in_note"]
      line = line.strip
      if in_note
      Severity: Minor
      Found in lib/big_keeper/util/code_operator.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method verify_push has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def verify_push(path, comment, branch_name, name)
      git = GitOperator.new
      if git.has_changes(path) || git.has_commits(path, branch_name)

        git.commit(path, comment) if git.has_changes(path)
      Severity: Minor
      Found in lib/big_keeper/service/git_service.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method push has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def push(path, user, module_name, home_branch_name, type, comment)
      Severity: Minor
      Found in lib/big_keeper/service/module_service.rb - About 45 mins to fix

        Method get_module_info has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def self.get_module_info(path, user, type, version, home_branches, is_print_log)
        Severity: Minor
        Found in lib/big_keeper/command/feature&hotfix/list.rb - About 45 mins to fix

          Method deal_module_info has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def deal_module_info
    podfile_lines = File.readlines("#{@main_path}/bigKeeperPodInfo.tmp", :encoding => 'UTF-8')
    Logger.highlight("Analyzing modules info...") unless podfile_lines.size.zero?
      podfile_lines.collect do |sentence|
        if sentence =~(/pod/)
          Severity: Minor
          Found in lib/big_keeper/util/podfile_module.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method chose_version has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def chose_version(cur_version,temp_version)
      # p "cur:#{cur_version},temp:#{temp_version}"
      cur_list = cur_version.split('.')
      temp_list = temp_version.split('.')
      cur_list << 0.to_s if cur_list.size == 2
          Severity: Minor
          Found in lib/big_keeper/util/lockfile_parser.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method branchs_with_type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def branchs_with_type(path, type)
      branchs = []
      Dir.chdir(path) do
        IO.popen('git branch -a') do | io |
          io.each do | line |
          Severity: Minor
          Found in lib/big_keeper/service/git_service.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                if @@config[:users] \
        && @@config[:users][user_name] \
        && @@config[:users][user_name][:mods] \
        && @@config[:users][user_name][:mods][module_name] \
        && @@config[:users][user_name][:mods][module_name][:path]
          Severity: Minor
          Found in lib/big_keeper/util/bigkeeper_parser.rb and 1 other location - About 45 mins to fix
          lib/big_keeper/util/bigkeeper_parser.rb on lines 202..215

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 39.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                if @@config[:users] \
        && @@config[:users][user_name] \
        && @@config[:users][user_name][:mods] \
        && @@config[:users][user_name][:mods][module_name] \
        && @@config[:users][user_name][:mods][module_name][:path]
          Severity: Minor
          Found in lib/big_keeper/util/bigkeeper_parser.rb and 1 other location - About 45 mins to fix
          lib/big_keeper/util/bigkeeper_parser.rb on lines 186..198

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 39.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method switch_to has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def self.switch_to(path, version, user, full_name, type)
          Severity: Minor
          Found in lib/big_keeper/command/feature&hotfix/switch.rb - About 35 mins to fix

            Method release_finish has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def release_finish(path, user, modules, module_name, version)
            Severity: Minor
            Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

              Method release_start has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def release_start(path, user, modules, module_name, version)
              Severity: Minor
              Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                Method del has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def del(path, user, module_name, name, type)
                Severity: Minor
                Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                  Method publish has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def publish(path, user, module_name, home_branch_name, type)
                  Severity: Minor
                  Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                    Method verify_module has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def verify_module(path, user, module_name, home_branch_name, type)
                    Severity: Minor
                    Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                      Method rebase has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def rebase(path, user, module_name, home_branch_name, type)
                      Severity: Minor
                      Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                        Method finish has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def finish(path, user, module_name, home_branch_name, type)
                        Severity: Minor
                        Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix

                          Method add has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def add(path, user, module_name, name, type)
                          Severity: Minor
                          Found in lib/big_keeper/service/module_service.rb - About 35 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language