Sign upLogin

CartoDB/Windshaft

View on GitHub
Star

Showing 59 of 59 total issues

Function getTile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getTile (mapConfigProvider, params, callback) {
        const { format, interactivity, token, z, x, y } = params;

        // TODO: review if needed see cartonik's validations
        if (format === 'grid.json' && !interactivity) {
Severity: Minor
Found in lib/backends/tile.js - About 1 hr to fix

    Function defaultTileSQLTemplate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function defaultTileSQLTemplate () {
    return `
        WITH par AS (
            WITH innerpar AS (
                SELECT
    Severity: Minor
    Found in lib/renderers/torque/renderer.js - About 1 hr to fix

      Function _update has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _update: function () {

        var bounds = this._map.getPixelBounds(),
            zoom = this._map.getZoom(),
            tileSize = this.options.tileSize;
      Severity: Minor
      Found in examples/viewer/leaflet.utfgrid.js - About 1 hr to fix

        Function getRenderer has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getRenderer (mapConfig, format, options, callback) {
        if (mapConfig.isVectorOnlyMapConfig() && format !== PgMvtFactory.MVT_FORMAT) {
            const error = new Error(`Unsupported format: 'cartocss' option is missing for ${format}`);
            error.http_status = 400;
            error.type = 'tile';
        Severity: Minor
        Found in lib/renderers/pg-mvt/factory.js - About 1 hr to fix

          Function fetchLayerAttributes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function fetchLayerAttributes (psql, layer) {
    try {
        const attrs = checkLayerAttributes(layer);
        const layerSql = SubstitutionTokens.replaceXYZ(layer.options.sql, { x: 0, y: 0, z: 0 });
          Severity: Minor
          Found in lib/renderers/torque/factory.js - About 1 hr to fix

            Function constructor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                constructor (options) {
        this._mapnikOptions = Object.assign({}, {
            geometry_field: 'the_geom_webmercator',

            // Metatile is the number of tiles-per-side that are going
            Severity: Minor
            Found in lib/renderers/mapnik/factory.js - About 1 hr to fix

              Function getImage has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  getImage (options, callback) {
        const { mapConfigProvider, format, width, height, zoom, center, bbox } = options;

        this._rendererCache.getRenderer(mapConfigProvider, (err, renderer) => {
            if (err) {
              Severity: Minor
              Found in lib/backends/preview.js - About 1 hr to fix

                Function _loadTileP has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    _loadTileP: function (zoom, x, y) {
        var head = document.getElementsByTagName('head')[0],
            key = zoom + '_' + x + '_' + y,
            functionName = 'lu_' + key,
            wk = this._windowKey,
                Severity: Minor
                Found in examples/viewer/leaflet.utfgrid.js - About 1 hr to fix

                  Function ajax has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  L.Util.ajax = function (url, timeout, success, error) {

    if (window.XMLHttpRequest === undefined) {
        error(new Error("XMLHttpRequest is not supported"));
    }
                  Severity: Minor
                  Found in examples/viewer/leaflet.utfgrid.js - About 1 hr to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        const env = {
        benchmark: false,
        validation_data: false,
        effects: [],
        errors: [],
                    Severity: Major
                    Found in lib/utils/cartocss-utils.js and 1 other location - About 1 hr to fix
                    lib/renderers/torque/factory.js on lines 163..171

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        const env = {
        benchmark: false,
        validation_data: false,
        effects: [],
        errors: [],
                    Severity: Major
                    Found in lib/renderers/torque/factory.js and 1 other location - About 1 hr to fix
                    lib/utils/cartocss-utils.js on lines 34..42

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function getStats has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        getStats () {
        const stats = new Map();
        const rendererCacheEntries = Object.entries(this.renderers);

        stats.set('rendercache.count', rendererCacheEntries.length);
                    Severity: Minor
                    Found in lib/cache/renderer-cache.js - About 1 hr to fix

                      Function _validateRemaningFormatLayers has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          _validateRemaningFormatLayers (mapConfigProvider, mapConfig, params) {
        const token = mapConfig.id();
        const validateRemainingFormatLayerPromises = [];

        mapConfig.getLayers().forEach((layer, layerId) => {
                      Severity: Minor
                      Found in lib/backends/map-validator.js - About 1 hr to fix

                        Function getTilesFromImage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function getTilesFromImage (image, x, y, imageBuffer, tileSize) {
    const tiles = [];
    const imageWidth = image.width();
    const imageHeight = image.height();
                        Severity: Minor
                        Found in lib/renderers/plain/image-renderer.js - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      seTilePoint = new L.Point(
                Math.floor(bounds.max.x / tileSize),
                Math.floor(bounds.max.y / tileSize)),
                          Severity: Minor
                          Found in examples/viewer/leaflet.utfgrid.js and 1 other location - About 55 mins to fix
                          examples/viewer/leaflet.utfgrid.js on lines 198..200

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 54.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  var nwTilePoint = new L.Point(
                Math.floor(bounds.min.x / tileSize),
                Math.floor(bounds.min.y / tileSize)),
                          Severity: Minor
                          Found in examples/viewer/leaflet.utfgrid.js and 1 other location - About 55 mins to fix
                          examples/viewer/leaflet.utfgrid.js on lines 201..203

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 54.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (mapConfig.isVectorOnlyMapConfig() && !isMvt) {
            const error = new Error(`Unsupported format: 'cartocss' option is missing for ${format}`);
            error.http_status = 400;
            error.type = 'tile';
            return callback(error);
                          Severity: Minor
                          Found in lib/renderers/mapnik/factory.js and 1 other location - About 55 mins to fix
                          lib/renderers/pg-mvt/factory.js on lines 34..39

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 53.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (mapConfig.isVectorOnlyMapConfig() && format !== PgMvtFactory.MVT_FORMAT) {
            const error = new Error(`Unsupported format: 'cartocss' option is missing for ${format}`);
            error.http_status = 400;
            error.type = 'tile';
            return callback(error);
                          Severity: Minor
                          Found in lib/renderers/pg-mvt/factory.js and 1 other location - About 55 mins to fix
                          lib/renderers/mapnik/factory.js on lines 132..137

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 53.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function getTilesFromImage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function getTilesFromImage (image, x, y, imageBuffer, tileSize) {
    const tiles = [];
    const imageWidth = image.width();
    const imageHeight = image.height();
                          Severity: Minor
                          Found in lib/renderers/plain/image-renderer.js - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function mapConfigToMMLBuilderConfig has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function mapConfigToMMLBuilderConfig (mapConfig, rendererOptions, mapnikOptions) {
    const options = {
        ids: [],
        sql: [],
        originalSql: [],
                          Severity: Minor
                          Found in lib/renderers/mapnik/factory.js - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language