Sign upLogin

DeFiCh/wallet

View on GitHub
Star

Showing 335 of 335 total issues

Function useResultingCollateralizationRatioByCollateral has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export function useResultingCollateralizationRatioByCollateral({
  collateralValue,
  collateralRatio,
  minCollateralRatio,
  totalLoanAmount,
Severity: Minor
Found in mobile-app/app/screens/AppNavigator/screens/Loans/hooks/CollateralizationRatio.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SlippageTolerance has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export function SlippageTolerance({
  slippage,
  setSlippage,
  slippageError,
  setSlippageError,
Severity: Minor
Found in mobile-app/app/screens/AppNavigator/screens/Dex/CompositeSwap/components/SlippageTolerance.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function errorMessageMapping has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function errorMessageMapping(err: string): ErrorMapping {
  if (err === "not enough balance after combing all prevouts") {
    return {
      code: ErrorCodes.InsufficientUTXO,
      message: "Insufficient UTXO DFI.",
Severity: Minor
Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DFIBalanceCard has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export function DFIBalanceCard({
  denominationCurrency,
}: DFIBalaceCardProps): JSX.Element {
  const { domain } = useDomainContext();
  const { dvmTokens, evmTokens } = useTokenBalance();
Severity: Minor
Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/components/DFIBalanceCard.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function VaultDetailStatus has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export function VaultDetailStatus({
  vault,
  vaultStatus,
  nextColRatio,
}: VaultDetailStatusProps): JSX.Element {
Severity: Minor
Found in mobile-app/app/screens/AppNavigator/screens/Loans/VaultDetail/components/VaultDetailStatus.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function PromptContent has 114 lines of code (exceeds 100 allowed). Consider refactoring.
Open

const PromptContent = React.memo((props: PasscodePromptProps): JSX.Element => {
  return (
    <>
      <ThemedTouchableOpacityV2
        light={tailwind("bg-mono-light-v2-100")}
Severity: Major
Found in mobile-app/app/screens/TransactionAuthorization/PasscodePrompt.tsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <TouchableOpacity
        onPress={async () => {
          copyToClipboard();
          await Clipboard.setStringAsync(receiveAddress);
        }}
    Severity: Major
    Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/ReceiveScreen.tsx and 1 other location - About 1 hr to fix
    mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/ReceiveScreen.tsx on lines 145..177

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <TouchableOpacity
        onPress={async () => {
          await onShare(receiveAddress, logger);
        }}
        testID="share_button"
    Severity: Major
    Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/ReceiveScreen.tsx and 1 other location - About 1 hr to fix
    mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/ReceiveScreen.tsx on lines 109..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function SkeletonLoader has 113 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

    export function SkeletonLoader(prop: SkeletonLoaderProp): JSX.Element {
  const skeletonRow = Array.from(Array(prop.row), (_v, i) => i + 1);
  switch (prop.screen) {
    case SkeletonLoaderScreen.Dex:
      return (
    Severity: Major
    Found in mobile-app/app/components/SkeletonLoader.tsx - About 1 hr to fix

      Function CollateralCard has 111 lines of code (exceeds 100 allowed). Consider refactoring.
      Open

      function CollateralCard(props: CollateralCardProps): JSX.Element {
  const { collateral, collateralItem, totalCollateralValue, vault } = props;
  const canUseOperations = useLoanOperations(vault.state);
  const prices = getCollateralPrice(
    new BigNumber(collateral.amount),
      Severity: Major
      Found in mobile-app/app/screens/AppNavigator/screens/Loans/screens/EditCollateralScreen.tsx - About 1 hr to fix

        Function ConfirmAddLiquidityScreen has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function ConfirmAddLiquidityScreen({ route }: Props): JSX.Element {
  const hasPendingJob = useSelector((state: RootState) =>
    hasTxQueued(state.transactionQueue)
  );
  const hasPendingBroadcastJob = useSelector((state: RootState) =>
        Severity: Minor
        Found in mobile-app/app/screens/AppNavigator/screens/Dex/DexConfirmAddLiquidity.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function TransactionsScreen has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function TransactionsScreen(): JSX.Element {
  const client = useWhaleApiClient();
  const { address } = useWalletContext();
  const { isLight } = useThemeContext();
  const navigation = useNavigation<NavigationProp<PortfolioParamList>>();
        Severity: Minor
        Found in mobile-app/app/screens/AppNavigator/screens/Transactions/TransactionsScreen.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function CreateWalletStepIndicator has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function CreateWalletStepIndicator(
  props: StepIndicatorProps
): JSX.Element {
  const { isLight } = useThemeContext();
  const {
        Severity: Minor
        Found in mobile-app/app/components/CreateWalletStepIndicator.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findDisplayedAnnouncementForVersion has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function findDisplayedAnnouncementForVersion(
  version: string,
  language: string,
  hiddenAnnouncements: string[],
  announcements?: AnnouncementData[]
        Severity: Minor
        Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/components/Announcements.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function ConfirmEditCollateralScreen has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function ConfirmEditCollateralScreen({
  route,
  navigation,
}: Props): JSX.Element {
  const {
        Severity: Minor
        Found in mobile-app/app/screens/AppNavigator/screens/Loans/screens/ConfirmEditCollateralScreen.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function TotalPortfolio has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function TotalPortfolio(props: TotalPortfolioProps): JSX.Element {
  const { hasFetchedToken } = useSelector((state: RootState) => state.wallet);
  const { domain } = useDomainContext();
  const isEvmDomain = domain === DomainType.EVM;
  const { hasFetchedVaultsData } = useSelector(
        Severity: Minor
        Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/components/TotalPortfolio.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function DFIPDetailScreen has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function DFIPDetailScreen(): JSX.Element {
  const logger = useLogger();
  const dispatch = useAppDispatch();
  const navigation = useNavigation<NavigationProp<PortfolioParamList>>();
  const { isLight } = useThemeContext();
        Severity: Minor
        Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/OCG/DFIPDetailScreen.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function AuctionScreen has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export function AuctionScreen({ navigation }: Props): JSX.Element {
  const { hasFetchAuctionsData } = useSelector(
    (state: RootState) => state.auctions
  );
  const [showLoader, setShowLoader] = useState(true);
        Severity: Minor
        Found in mobile-app/app/screens/AppNavigator/screens/Auctions/AuctionScreen.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function PoolPairActionRow({
  title,
  icon,
  onPress,
  testID,
        Severity: Major
        Found in mobile-app/app/screens/AppNavigator/screens/Dex/PoolPairDetailsScreen.tsx and 1 other location - About 1 hr to fix
        mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/TokenDetailScreen.tsx on lines 566..593

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 192.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function TokenActionRow({
  title,
  icon,
  onPress,
  testID,
        Severity: Major
        Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/TokenDetailScreen.tsx and 1 other location - About 1 hr to fix
        mobile-app/app/screens/AppNavigator/screens/Dex/PoolPairDetailsScreen.tsx on lines 620..647

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 192.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language