Sign upLogin

DeFiCh/wallet

View on GitHub
Star

Showing 335 of 335 total issues

Function TokenSummary has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function TokenSummary(props: {
  token: WalletToken;
  border?: boolean;
  usdAmount: BigNumber;
  isEvmDomain?: boolean;
Severity: Minor
Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/TokenDetailScreen.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function PlaygroundOperations has 101 lines of code (exceeds 100 allowed). Consider refactoring.
Open

export function PlaygroundOperations(): JSX.Element {
  const { wallet } = useWalletContext();
  const client = useWhaleApiClient();
  const dispatch = useAppDispatch();
  const { api, rpc } = usePlaygroundContext();
Severity: Major
Found in mobile-app/app/screens/PlaygroundNavigator/sections/PlaygroundOperations.tsx - About 1 hr to fix

    Function VaultCardStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function VaultCardStatus({
  vault,
  vaultStatus,
  colRatio,
  minColRatio,
    Severity: Minor
    Found in mobile-app/app/screens/AppNavigator/screens/Loans/components/VaultCardStatus.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function PrivacyLock has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function PrivacyLock(): JSX.Element {
  const privacyLock = usePrivacyLockContext();
  const appState = useAppStateContext();
  const logger = useLogger();
    Severity: Minor
    Found in mobile-app/app/screens/PrivacyLock.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TransactionError has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function TransactionError({
  errMsg,
  onClose,
}: TransactionErrorProps): JSX.Element {
  const logger = useLogger();
    Severity: Minor
    Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function WalletTextInputV2 has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      (props: WalletTextInputProps, ref: React.Ref<any>): JSX.Element => {
    const [isFocus, setIsFocus] = useState(false);
    const {
      title,
      titleTestID,
    Severity: Minor
    Found in mobile-app/app/components/WalletTextInputV2.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function SettingsScreen has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function SettingsScreen({ navigation }: Props): JSX.Element {
  const logger = useLogger();
  const dispatch = useAppDispatch();
  const walletContext = useWalletPersistenceContext();
  const localAuth = usePrivacyLockContext();
    Severity: Minor
    Found in mobile-app/app/screens/AppNavigator/screens/Settings/SettingsScreen.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function useVaultStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function useVaultStatus(
  status: LoanVaultState | undefined,
  collateralRatio: BigNumber,
  minColRatio: BigNumber,
  totalLoanAmount: BigNumber,
    Severity: Minor
    Found in mobile-app/app/screens/AppNavigator/screens/Loans/components/VaultStatusTag.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function WalletCreateRestoreSuccess has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function WalletCreateRestoreSuccess({ route }: Props): JSX.Element {
  const { isWalletRestored, data } = route.params;
  const { network } = useNetworkContext();
  const { isLight } = useThemeContext();
  const { setWallet } = useWalletPersistenceContext();
    Severity: Minor
    Found in mobile-app/app/screens/WalletNavigator/screens/CreateWallet/WalletCreateRestoreSuccess.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function WalletTransactionCardTextInput has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    >((props: WalletTextInputProps, ref: React.Ref<any>): JSX.Element => {
  const {
    title,
    titleTestID,
    valid = true,
    Severity: Minor
    Found in mobile-app/app/components/WalletTransactionCardTextInput.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function WithdrawFutureSwapScreen has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function WithdrawFutureSwapScreen(props: Props): JSX.Element {
  const {
    futureSwap: { source, destination },
    executionBlock,
  } = props.route.params;
    Severity: Minor
    Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/screens/WithdrawFutureSwapScreen.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function useAuctionTime has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function useAuctionTime(
  liquidationHeight: number,
  blockCount: number
): AuctionTimeLeft {
  const { network } = useNetworkContext();
    Severity: Minor
    Found in mobile-app/app/screens/AppNavigator/screens/Auctions/hooks/AuctionTimeLeft.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function USDValueRow has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function USDValueRow(props: {
  isLoading: boolean;
  testId: string;
  value: BigNumber;
  label: string;
    Severity: Minor
    Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/components/TotalPortfolio.tsx - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getActivePrice has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function getActivePrice(
  symbol: string,
  activePrice?: ActivePrice,
  collateralFactor: string = "1",
  priceType: ActivePriceType = "ACTIVE",
    Severity: Minor
    Found in mobile-app/app/screens/AppNavigator/screens/Auctions/helpers/ActivePrice.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function useTokenPrice has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export function useTokenPrice(denominationTokenSymbol = "USDT"): TokenPrice {
  const blockCount = useSelector((state: RootState) => state.block.count);
  const prices = useSelector((state: RootState) =>
    dexPricesSelectorByDenomination(state.wallet, denominationTokenSymbol)
  );
    Severity: Minor
    Found in mobile-app/app/screens/AppNavigator/screens/Portfolio/hooks/TokenPrice.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructSignedBidAndSend has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      vaultId: PlaceAuctionBid["vaultId"],
  index: PlaceAuctionBid["index"],
  tokenAmount: PlaceAuctionBid["tokenAmount"],
  displaySymbol: string,
  dispatch: Dispatch<any>,
    Severity: Major
    Found in mobile-app/app/screens/AppNavigator/screens/Auctions/screens/ConfirmPlaceBidScreen.tsx - About 50 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        if (error !== undefined && error) {
    return (
      <View style={tailwind("flex flex-row items-center")}>
        <ThemedTextV2
          dark={tailwind("text-mono-dark-v2-700")}
      Severity: Minor
      Found in mobile-app/app/screens/PlaygroundNavigator/components/PlaygroundStatus.tsx and 1 other location - About 50 mins to fix
      mobile-app/app/screens/PlaygroundNavigator/components/PlaygroundStatus.tsx on lines 95..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 182.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        if (loading !== undefined && loading) {
    return (
      <View style={tailwind("flex flex-row items-center")}>
        <ThemedTextV2
          dark={tailwind("text-blue-500")}
      Severity: Minor
      Found in mobile-app/app/screens/PlaygroundNavigator/components/PlaygroundStatus.tsx and 1 other location - About 50 mins to fix
      mobile-app/app/screens/PlaygroundNavigator/components/PlaygroundStatus.tsx on lines 122..148

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 182.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function BottomSheetModal has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function BottomSheetModal(props: Props): JSX.Element {
  const bottomSheetModalRef = useRef<Modal>(null);
  const { dismiss } = useBottomSheetModal();
  const { isLight } = useThemeContext();
  const {
      Severity: Minor
      Found in mobile-app/app/components/BottomSheetModal.tsx - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function PoolPairCards has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function PoolPairCards({
  availablePairs,
  onAdd,
  onRemove,
  onSwap,
      Severity: Minor
      Found in mobile-app/app/screens/AppNavigator/screens/Dex/components/PoolPairCards/PoolPairCards.tsx - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language