DeFiCh/wallet

View on GitHub

Showing 335 of 335 total issues

Function EditLoanSchemeScreen has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export function EditLoanSchemeScreen({
  route,
  navigation,
}: Props): JSX.Element {
  const { vaultId } = route.params;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function OCGConfirmScreen has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export function OCGConfirmScreen({ route }: Props): JSX.Element {
  const {
    type,
    fee,
    proposalFee,

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function modifyCollateral has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

async function modifyCollateral(
  { vaultId, tokenAmount, token, isAdd }: ModifyCollateralForm,
  dispatch: Dispatch<any>,
  logger: NativeLoggingProps,
  onBroadcast: () => void,

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getBaseTranslationsMap has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function getBaseTranslationsMap(): Map<string, string[]> {
  const BASE_TRANSLATION_LOCALE = "de";
  const baseTranslations = translations[BASE_TRANSLATION_LOCALE];
  const map = new Map<string, string[]>();

Severity: Minor
Found in shared/translations/reporter/index.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function AnnouncementBanner has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export function AnnouncementBanner({
  hideAnnouncement,
  announcement,
  testID,
}: AnnouncementBannerProps): JSX.Element {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function PromptContent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const PromptContent = React.memo((props: PasscodePromptProps): JSX.Element => {
  return (
    <>
      <ThemedTouchableOpacityV2
        light={tailwind("bg-mono-light-v2-100")}
Severity: Minor
Found in mobile-app/app/screens/TransactionAuthorization/PasscodePrompt.tsx - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return {
    code: ErrorCodes.UnknownError,
    message: getErrorMessage(err),
  };
Severity: Major
Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return {
          code: ErrorCodes.LackOfLiquidity,
          message: "Insufficient liquidity.",
        };
    Severity: Major
    Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return (
          <ThemedIcon
            light={tailwind("text-mono-light-v2-700 opacity-30")}
            dark={tailwind("text-mono-light-v2-700 opacity-30")}
            iconType="MaterialIcons"

        Avoid too many return statements within this function.
        Open

            return {
              code: ErrorCodes.CfpProposalExceedAmount,
              message: "Requested amount is higher than available amount.",
            };
        Severity: Major
        Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return {
                code: ErrorCodes.VaultNotEnoughCollateralization,
                message:
                  "Vault does not meet min. collateral ratio. Add collateral to proceed.",
              };
          Severity: Major
          Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return null;

              Avoid too many return statements within this function.
              Open

                  return {
                    code: ErrorCodes.InsufficientDFIInVault,
                    message: "Insufficient DFI collateral. (≥50%)",
                  };
              Severity: Major
              Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return {
                      code: ErrorCodes.PaybackLoanInvalidPrice,
                      message: "Unable to payback loan due to invalid price.",
                    };
                Severity: Major
                Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return {
                        code: ErrorCodes.DustValue,
                        message: "Input amount is too low. Increase the amount to continue.",
                      };
                  Severity: Major
                  Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return {
                          code: ErrorCodes.NoLiveFixedPrices,
                          message: "No live fixed prices for loan token.",
                        };
                    Severity: Major
                    Found in mobile-app/app/components/OceanInterface/TransactionError.tsx - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return true;

                        Avoid too many return statements within this function.
                        Open

                            return domain === DomainType.DVM ? dvmTokens : evmTokens;

                          Function WalletAlert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export function WalletAlert(option: CustomAlertOption): void {
                            if (Platform.OS !== "web") {
                              Alert.alert(option.title, option.message, option.buttons, option.options);
                            } else if (option.buttons === undefined || option.buttons.length === 0) {
                              window.alert([option.title, option.message].filter(Boolean).join("\n"));
                          Severity: Minor
                          Found in mobile-app/app/components/WalletAlert.tsx - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function RestoreMnemonicWallet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export function RestoreMnemonicWallet(): JSX.Element {
                            const navigation = useNavigation<NavigationProp<WalletParamList>>();
                            const {
                              control,
                              formState: { isValid, isDirty },

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language