DeFiCh/wallet

View on GitHub

Showing 335 of 335 total issues

Function closeVault has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  vaultId: string,
  dispatch: Dispatch<any>,
  onBroadcast: () => void,
  onConfirmation: () => void,
  logger: NativeLoggingProps

    Function useVaultStatus has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      status: LoanVaultState | undefined,
      collateralRatio: BigNumber,
      minColRatio: BigNumber,
      totalLoanAmount: BigNumber,
      totalCollateralValue: BigNumber

      Function useValidCollateralRatio has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        collateralAmounts: LoanVaultTokenAmount[],
        totalCollateralVaultValue: BigNumber,
        loanValue: BigNumber,
        collateralTokenId?: string,
        updatedCollateralAmount?: BigNumber

        Function useResultingCollateralRatio has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          collateralValue: BigNumber,
          existingLoanValue: BigNumber,
          newLoanAmount: BigNumber,
          activePrice: BigNumber,
          interestPerBlock: BigNumber

          Function canAddLiquidity has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            pair: ExtPoolPairData,
            tokenAAmount: BigNumber,
            tokenBAmount: BigNumber,
            balanceA: BigNumber | undefined,
            balanceB: BigNumber | undefined,
          Severity: Minor
          Found in mobile-app/app/screens/AppNavigator/screens/Dex/DexAddLiquidity.tsx - About 35 mins to fix

            Function createVault has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              { loanScheme }: VaultForm,
              dispatch: Dispatch<any>,
              onBroadcast: () => void,
              onConfirmation: () => void,
              logger: NativeLoggingProps,

              Function paybackLoanToken has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                {
                  vaultId,
                  amountToPay,
                  tokenBalance,
                  loanToken,

                Function modifyCollateral has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  { vaultId, tokenAmount, token, isAdd }: ModifyCollateralForm,
                  dispatch: Dispatch<any>,
                  logger: NativeLoggingProps,
                  onBroadcast: () => void,
                  onConfirmation: () => void

                  Function signTransaction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    tx: DfTxSigner,
                    account: WhaleWalletAccount,
                    onAutoRetry: (attempts: number) => Promise<void>,
                    retries: number = 0,
                    logger: NativeLoggingProps

                    Function dvmToDvmSendSigner has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      account: WhaleWalletAccount,
                      token: WalletToken,
                      amount: BigNumber,
                      address: string,
                      networkName: NetworkName,

                      Function dfiConversionCrafter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        amount: BigNumber,
                        convertDirection: ConvertDirection,
                        onBroadcast: () => any,
                        onConfirmation: () => void,
                        submitButtonLabel?: string,
                      Severity: Minor
                      Found in mobile-app/app/api/transaction/dfi_converter.ts - About 35 mins to fix

                        Function authenticateFor has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          promptPassphrase: () => Promise<string>,
                          authentication: Authentication<T>,
                          onAutoRetry: (attempts: number) => Promise<void>,
                          retries: number = 0,
                          logger: NativeLoggingProps

                          Function editLoanScheme has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                            { vaultId, loanScheme }: EditForm,
                            dispatch: Dispatch<any>,
                            onBroadcast: () => void,
                            onConfirmation: () => void,
                            logger: NativeLoggingProps

                            Function getActivePrice has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                              symbol: string,
                              activePrice?: ActivePrice,
                              collateralFactor: string = "1",
                              priceType: ActivePriceType = "ACTIVE",
                              tokenType: TokenType = "LOAN"

                              Function InfoSection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export function InfoSection({
                                type,
                                pair,
                                tokenATotal,
                                tokenBTotal,

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function RowNetworkItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export function RowNetworkItem(props: RowNetworkItemProps): JSX.Element {
                                const navigation = useNavigation<NavigationProp<SettingsParamList>>();
                                const { network, updateNetwork } = useNetworkContext();
                              
                                const onPress = async (): Promise<void> => {
                              Severity: Minor
                              Found in mobile-app/app/components/RowNetworkItem.tsx - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function VerifyMnemonicWallet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export function VerifyMnemonicWallet({
                                route,
                                navigation,
                              }: Props): JSX.Element {
                                const recoveryWords = route.params.words;

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function ResetButton has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export function ResetButton(): JSX.Element {
                                const { isEvmFeatureEnabled } = useDomainContext();
                                const navigation = useNavigation<NavigationProp<SettingsParamList>>();
                                const logger = useLogger();
                                const dispatch = useAppDispatch();

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function ConfirmPinScreen has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export function ConfirmPinScreen({ route }: Props): JSX.Element {
                                const logger = useLogger();
                                const navigation = useNavigation();
                                const { network } = useNetworkContext();
                                const { setWallet } = useWalletPersistenceContext();

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function TokenDropdownButton has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export function TokenDropdownButton(props: {
                                tokenId?: string;
                                symbol?: string;
                                displayedTextSymbol?: string;
                                testID: string;
                              Severity: Minor
                              Found in mobile-app/app/components/TokenDropdownButton.tsx - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language