Sign upLogin

EscolaLMS/Consultations

View on GitHub
Star

Showing 1,241 of 1,241 total issues

Avoid excessively long variable names like $listConsultationsRequest. Keep variable name length under 20.
Open

    public function index(ListConsultationsRequest $listConsultationsRequest): JsonResponse;
Severity: Minor
Found in src/Http/Controllers/Swagger/ConsultationSwagger.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationUserPivot. Keep variable name length under 20.
Open

    public function updateModel(ConsultationUserPivot $consultationUserPivot, array $data): ConsultationUserPivot
Severity: Minor
Found in src/Repositories/ConsultationUserRepository.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationUserPivot. Keep variable name length under 20.
Open

    public function updateUserTermByExecutedAt(ConsultationUserPivot $consultationUserPivot, string $executedAt, array $data): ConsultationUserTerm;
Severity: Minor
Found in src/Repositories/Contracts/ConsultationUserTermRepositoryContract.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationServiceContract. Keep variable name length under 20.
Open

        $consultationServiceContract = app(ConsultationServiceContract::class);
Severity: Minor
Found in src/Http/Resources/ConsultationTermsResource.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationServiceContract. Keep variable name length under 20.
Open

    private ConsultationServiceContract $consultationServiceContract;
Severity: Minor
Found in src/Listeners/ReminderAboutTermListener.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationRepositoryContract. Keep variable name length under 20.
Open

    private ConsultationRepositoryContract $consultationRepositoryContract;
Severity: Minor
Found in src/Services/ConsultationService.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $filterConsultationTermsListDto. Keep variable name length under 20.
Open

        ?FilterConsultationTermsListDto $filterConsultationTermsListDto = null
Severity: Minor
Found in src/Repositories/ConsultationUserRepository.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $showConsultationRequest. Keep variable name length under 20.
Open

    public function show(ShowConsultationRequest $showConsultationRequest, int $id): JsonResponse;
Severity: Minor
Found in src/Http/Controllers/Swagger/ConsultationSwagger.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $filterConsultationTermsListDto. Keep variable name length under 20.
Open

        ?FilterConsultationTermsListDto $filterConsultationTermsListDto = null
Severity: Minor
Found in src/Repositories/Contracts/ConsultationUserRepositoryContract.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $consultationUserPivot. Keep variable name length under 20.
Open

    public function createUserTerm(ConsultationUserPivot $consultationUserPivot, array $data): ConsultationUserTerm;
Severity: Minor
Found in src/Repositories/Contracts/ConsultationUserTermRepositoryContract.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $relationStrategyContract. Keep variable name length under 20.
Open

        RelationStrategyContract $relationStrategyContract
Severity: Minor
Found in src/Strategies/Relations/RelationsStrategy.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $relationStrategyContract. Keep variable name length under 20.
Open

    private RelationStrategyContract $relationStrategyContract;
Severity: Minor
Found in src/Strategies/Relations/RelationsStrategy.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $listConsultationsRequest. Keep variable name length under 20.
Open

    public function forCurrentUserResponse(ListConsultationsRequest $listConsultationsRequest): AnonymousResourceCollection;
Severity: Minor
Found in src/Services/Contracts/ConsultationServiceContract.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The class ConsultationUserResourceDto has 25 fields. Consider redesigning ConsultationUserResourceDto to keep the number of fields under 15.
Open

class ConsultationUserResourceDto extends BaseDto
{
    public ?int $id = null;
    public ?string $firstName = null;
    public ?string $lastName = null;
Severity: Minor
Found in src/Dto/ConsultationUserResourceDto.php by phpmd

TooManyFields

Since: 0.1

Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

Example

class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

Source https://phpmd.org/rules/codesize.html#toomanyfields

Method generateJitsi has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function generateJitsi(int $consultationTermId, ConsultationUserTermDto $dto): array
    {
        /** @var ConsultationUserPivot $consultationTerm */
        $consultationTerm = $this->consultationUserRepositoryContract->find($consultationTermId);
        /** @var ConsultationUserTerm $term */
Severity: Minor
Found in src/Services/ConsultationService.php - About 1 hr to fix

    Avoid using short method names like AddColumnsDateAndStatusToOrders::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        if (
            Schema::hasTable('orders') &&
            !Schema::hasColumns('orders', ['executed_at', 'executed_status'])
    Severity: Minor
    Found in database/migrations/2022_02_07_143005_add_columns_date_and_status_to_orders.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddShortDescInConsultationsTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::table('consultations', function (Blueprint $table) {
            $table->text('short_desc')->nullable();
        });
    Severity: Minor
    Found in database/migrations/2022_03_16_084900_add_short_desc_in_consultations_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddTableRelationsUsersConsultations::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::create('consultation_user', function (Blueprint $table) {
            $table->id();
            $table->unsignedBigInteger('user_id');
    Severity: Minor
    Found in database/migrations/2022_03_18_134435_add_table_relations_users_consultations.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AddSenderStatusInConsultationUserTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::table('consultation_user', function (Blueprint $table) {
            $table->string('reminder_status', 30)->nullable();
        });
    Severity: Minor
    Found in database/migrations/2022_03_24_124751_add_sender_status_in_consultation_user_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like RemoveParticipantTable::up(). The configured minimum method name length is 3.
    Open

        public function up(): void
    {
        Schema::dropIfExists('consultations_participants');
    }
    Severity: Minor
    Found in database/migrations/2022_02_15_104923_remove_participant_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Severity
    Category
    Status
    Source
    Language