Sign upLogin

EscolaLMS/Consultations

View on GitHub
Star

Showing 985 of 985 total issues

Avoid using short method names like CreateConsultationsParticipantsTable::up(). The configured minimum method name length is 3.
Open

    public function up(): void
    {
        Schema::create('consultations_participants', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('consultation_id')->unsigned()->index();
Severity: Minor
Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like AddColumnsDateAndStatusToOrders::up(). The configured minimum method name length is 3.
Open

    public function up(): void
    {
        if (
            Schema::hasTable('orders') &&
            !Schema::hasColumns('orders', ['executed_at', 'executed_status'])
Severity: Minor
Found in database/migrations/2022_02_07_143005_add_columns_date_and_status_to_orders.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like CreateConsultationsTable::up(). The configured minimum method name length is 3.
Open

    public function up(): void
    {
        Schema::create('consultations', function (Blueprint $table) {
            $table->id();
            $table->bigInteger('author_id')->unsigned()->nullable();
Severity: Minor
Found in database/migrations/2022_02_02_133124_create_consultations_table.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Method forCurrentUserResponse has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function forCurrentUserResponse(
        ListConsultationsRequest $listConsultationsRequest
    ): AnonymousResourceCollection {
        $search = $listConsultationsRequest->except(['limit', 'skip', 'order', 'order_by', 'paginate']);
        $consultations = $this->getConsultationsListForCurrentUser($search);
Severity: Minor
Found in src/Services/ConsultationService.php - About 1 hr to fix

    Method prepareFilters has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
    Severity: Minor
    Found in src/Dto/FilterListDto.php - About 1 hr to fix

      Method generateJitsiUrlForEmail has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function generateJitsiUrlForEmail(int $consultationTermId, int $userId): ?string
    {
        $consultationTerm = $this->consultationUserRepositoryContract->find($consultationTermId);
        $isModerator = false;
        $configOverwrite = [];
      Severity: Minor
      Found in src/Services/ConsultationService.php - About 1 hr to fix

        Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run()
    {
        // create permissions
        $admin = Role::findOrCreate(UserRole::ADMIN, 'api');
        $tutor = Role::findOrCreate(UserRole::TUTOR, 'api');
        Severity: Minor
        Found in database/seeders/ConsultationsPermissionSeeder.php - About 1 hr to fix

          Function prepareFilters has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
          Severity: Minor
          Found in src/Dto/FilterListDto.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method toArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function toArray($request)
    {
        $consultationServiceContract = app(ConsultationServiceContract::class);
        $fields = [
            'consultation_term_id' => $this->getKey(),
          Severity: Minor
          Found in src/Http/Resources/ConsultationTermsResource.php - About 1 hr to fix

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class AddConsultationIdColumnForConsultationTermsTable extends Migration
            Severity: Minor
            Found in database/migrations/2022_03_21_182101_add_consultation_id_column_for_consultation_terms_table.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class AddSenderStatusInConsultationUserTable extends Migration
            Severity: Minor
            Found in database/migrations/2022_03_24_124751_add_sender_status_in_consultation_user_table.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class RemoveNotUsedColumnsFromConsultationsTable extends Migration
            Severity: Minor
            Found in database/migrations/2022_04_19_114911_remove_not_used_columns_from_consultations_table.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class RemoveParticipantTable extends Migration
            Severity: Minor
            Found in database/migrations/2022_02_15_104923_remove_participant_table.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class RemoveMissingColumns extends Migration
            Severity: Minor
            Found in database/migrations/2022_02_07_142406_remove_missing_columns.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class CreateConsultationsParticipantsTable extends Migration
            Severity: Minor
            Found in database/migrations/2022_02_02_135907_create_consultations_participants_table.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class AddPivotTableForOrderItemsAndUser extends Migration
            Severity: Minor
            Found in database/migrations/2022_02_10_075849_add_pivot_table_for_order_items_and_user.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class AddProductColumnInConsultationUserTable extends Migration
            Severity: Minor
            Found in database/migrations/2022_06_02_103005_add_product_column_in_consultation_user_table.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class AddColumnsDateAndStatusToOrders extends Migration
            Severity: Minor
            Found in database/migrations/2022_02_07_143005_add_columns_date_and_status_to_orders.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class RemoveRedundantColumnsFromConsultationsTable extends Migration
            Severity: Minor
            Found in database/migrations/2022_02_09_122813_remove_redundant_columns_from_consultations_table.php by phpcodesniffer

            Each class must be in a namespace of at least one level (a top-level vendor name)
            Open

            class ChangeColumnsInConsultationuserTable extends Migration
            Severity: Minor
            Found in database/migrations/2022_03_23_140827_change_columns_in_consultationuser_table.php by phpcodesniffer
            Severity
            Category
            Status
            Source
            Language