EscolaLMS/Consultations

View on GitHub

Showing 1,241 of 1,241 total issues

Method generateJitsiUrlForEmail has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function generateJitsiUrlForEmail(int $consultationTermId, int $userId, string $executedAt): ?string
    {
        /** @var ConsultationUserPivot $consultationTerm */
        $consultationTerm = $this->consultationUserRepositoryContract->find($consultationTermId);
        /** @var ConsultationUserTerm $term */
Severity: Minor
Found in src/Services/ConsultationService.php - About 1 hr to fix

    Method prepareFilters has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function prepareFilters(array $search)
        {
            $dto = new self($search);
            $user = auth()->user();
    
    
    Severity: Minor
    Found in src/Dto/FilterListDto.php - About 1 hr to fix

      Method toArray has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function toArray($request)
          {
              $consultationServiceContract = app(ConsultationServiceContract::class);
      
              $consultation = $this->resource->consultationUser->consultation;
      Severity: Minor
      Found in src/Http/Resources/ConsultationUserTermsResource.php - About 1 hr to fix

        Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run()
            {
                // create permissions
                $admin = Role::findOrCreate(UserRole::ADMIN, 'api');
                $tutor = Role::findOrCreate(UserRole::TUTOR, 'api');
        Severity: Minor
        Found in database/seeders/ConsultationsPermissionSeeder.php - About 1 hr to fix

          Function prepareFilters has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function prepareFilters(array $search)
              {
                  $dto = new self($search);
                  $user = auth()->user();
          
          
          Severity: Minor
          Found in src/Dto/FilterListDto.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method toArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function toArray($request)
              {
                  $consultationServiceContract = app(ConsultationServiceContract::class);
                  $fields = [
                      'consultation_term_id' => $this->resource->consultation_user_id,
          Severity: Minor
          Found in src/Http/Resources/ConsultationTermsResource.php - About 1 hr to fix

            Method toArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function toArray($request)
                {
                    return [
                        'id' => $this->resource->id,
                        'first_name' => $this->resource->firstName,
            Severity: Minor
            Found in src/Http/Resources/ConsultationUserResource.php - About 1 hr to fix

              Method reminderAboutConsultation has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function reminderAboutConsultation(string $reminderStatus): void
                  {
                      /** @var ConsultationUserTerm $userTerm */
                      foreach ($this->getReminderData($reminderStatus) as $userTerm) {
                          event(new ReminderAboutTerm(
              Severity: Minor
              Found in src/Services/ConsultationService.php - About 1 hr to fix

                Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct(int $consultation_user_id, int $consultation_id, string $executed_at, string $status, string $duration, ?User $author, ?string $finished_at = null, ?Collection $users = null)
                Severity: Major
                Found in src/Dto/ConsultationUserTermResourceDto.php - About 1 hr to fix

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class AddTableRelationsUsersConsultations extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class AddNewPermissionMigrate extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class AddMissingsColumnToConsultationsTable extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class RemoveUniqueIndexInConsultaionUserTable extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class CreateConsultationProposedTermsTale extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class AddPivotTableForOrderItemsAndUser extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class ChangeNameColumnsForConsultationsTable extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class AddSenderStatusInConsultationUserTable extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class AddProductColumnInConsultationUserTable extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class AddColumnImagePathForConsultationsTable extends Migration

                  Each class must be in a namespace of at least one level (a top-level vendor name)
                  Open

                  class AddShortDescInConsultationsTable extends Migration
                  Severity
                  Category
                  Status
                  Source
                  Language