Sign upLogin

EscolaLMS/H5P

View on GitHub
Star

Showing 59 of 59 total issues

Method filterParameters has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function filterParameters(&$content)
    {
        if (!empty($content['filtered']) &&
            (!$this->exportEnabled ||
                ($content['slug'] &&
Severity: Major
Found in src/Services/H5PCoreService.php - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                foreach ($keys as $key) {
                $lckey = strtolower($key);
                if (is_array($row) && !isset($row[$key]) && isset($row[$lckey])) {
                    $row[$key] = $row[$lckey];
                }
    Severity: Major
    Found in src/Helpers/Helpers.php and 1 other location - About 1 hr to fix
    src/Helpers/Helpers.php on lines 27..35

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    foreach ($keys as $key) {
                    $lckey = strtolower($key);
                    if (is_array($row) && !isset($row[$key]) && isset($row[$lckey])) {
                        $row[$key] = $row[$lckey];
                    }
    Severity: Major
    Found in src/Helpers/Helpers.php and 1 other location - About 1 hr to fix
    src/Helpers/Helpers.php on lines 16..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            $settings = [
            'baseUrl' => $config['domain'],
            'url' => $config['url'],
            'postUserStatistics' => config('hh5p.h5p_track_user'),
            'ajax' => [
    Severity: Major
    Found in src/Services/HeadlessH5PService.php and 1 other location - About 1 hr to fix
    src/Services/HeadlessH5PService.php on lines 226..241

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            $settings = [
            'baseUrl' => $config['domain'],
            'url' => $config['url'],
            'postUserStatistics' => config('hh5p.h5p_track_user'),
            'ajax' => [
    Severity: Major
    Found in src/Services/HeadlessH5PService.php and 1 other location - About 1 hr to fix
    src/Services/HeadlessH5PService.php on lines 397..413

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function addMoreHtmlTags has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function addMoreHtmlTags($semantics) {
        foreach ($semantics as $field) {
            while ($field->type === 'list') {
                $field = $field->field;
            }
    Severity: Minor
    Found in src/Services/HeadlessH5PService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function reinstallLibraryDependencies has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function reinstallLibraryDependencies(string $machineName): void
    {
        if (!$this->editor->ajaxInterface->getContentTypeCache($machineName) ||
            !$this->callHubEndpoint(H5PHubEndpoints::CONTENT_TYPES . $machineName) ||
            !$this->core->librariesJsonData
    Severity: Minor
    Found in src/Services/HeadlessH5PService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method toArray has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function toArray($request = null): array
    {
        return [
            'id' => $this->id,
            'name' => $this->name,
    Severity: Minor
    Found in src/Http/Resources/LibraryResource.php - About 1 hr to fix

      Method cacheAssets has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function cacheAssets(&$files, $key)
    {
        foreach ($files as $type => $assets) {
            if (empty($assets)) {
                continue; // Skip no assets
      Severity: Minor
      Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

        Method saveLibraryUsage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function saveLibraryUsage($contentId, $librariesInUse)
    {
        $contentLibraries = array_map(function ($value) use ($contentId) {
            $contentLibrary = H5PContentLibrary::query()
                ->where([
        Severity: Minor
        Found in src/Repositories/H5PRepository.php - About 1 hr to fix

          Method getSettingsForContent has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getSettingsForContent($id): array
    {
        $content = $this->getCore()->loadContent($id);
        $content['metadata']['title'] = $content['title'];
          Severity: Minor
          Found in src/Services/HeadlessH5PService.php - About 1 hr to fix

            Method down has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function down()
    {
        if (strpos(DB::connection()->getName(), 'sqlite') !== FALSE) { 
            return;
        }
            Severity: Minor
            Found in database/migrations/2022_04_11_095716_change_hh5p_contents_libraries_structure_table.php - About 1 hr to fix

              Method downloadAndSeed has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function downloadAndSeed($lib, $addContent = false)
    {
        // eg https://h5p.org/sites/default/files/h5p/exports/interactive-video-2-618.h5p
        $url = "https://h5p.org/sites/default/files/h5p/exports/$lib";
              Severity: Minor
              Found in database/seeders/ContentLibrarySeeder.php - About 1 hr to fix

                Method replaceContentTypeCache has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function replaceContentTypeCache($contentTypeCache)
    {
        foreach ($contentTypeCache->contentTypes as $ct) {
           $data[] = [
                'machine_name' => $ct->id,
                Severity: Minor
                Found in src/Repositories/H5PRepository.php - About 1 hr to fix

                  Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          H5PFrameworkInterface  $repository,
        H5PFileStorage         $fileStorage,
        H5PCore                $core,
        H5PValidator           $validator,
        H5PStorage             $storage,
                  Severity: Major
                  Found in src/Services/HeadlessH5PService.php - About 1 hr to fix

                    Function copyFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function copyFiles($source, $destination) {
        if (!$this->isDirReady($destination)) {
            throw new Exception('unabletocopy');
        }
                    Severity: Minor
                    Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function textAddonMatches has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function textAddonMatches($params, $pattern, $found = false) {
        $type = gettype($params);
        if ($type === 'string') {
            if (preg_match($pattern, $params) === 1) {
                return true;
                    Severity: Minor
                    Found in src/Services/H5PCoreService.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function cacheAssets has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function cacheAssets(&$files, $key)
    {
        foreach ($files as $type => $assets) {
            if (empty($assets)) {
                continue; // Skip no assets
                    Severity: Minor
                    Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function copyVendorFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function copyVendorFiles($source, $destination) {
        if (!$this->isDirReady($destination)) {
            throw new Exception('unabletocopy');
        }
                    Severity: Minor
                    Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method saveLibraryData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Confirmed

                        public function saveLibraryData(&$libraryData, $new = true)
    {
        $library = [
            'name' => $libraryData['machineName'],
            'title' => $libraryData['title'],
                    Severity: Minor
                    Found in src/Repositories/H5PRepository.php - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language