EscolaLMS/H5P

View on GitHub

Showing 62 of 62 total issues

Function cacheAssets has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function cacheAssets(&$files, $key)
    {
        foreach ($files as $type => $assets) {
            if (empty($assets)) {
                continue; // Skip no assets
Severity: Minor
Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function copyFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function copyFiles($source, $destination) {
        if (!$this->isDirReady($destination)) {
            throw new Exception('unabletocopy');
        }

Severity: Minor
Found in src/Repositories/H5PFileStorageRepository.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method saveLibraryData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Confirmed

    public function saveLibraryData(&$libraryData, $new = true)
    {
        $library = [
            'name' => $libraryData['machineName'],
            'title' => $libraryData['title'],
Severity: Minor
Found in src/Repositories/H5PRepository.php - About 1 hr to fix

    Method fetchExternalData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function fetchExternalData($url, $data = null, $blocking = true, $stream = null, $fullData = false, $headers = [], $files = [], $method = 'POST')
        {
            @set_time_limit(0);
            $options = [
                'timeout'  => !empty($blocking) ? 30 : 0.01,
    Severity: Minor
    Found in src/Repositories/H5PRepository.php - About 1 hr to fix

      Method fetchExternalData has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function fetchExternalData($url, $data = null, $blocking = true, $stream = null, $fullData = false, $headers = [], $files = [], $method = 'POST')
      Severity: Major
      Found in src/Repositories/H5PRepository.php - About 1 hr to fix

        Function getEditorSettings has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getEditorSettings($content = null): array
            {
                $lang = config('hh5p.language');
        
                $config = $this->getConfig();
        Severity: Minor
        Found in src/Services/HeadlessH5PService.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function fetchExternalData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function fetchExternalData($url, $data = null, $blocking = true, $stream = null, $fullData = false, $headers = [], $files = [], $method = 'POST')
            {
                @set_time_limit(0);
                $options = [
                    'timeout'  => !empty($blocking) ? 30 : 0.01,
        Severity: Minor
        Found in src/Repositories/H5PRepository.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct(H5PFrameworkInterface $H5PFramework, $path, $url, $language = 'en', $export = FALSE)
        Severity: Minor
        Found in src/Services/H5PCoreService.php - About 35 mins to fix

          Function createFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function createFile(string $fileName): bool
              {
                  if (!is_readable($fileName) && $this->arrayFiles) {
                      $stream = fopen('php://memory', 'r+');
                      foreach ($this->arrayFiles as $path) {
          Severity: Minor
          Found in src/Helpers/MargeFiles.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function downloadAndSeed has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function downloadAndSeed($lib, $addContent = false)
              {
                  // eg https://h5p.org/sites/default/files/h5p/exports/interactive-video-2-618.h5p
                  $url = "https://h5p.org/sites/default/files/h5p/exports/$lib";
          
          
          Severity: Minor
          Found in database/seeders/ContentLibrarySeeder.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function generateContentSlug has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function generateContentSlug($content) {
                  $slug = H5PCore::slugify($content['title']);
          
                  $available = NULL;
                  while (!$available) {
          Severity: Minor
          Found in src/Services/H5PCoreService.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function deleteFileTreeLocal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function deleteFileTreeLocal($dir)
              {
                  if (!is_dir($dir)) {
                      return false;
                  }
          Severity: Minor
          Found in src/Helpers/Helpers.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function populateFileList has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private static function populateFileList($dir, &$files, $relative = '') {
                  $strip = strlen($dir);
                  $contents = Storage::allFiles($dir);
                  if (!empty($contents)) {
                      foreach ($contents as $file) {
          Severity: Minor
          Found in src/Services/H5PExportService.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function downloadAndSeed has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function downloadAndSeed($lib, $addContent = false)
              {
                  // eg https://h5p.org/sites/default/files/h5p/exports/interactive-video-2-618.h5p
                  $url = "https://h5p.org/sites/default/files/h5p/exports/$lib";
          
          
          Severity: Minor
          Found in src/Commands/H5PSeedCommand.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in src/Repositories/H5PRepository.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return true;
            Severity: Major
            Found in src/Repositories/H5PRepository.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return false;
              Severity: Major
              Found in src/Repositories/H5PRepository.php - About 30 mins to fix

                Function libraryInstall has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function libraryInstall($machineName)
                    {
                        // Determine which content type to install from post data
                        if (!$machineName) {
                            throw new H5PException(H5PException::NO_CONTENT_TYPE);
                Severity: Minor
                Found in src/Services/HeadlessH5PService.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function additionalTranslations has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function additionalTranslations(array $libraryLanguages, H5PLibrary $library): array
                    {
                        $additionalLanguageCodes = ['pl'];
                        foreach ($additionalLanguageCodes as $languageCode) {
                            if (!isset($libraryLanguages[$languageCode])) {
                Severity: Minor
                Found in src/Repositories/H5PRepository.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function instantiateFromRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function instantiateFromRequest(Request $request): self
                    {
                        $criteria = new Collection();
                        $user = auth()->user();
                
                
                Severity: Minor
                Found in src/Dtos/ContentFilterCriteriaDto.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language