ForestAdmin/forest-express-sequelize

View on GitHub

Showing 77 of 78 total issues

Function ApimapFieldBuilder has a Cognitive Complexity of 72 (exceeds 5 allowed). Consider refactoring.
Open

function ApimapFieldBuilder(model, column, options) {
  const DataTypes = options.Sequelize;

  function isRequired() {
    // eslint-disable-next-line
Severity: Minor
Found in src/services/apimap-field-builder.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SearchBuilder has 205 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function SearchBuilder(model, opts, params, fieldNamesRequested) {
  const schema = Interface.Schemas.schemas[model.name];
  const DataTypes = opts.Sequelize;
  const fields = _.clone(schema.fields);
  let associations = _.clone(model.associations);
Severity: Major
Found in src/services/search-builder.js - About 1 day to fix

    Function LineStatGetter has 201 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function LineStatGetter(model, params, options, user) {
      const schema = Schemas.schemas[model.name];
      const timeRange = params.time_range.toLowerCase();
    
      function getAggregateField() {
    Severity: Major
    Found in src/services/line-stat-getter.js - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        function getGroupByDateFieldFormatedForMySQL(currentTimeRange) {
          const groupByDateFieldFormated = `\`${groupByDateField.replace('.', '`.`')}\``;
          switch (currentTimeRange) {
            case 'day':
              return options.Sequelize.fn(
      Severity: Major
      Found in src/services/line-stat-getter.js and 1 other location - About 6 hrs to fix
      src/services/line-stat-getter.js on lines 56..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 174.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        function getGroupByDateFieldFormatedForMSSQL(currentTimeRange) {
          const groupByDateFieldFormated = `[${groupByDateField.replace('.', '].[')}]`;
          switch (currentTimeRange) {
            case 'day':
              return options.Sequelize.fn(
      Severity: Major
      Found in src/services/line-stat-getter.js and 1 other location - About 6 hrs to fix
      src/services/line-stat-getter.js on lines 26..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 174.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function FiltersParser has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
      Open

      function FiltersParser(modelSchema, timezone, options) {
        this.OPERATORS = Operators.getInstance(options);
        this.operatorDateParser = new BaseOperatorDateParser({ operators: this.OPERATORS, timezone });
      
        this.perform = async (filtersString) =>
      Severity: Minor
      Found in src/services/filters-parser.js - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ApimapFieldBuilder has 142 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function ApimapFieldBuilder(model, column, options) {
        const DataTypes = options.Sequelize;
      
        function isRequired() {
          // eslint-disable-next-line
      Severity: Major
      Found in src/services/apimap-field-builder.js - About 5 hrs to fix

        Function perform has 138 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          this.perform = (associationName) => {
            if (!params.search) { return null; }
        
            if (hasSearchFields) {
              selectSearchFields();
        Severity: Major
        Found in src/services/search-builder.js - About 5 hrs to fix

          Function LineStatGetter has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
          Open

          function LineStatGetter(model, params, options, user) {
            const schema = Schemas.schemas[model.name];
            const timeRange = params.time_range.toLowerCase();
          
            function getAggregateField() {
          Severity: Minor
          Found in src/services/line-stat-getter.js - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function FiltersParser has 126 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function FiltersParser(modelSchema, timezone, options) {
            this.OPERATORS = Operators.getInstance(options);
            this.operatorDateParser = new BaseOperatorDateParser({ operators: this.OPERATORS, timezone });
          
            this.perform = async (filtersString) =>
          Severity: Major
          Found in src/services/filters-parser.js - About 5 hrs to fix

            Function SearchBuilder has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

            function SearchBuilder(model, opts, params, fieldNamesRequested) {
              const schema = Interface.Schemas.schemas[model.name];
              const DataTypes = opts.Sequelize;
              const fields = _.clone(schema.fields);
              let associations = _.clone(model.associations);
            Severity: Minor
            Found in src/services/search-builder.js - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function init has 105 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.init = function init(opts) {
              exports.opts = opts;
            
              if (!opts.objectMapping) {
                Interface.logger.error('The objectMapping option appears to be missing. Please make sure it is set correctly.');
            Severity: Major
            Found in src/index.js - About 4 hrs to fix

              Function init has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

              exports.init = function init(opts) {
                exports.opts = opts;
              
                if (!opts.objectMapping) {
                  Interface.logger.error('The objectMapping option appears to be missing. Please make sure it is set correctly.');
              Severity: Minor
              Found in src/index.js - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function exports has 90 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = (model, opts) => {
                const fields = [];
                const fieldNamesToExclude = [];
              
                function getTypeForAssociation(association) {
              Severity: Major
              Found in src/adapters/sequelize.js - About 3 hrs to fix

                Function ApimapFieldTypeDetector has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                Open

                function ApimapFieldTypeDetector(column, options) {
                  const DataTypes = options.Sequelize;
                
                  this.perform = () => {
                    if (column.type instanceof DataTypes.STRING
                Severity: Minor
                Found in src/services/apimap-field-type-detector.js - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function PieStatGetter has 85 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function PieStatGetter(model, params, options, user) {
                  const needsDateOnlyFormating = isVersionLessThan(options.Sequelize, '4.0.0');
                
                  const schema = Schemas.schemas[model.name];
                  let associationSplit;
                Severity: Major
                Found in src/services/pie-stat-getter.js - About 3 hrs to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          } else {
                            columnName = field.columnName || field.field;
                  
                            condition = opts.Sequelize.where(
                              lowerIfNecessary(opts.Sequelize.col(`${aliasName}.${columnName}`)),
                  Severity: Major
                  Found in src/services/search-builder.js and 1 other location - About 3 hrs to fix
                  src/services/search-builder.js on lines 148..156

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 101.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          } else if (primaryKeyType instanceof DataTypes.STRING) {
                            columnName = field.columnName || field.field;
                            condition = opts.Sequelize.where(
                              lowerIfNecessary(opts.Sequelize.col(`${aliasName}.${columnName}`)),
                              ' LIKE ',
                  Severity: Major
                  Found in src/services/search-builder.js and 1 other location - About 3 hrs to fix
                  src/services/search-builder.js on lines 182..191

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 101.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function getValidations has 77 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    function getValidations(automaticValue) {
                      const validations = [];
                  
                      // NOTICE: Do not inspect validation for autogenerated fields, it would
                      //         block the record creation/update.
                  Severity: Major
                  Found in src/services/apimap-field-builder.js - About 3 hrs to fix

                    Function exports has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                    Open

                    module.exports = (model, opts) => {
                      const fields = [];
                      const fieldNamesToExclude = [];
                    
                      function getTypeForAssociation(association) {
                    Severity: Minor
                    Found in src/adapters/sequelize.js - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language