ForestAdmin/forest-express-sequelize

View on GitHub

Showing 80 of 82 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  constructor(model, params, newRecord, user) {
    this._model = model.unscoped();
    this._params = params;
    this._newRecord = newRecord;
    this._user = user;
Severity: Major
Found in src/services/resource-updater.js and 1 other location - About 1 hr to fix
src/services/resources-remover.js on lines 6..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function perform has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  this.perform = () => {
    const associatedIds = _.map(data.data, (value) => value.id);
    return orm.findRecord(model, params.recordId)
      .then((record) => {
        let removeAssociation = false;
Severity: Minor
Found in src/services/has-many-dissociator.js - About 1 hr to fix

    Function getGroupByDateFieldFormatedForSQLite has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function getGroupByDateFieldFormatedForSQLite(currentTimeRange) {
        switch (currentTimeRange) {
          case 'day': {
            return options.Sequelize.fn(
              'STRFTIME',
    Severity: Minor
    Found in src/services/line-stat-getter.js - About 1 hr to fix

      Function perform has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        this.perform = async () => {
          const { timezone } = params;
          const parentSequelizeOptions = await getSequelizeOptionsForModel(parentModel, user, timezone);
          const childSequelizeOptions = await getSequelizeOptionsForModel(childModel, user, timezone);
      
      
      Severity: Minor
      Found in src/services/leaderboard-stat-getter.js - About 1 hr to fix

        Function removeDuplicateAssociations has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function removeDuplicateAssociations(model, includeList) {
          // Remove duplicates
          includeList.sort((include1, include2) => (include1.as < include2.as ? -1 : 1));
          for (let i = 1; i < includeList.length; i += 1) {
            if (includeList[i - 1].as === includeList[i].as) {
        Severity: Minor
        Found in src/utils/sequelize-compatibility.js - About 1 hr to fix

          Function perform has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            async perform() {
              const { timezone } = this._params;
              const scopeFilters = await scopeManager.getScopeForUser(this._user, this._model.name, true);
          
              const queryOptions = new QueryOptions(this._model);
          Severity: Minor
          Found in src/services/resource-updater.js - About 1 hr to fix

            Function QueryBuilder has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function QueryBuilder() {
              this.getIncludes = (modelForIncludes, fieldNamesRequested) => {
                const includes = [];
            
                Object.values(modelForIncludes.associations)
            Severity: Minor
            Found in src/services/query-builder.js - About 1 hr to fix

              Function getGroupByDateFieldFormatedForMSSQL has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function getGroupByDateFieldFormatedForMSSQL(currentTimeRange) {
                  const groupByDateFieldFormated = `[${groupByDateField.replace('.', '].[')}]`;
                  switch (currentTimeRange) {
                    case 'day':
                      return options.Sequelize.fn(
              Severity: Minor
              Found in src/services/line-stat-getter.js - About 1 hr to fix

                Function perform has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  async perform() {
                    // buildInstance
                    const recordCreated = this.model.build(this.body);
                
                    // handleAssociationsBeforeSave
                Severity: Minor
                Found in src/services/resource-creator.js - About 1 hr to fix

                  Function getGroupByDateFieldFormatedForMySQL has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    function getGroupByDateFieldFormatedForMySQL(currentTimeRange) {
                      const groupByDateFieldFormated = `\`${groupByDateField.replace('.', '`.`')}\``;
                      switch (currentTimeRange) {
                        case 'day':
                          return options.Sequelize.fn(
                  Severity: Minor
                  Found in src/services/line-stat-getter.js - About 1 hr to fix

                    Function getIncludes has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      this.getIncludes = (modelForIncludes, fieldNamesRequested) => {
                        const includes = [];
                    
                        Object.values(modelForIncludes.associations)
                          .filter((association) => [HAS_ONE, BELONGS_TO].includes(association.associationType))
                    Severity: Minor
                    Found in src/services/query-builder.js - About 1 hr to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                    if (field.field === schemaAssociation.idField) {
                                      if (field.type === 'Number') {
                                        const value = parseInt(params.search, 10) || 0;
                                        if (value) {
                                          condition = opts.Sequelize.where(column, ' = ', value);
                      Severity: Major
                      Found in src/services/search-builder.js and 1 other location - About 1 hr to fix
                      src/services/search-builder.js on lines 237..248

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 56.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      if (field.type === 'Number') {
                                        const value = parseInt(params.search, 10) || 0;
                                        if (value) {
                                          condition = opts.Sequelize.where(column, ' = ', value);
                                          hasExtendedConditions = true;
                      Severity: Major
                      Found in src/services/search-builder.js and 1 other location - About 1 hr to fix
                      src/services/search-builder.js on lines 236..254

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 56.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function _buildQueryOptions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        async _buildQueryOptions(buildOptions = {}) {
                          const { forCount, tableAlias } = buildOptions;
                          const {
                            fields, filters,
                            search, searchExtended, segment, segmentQuery, timezone,
                      Severity: Minor
                      Found in src/services/resources-getter.js - About 1 hr to fix

                        Function perform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          this.perform = async () => {
                            const { filter, timezone } = params;
                            const scopeFilters = await scopeManager.getScopeForUser(user, model.name, true);
                        
                            const queryOptions = new QueryOptions(model, { includeRelations: true });
                        Severity: Minor
                        Found in src/services/line-stat-getter.js - About 1 hr to fix

                          Function PieStatGetter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function PieStatGetter(model, params, options, user) {
                            const needsDateOnlyFormating = isVersionLessThan(options.Sequelize, '4.0.0');
                          
                            const schema = Schemas.schemas[model.name];
                            let associationSplit;
                          Severity: Minor
                          Found in src/services/pie-stat-getter.js - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid deeply nested control flow statements.
                          Open

                                        } else if (field.type === 'String') {
                                          condition = getStringExtendedCondition(
                                            modelAssociation.rawAttributes[field.field], params.search, column,
                                          );
                                          hasExtendedConditions = !!condition;
                          Severity: Major
                          Found in src/services/search-builder.js - About 45 mins to fix

                            Function search has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                            Open

                              async search(search, searchExtended) {
                                if (!search) return [];
                            
                                const options = { Sequelize: this._Sequelize };
                                const fieldNames = this._requestedFields.size ? [...this._requestedFields] : null;
                            Severity: Minor
                            Found in src/services/query-options.js - About 45 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function perform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                            Open

                              async perform() {
                                const { timezone } = this._params;
                                const scopeFilters = await scopeManager.getScopeForUser(this._user, this._model.name, true);
                            
                                const queryOptions = new QueryOptions(this._model);
                            Severity: Minor
                            Found in src/services/resource-updater.js - About 45 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Avoid deeply nested control flow statements.
                            Open

                                    if (conditionValue !== null) {
                                      condition[field.field] = conditionValue;
                                      pushCondition(condition, field.field);
                                    }
                            Severity: Major
                            Found in src/services/search-builder.js - About 45 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language