ForestAdmin/forest-express-sequelize

View on GitHub

Showing 76 of 78 total issues

Function HasManyAssociator has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function HasManyAssociator(model, association, opts, params, data) {
Severity: Minor
Found in src/services/has-many-associator.js - About 35 mins to fix

    Function HasManyDissociator has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function HasManyDissociator(model, association, options, params, data) {
    Severity: Minor
    Found in src/services/has-many-dissociator.js - About 35 mins to fix

      Function LiveQueryChecker has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function LiveQueryChecker() {
        const QUERY_SELECT = /^SELECT\s[^]*FROM\s[^]*$/i;
      
        this.perform = function perform(query) {
          if (!query) {
      Severity: Minor
      Found in src/services/live-query-checker.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return 'Number';
      Severity: Major
      Found in src/services/apimap-field-type-detector.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return 'Json';
        Severity: Major
        Found in src/services/apimap-field-type-detector.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return 'Point';
          Severity: Major
          Found in src/services/apimap-field-type-detector.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function getOrder() {
                return isMSSQL(model.sequelize) ? [getGroupByDateFieldFormatedForMSSQL(timeRange)] : [options.Sequelize.literal('1')];
              }
            Severity: Minor
            Found in src/services/line-stat-getter.js and 1 other location - About 30 mins to fix
            src/services/line-stat-getter.js on lines 191..193

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                return currentPreviousInterval;
            Severity: Major
            Found in src/services/filters-parser.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return;
              Severity: Major
              Found in src/services/search-builder.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return 'Date';
                Severity: Major
                Found in src/services/apimap-field-type-detector.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        try {
                          const schema = getSchemaForAssociation(association);
                          fields.push(schema);
                        } catch (error) {
                          Interface.logger.error(`Cannot fetch properly association ${association.associationAccessor} of model ${model.name}`, error);
                  Severity: Minor
                  Found in src/adapters/sequelize.js and 1 other location - About 30 mins to fix
                  src/adapters/sequelize.js on lines 66..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Avoid too many return statements within this function.
                  Open

                        return [new ApimapFieldTypeDetector({ type: column.type.type }, options).perform()];
                  Severity: Major
                  Found in src/services/apimap-field-type-detector.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      function getGroupBy() {
                        return isMSSQL(model.sequelize) ? [getGroupByDateFieldFormatedForMSSQL(timeRange)] : [options.Sequelize.literal('1')];
                      }
                    Severity: Minor
                    Found in src/services/line-stat-getter.js and 1 other location - About 30 mins to fix
                    src/services/line-stat-getter.js on lines 195..197

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this function.
                    Open

                        return null;
                    Severity: Major
                    Found in src/services/apimap-field-type-detector.js - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                            try {
                              if (column.references && !column.primaryKey) { return; }
                      
                              const schema = new ApimapFieldBuilder(model, column, opts).perform();
                      
                      
                      Severity: Minor
                      Found in src/adapters/sequelize.js and 1 other location - About 30 mins to fix
                      src/adapters/sequelize.js on lines 81..86

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 45.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Avoid too many return statements within this function.
                      Open

                            return 'Time';
                      Severity: Major
                      Found in src/services/apimap-field-type-detector.js - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language