Sign upLogin

FrankProjects/UltimateWarfare

View on GitHub
Star

Showing 131 of 131 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $builder
            ->add(
                'health',
                NumberType::class,
                [
Severity: Major
Found in src/Form/Admin/GameUnit/BattleStatsType.php and 1 other location - About 2 hrs to fix
src/Form/Admin/GameUnitType.php on lines 23..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function deposit(Request $request): Response
    {
        try {
            $resources = $request->get('resources');
            if ($request->isMethod(Request::METHOD_POST) && $resources !== null) {
Severity: Major
Found in src/Controller/Game/FederationBankController.php and 1 other location - About 2 hrs to fix
src/Controller/Game/FederationBankController.php on lines 42..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function withdraw(Request $request): Response
    {
        try {
            $resources = $request->get('resources');
            if ($request->isMethod(Request::METHOD_POST) && $resources !== null) {
Severity: Major
Found in src/Controller/Game/FederationBankController.php and 1 other location - About 2 hrs to fix
src/Controller/Game/FederationBankController.php on lines 22..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method buildForm has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add(
                'seed',
Severity: Major
Found in src/Form/Admin/World/MapConfigurationType.php - About 2 hrs to fix

    Federation has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Federation
{
    private ?int $id;
    private string $name = '';
    private Player $founder;
    Severity: Minor
    Found in src/Entity/Federation.php - About 2 hrs to fix

      Method buildForm has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add(
                'name',
      Severity: Major
      Found in src/Form/ContactType.php - About 2 hrs to fix

        Method constructGameUnits has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function constructGameUnits(
        WorldRegion $region,
        Player $player,
        GameUnitType $gameUnitType,
        array $constructionData
        Severity: Major
        Found in src/Service/Action/ConstructionActionService.php - About 2 hrs to fix

          Method buildForm has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add(
                'email',
          Severity: Major
          Found in src/Form/RegistrationType.php - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php

declare(strict_types=1);

namespace FrankProjects\UltimateWarfare\Form\Admin\GameUnit\BattleStats;
            Severity: Major
            Found in src/Form/Admin/GameUnit/BattleStats/AbstractBattleStatsType.php and 1 other location - About 1 hr to fix
            src/Form/Admin/AbstractGameResourcesType.php on lines 1..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php

declare(strict_types=1);

namespace FrankProjects\UltimateWarfare\Form\Admin;
            Severity: Major
            Found in src/Form/Admin/AbstractGameResourcesType.php and 1 other location - About 1 hr to fix
            src/Form/Admin/GameUnit/BattleStats/AbstractBattleStatsType.php on lines 1..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function processSuccess has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                public function processSuccess(): void
    {
        $totalBuildings = 0;
        foreach ($this->region->getWorldRegionUnits() as $worldRegionUnit) {
            if ($worldRegionUnit->getGameUnit()->getGameUnitType()->getId() == GameUnitType::GAME_UNIT_TYPE_BUILDINGS) {
            Severity: Minor
            Found in src/Service/OperationEngine/OperationProcessor/MissileAttack.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function sendAid has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                public function sendAid(Player $player, int $playerId, array $resources): void
    {
        $this->ensureFederationEnabled($player);

        if ($player->getId() === $playerId) {
            Severity: Minor
            Found in src/Service/Action/FederationActionService.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method sendAid has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function sendAid(Player $player, int $playerId, array $resources): void
    {
        $this->ensureFederationEnabled($player);

        if ($player->getId() === $playerId) {
            Severity: Minor
            Found in src/Service/Action/FederationActionService.php - About 1 hr to fix

              Method sendGameUnits has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function sendGameUnits(Request $request, int $regionId): Response
    {
        $player = $this->getPlayer();

        try {
              Severity: Minor
              Found in src/Controller/Game/FleetController.php - About 1 hr to fix

                Function requestPasswordReset has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function requestPasswordReset(Request $request): Response
    {
        $email = (string) $request->request->get('email');
        if ($email !== '') {
            $user = $this->userRepository->findByEmail($email);
                Severity: Minor
                Found in src/Controller/Site/ResetPasswordController.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method buildForm has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add(
                'health',
                Severity: Minor
                Found in src/Form/Admin/GameUnit/BattleStatsType.php - About 1 hr to fix

                  Method processPlayerIncome has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function processPlayerIncome(Player $player, int $timestamp): bool
    {
        // Don't update player income more than once every minute...
        if ($player->getTimestampUpdate() + 60 > $timestamp) {
            return true;
                  Severity: Minor
                  Found in src/Service/GameEngine.php - About 1 hr to fix

                    Method attackSelectGameUnits has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function attackSelectGameUnits(Request $request, int $regionId, int $playerRegionId): Response
    {
        $player = $this->getPlayer();

        try {
                    Severity: Minor
                    Found in src/Controller/Game/AttackController.php - About 1 hr to fix

                      Method remove has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function remove(Player $player): void
    {
        foreach ($player->getMarketItems() as $marketItem) {
            $this->entityManager->remove($marketItem);
        }
                      Severity: Minor
                      Found in src/Repository/Doctrine/DoctrinePlayerRepository.php - About 1 hr to fix

                        Method buildForm has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add(
                'title',
                        Severity: Minor
                        Found in src/Form/Admin/GameNewsType.php - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language