Sign upLogin

GEANT/CAT

View on GitHub
Star

Showing 577 of 577 total issues

File SanityTests.php has 654 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a
Severity: Major
Found in core/SanityTests.php - About 1 day to fix

    File edit_silverbullet.php has 641 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*
 * Contributions to this work were made on behalf of the GÉANT project, a 
 * project that has received funding from the European Union’s Horizon 2020 
 * research and innovation programme under Grant Agreement No. 731122 (GN4-2).
    Severity: Major
    Found in web/admin/edit_silverbullet.php - About 1 day to fix

      Method __construct has 277 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct()
    {
        parent::__construct();
        common\Entity::intoThePotatoes();
      Severity: Major
      Found in core/CAT.php - About 1 day to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $messages = [
        'quit'=> _("Really quit?"),
        'username_prompt'=> _("enter your userid"),
        'enter_password' => _("enter password"),
        'enter_import_password' => _("enter your import password"),
        Severity: Major
        Found in devices/linux/DeviceLinux.php and 1 other location - About 1 day to fix
        devices/linux/DeviceLinuxSh.php on lines 128..154

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 308.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $messages = [
        'QUIT'=> _("Really quit?"),
        'USERNAME_PROMPT'=> _("enter your userid"),
        'ENTER_PASSWORD' => _("enter password"),
        'ENTER_IMPORT_PASSWORD' => _("enter your import password"),
        Severity: Major
        Found in devices/linux/DeviceLinuxSh.php and 1 other location - About 1 day to fix
        devices/linux/DeviceLinux.php on lines 126..152

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 308.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File overview_org.php has 620 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a 
 * project that has received funding from the European Union’s Framework
        Severity: Major
        Found in web/admin/overview_org.php - About 1 day to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function generateCompatibleCsr($privateKey, $fed, $username): array
    {
        $tempdirArray = \core\common\Entity::createTemporaryDirectory("test");
        $tempdir = $tempdirArray['dir'];
        // dump private key into directory
          Severity: Major
          Found in core/CertificationAuthorityEduPkiServer.php and 1 other location - About 1 day to fix
          core/CertificationAuthorityEduPki.php on lines 386..417

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 296.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function generateCompatibleCsr($privateKey, $fed, $username): array
    {
        $tempdirArray = \core\common\Entity::createTemporaryDirectory("test");
        $tempdir = $tempdirArray['dir'];
        // dump private key into directory
          Severity: Major
          Found in core/CertificationAuthorityEduPki.php and 1 other location - About 1 day to fix
          core/CertificationAuthorityEduPkiServer.php on lines 458..489

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 296.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method displayDeploymentPropertyWidget has 242 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function displayDeploymentPropertyWidget(&$deploymentObject) {
    // RADIUS status icons
    $radiusMessages = [
        \core\AbstractDeployment::RADIUS_OK => ['icon' => '../resources/images/icons/Quetto/check-icon.png', 'text' => _("Successfully set profile")],
        \core\AbstractDeployment::RADIUS_FAILURE => ['icon' => '../resources/images/icons/Quetto/no-icon.png', 'text' => _("Some problem occurred during profile update")],
          Severity: Major
          Found in web/admin/overview_org.php - About 1 day to fix

            Method htmlHeadCode has 222 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function htmlHeadCode() {
        $cat = new \core\CAT();
        \core\common\Entity::intoThePotatoes();
        $retval = "<script type='text/javascript' src='https://maps.googleapis.com/maps/api/js?key=" . \config\Master::APPEARANCE['google_maps_api_key'] . "'></script>
    <script type='text/javascript'>
            Severity: Major
            Found in web/lib/admin/MapGoogle.php - About 1 day to fix

              File MobileconfigSuperclass.php has 530 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a
              Severity: Major
              Found in devices/apple_mobileconfig/MobileconfigSuperclass.php - About 1 day to fix

                Function displayDeploymentPropertyWidget has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
                Open

                function displayDeploymentPropertyWidget(&$deploymentObject) {
    // RADIUS status icons
    $radiusMessages = [
        \core\AbstractDeployment::RADIUS_OK => ['icon' => '../resources/images/icons/Quetto/check-icon.png', 'text' => _("Successfully set profile")],
        \core\AbstractDeployment::RADIUS_FAILURE => ['icon' => '../resources/images/icons/Quetto/no-icon.png', 'text' => _("Some problem occurred during profile update")],
                Severity: Minor
                Found in web/admin/overview_org.php - About 1 day to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File Devices-template.php has 520 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a
                Severity: Major
                Found in devices/Devices-template.php - About 1 day to fix

                  Function prepareEapConfig has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function prepareEapConfig($attr)
    {
        $outerUser = '';
        $vistaExt = '';
        $w7Ext = '';
                  Severity: Minor
                  Found in devices/ms/DeviceVista7.php - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function signRequest($csr, $expiryDays): array
    {
        if (!($csr["CSR_OBJECT"] instanceof \OpenSSLCertificateSigningRequest)) {
            throw new Exception("This CA needs the CA as an OpenSSLCertificateSigningRequest object!");
        }
                  Severity: Major
                  Found in core/CertificationAuthorityEmbeddedRSA.php and 1 other location - About 1 day to fix
                  core/CertificationAuthorityEmbeddedECDSA.php on lines 180..206

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 252.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function signRequest($csr, $expiryDays): array
    {
        if (!($csr["CSR_OBJECT"] instanceof \OpenSSLCertificateSigningRequest)) {
            throw new Exception("This CA needs the CA as an OpenSSLCertificateSigningRequest object!");
        }
                  Severity: Major
                  Found in core/CertificationAuthorityEmbeddedECDSA.php and 1 other location - About 1 day to fix
                  core/CertificationAuthorityEmbeddedRSA.php on lines 180..206

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 252.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  File API.php has 507 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a
                  Severity: Major
                  Found in web/admin/API.php - About 1 day to fix

                    Function sanitiseInputs has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function sanitiseInputs(array $listOfEntries) {
        $retval = [];
        $bad = [];
        $multilangAttrsWithC = [];
        foreach ($listOfEntries as $objId => $objValueRaw) {
                    Severity: Minor
                    Found in web/lib/admin/OptionParser.php - About 1 day to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function marshalObject has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function marshalObject($domElement, $node, $name, $object, $namespace = NULL, $root = false)
    {
        if (is_null($object)) {
            return;
        }
                    Severity: Minor
                    Found in core/DeviceXMLmain.php - About 7 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method prepareEapConfig has 193 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function prepareEapConfig($attr)
    {
        $outerUser = '';
        $vistaExt = '';
        $w7Ext = '';
                    Severity: Major
                    Found in devices/ms/DeviceVista7.php - About 7 hrs to fix
                      Severity
                      Category
                      Status
                      Source
                      Language