Showing 599 of 599 total issues

File CAT.php has 489 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a 
Severity: Minor
Found in core/CAT.php - About 7 hrs to fix

    Method prepareEapConfig has 193 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function prepareEapConfig($attr)
        {
            $outerUser = '';
            $vistaExt = '';
            $w7Ext = '';
    Severity: Major
    Found in devices/ms/DeviceVista7.php - About 7 hrs to fix

      File diag_js.php has 483 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      /*
       * *****************************************************************************
       * Contributions to this work were made on behalf of the GÉANT project, a 
      Severity: Minor
      Found in web/skins/modern/diag/js/diag_js.php - About 7 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            <?php if ($deploymentObject->status == \core\AbstractDeployment::ACTIVE) { ?>
                                <form action='edit_hotspot.php?inst_id=<?php echo $my_inst->identifier; ?>&amp;deployment_id=<?php echo $deploymentObject->identifier; ?>' method='post' accept-charset='UTF-8'>
                                    <button class='delete' type='submit' style='cursor:pointer;' name='submitbutton' value='<?php echo web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php printf(_("Do you really want to deactivate the %s deployment?"), core\DeploymentManaged::PRODUCTNAME); ?>')">
                                        <?php echo _("Deactivate"); ?>
                                    </button>
        Severity: Major
        Found in web/admin/overview_sp.php and 1 other location - About 7 hrs to fix
        web/admin/overview_org.php on lines 400..471

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 235.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        <?php if ($deploymentObject->status == \core\AbstractDeployment::ACTIVE) { ?>
                            <form action='edit_hotspot.php?inst_id=<?php echo $deploymentObject->institution; ?>&amp;deployment_id=<?php echo $deploymentObject->identifier; ?>' method='post' accept-charset='UTF-8'>
                                <button class='delete' type='submit' style='cursor:pointer;' name='submitbutton' value='<?php echo web\lib\common\FormElements::BUTTON_DELETE; ?>' onclick="return confirm('<?php printf(_("Do you really want to deactivate the %s deployment?"), core\DeploymentManaged::PRODUCTNAME); ?>')">
                                    <?php echo _("Deactivate"); ?>
                                </button>
        Severity: Major
        Found in web/admin/overview_org.php and 1 other location - About 7 hrs to fix
        web/admin/overview_sp.php on lines 237..286

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 235.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File overview_federation.php has 475 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /*
         * *****************************************************************************
         * Contributions to this work were made on behalf of the GÉANT project, a 
         * project that has received funding from the European Union’s Framework 
        Severity: Minor
        Found in web/admin/overview_federation.php - About 7 hrs to fix

          Method htmlHeadCode has 179 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function htmlHeadCode() {
                  $cat = new \core\CAT();
                  \core\common\Entity::intoThePotatoes();
                  $retval = "
                  <link href='../external/OpenLayers/ol.css' rel='stylesheet' type='text/css'>
          Severity: Major
          Found in web/lib/admin/MapOpenLayers.php - About 7 hrs to fix

            Function scrub has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
            Open

                public function scrub($inputJson, $fedObject) {        
                    $optionInstance = \core\Options::instance();
                    $parameters = [];
                    $allPossibleAttribs = array_merge(API::ACTIONS[$inputJson['ACTION']]['REQ'], API::ACTIONS[$inputJson['ACTION']]['OPT'],  API::ACTIONS[$inputJson['ACTION']]['FLAG']);
                    // some actions don't need parameters. Don't get excited when there aren't any.
            Severity: Minor
            Found in web/lib/admin/API.php - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File DeviceXML.php has 454 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            /*
             * *****************************************************************************
             * Contributions to this work were made on behalf of the GÉANT project, a 
            Severity: Minor
            Found in devices/eap_config/DeviceXML.php - About 6 hrs to fix

              Method displayRadiusPropertyWidget has 172 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function displayRadiusPropertyWidget(&$theProfile, $readonly, &$uiElements, $editMode) {
                  ?>
                  <div style='padding-bottom:20px;'>
                      <?php $profile_name = $theProfile->name; ?>
                      <div style='margin-bottom:10px; display:block;'>
              Severity: Major
              Found in web/admin/overview_org.php - About 6 hrs to fix

                Function displayRadiusPropertyWidget has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                Open

                function displayRadiusPropertyWidget(&$theProfile, $readonly, &$uiElements, $editMode) {
                    ?>
                    <div style='padding-bottom:20px;'>
                        <?php $profile_name = $theProfile->name; ?>
                        <div style='margin-bottom:10px; display:block;'>
                Severity: Minor
                Found in web/admin/overview_org.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function collectCAPath has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function collectCAPath()
                    {
                        $capathtest = [];
                        $capathtest[] = '<p><strong>'._("Checking server handshake...")."</strong><p>";
                        $allfailed = TRUE;
                Severity: Minor
                Found in core/diag/RADIUSTestsUI.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File UIElements.php has 439 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                /*
                 * *****************************************************************************
                 * Contributions to this work were made on behalf of the GÉANT project, a 
                Severity: Minor
                Found in web/lib/admin/UIElements.php - About 6 hrs to fix

                  File DeviceConfig.php has 436 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  /*
                   * *****************************************************************************
                   * Contributions to this work were made on behalf of the GÉANT project, a 
                  Severity: Minor
                  Found in core/DeviceConfig.php - About 6 hrs to fix

                    File edit_profile.php has 431 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    /*
                     * *****************************************************************************
                     * Contributions to this work were made on behalf of the GÉANT project, a 
                     * project that has received funding from the European Union’s Framework 
                    Severity: Minor
                    Found in web/admin/edit_profile.php - About 6 hrs to fix

                      Method __construct has 157 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function __construct()
                          {
                              parent::__construct();
                              // initialise the DB
                              $handle = \core\DBConnection::handle("DIAGNOSTICS");
                      Severity: Major
                      Found in core/diag/AbstractTest.php - About 6 hrs to fix

                        Function writeInstaller has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function writeInstaller()
                            {
                                \core\common\Entity::intoThePotatoes();
                                $rootname = 'EAPIdentityProviderList';
                                $dom = new \DOMDocument('1.0', 'utf-8');
                        Severity: Minor
                        Found in devices/eap_config/DeviceXML.php - About 6 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public function writeDeviceInfo() {
                                \core\common\Entity::intoThePotatoes();
                                $out = sprintf(_("The installer is in the form of a Python script. It will try to configure %s under NetworkManager and if this is either not appropriate for your system or your version of NetworkManager is too old, a wpa_supplicant config file will be created instead."), \config\ConfAssistant::CONSORTIUM['display_name']);
                                $out .= "<p>"._("The installer will configure access to:")." <strong>";
                                $out .= implode('</strong>, <strong>', array_keys($this->attributes['internal:networks']));
                        Severity: Major
                        Found in devices/linux/DeviceLinux.php and 1 other location - About 6 hrs to fix
                        devices/linux/DeviceLinuxSh.php on lines 84..103

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 208.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public function writeDeviceInfo() {
                                \core\common\Entity::intoThePotatoes();
                                $out = sprintf(_("The installer is in the form of a Python script. It will try to configure %s under NetworkManager and if this is either not appropriate for your system or your version of NetworkManager is too old, a wpa_supplicant config file will be created instead."), \config\ConfAssistant::CONSORTIUM['display_name']);
                                $out .= "<p>"._("The installer will configure access to:")." <strong>";
                                $out .= implode('</strong>, <strong>', array_keys($this->attributes['internal:networks']));
                        Severity: Major
                        Found in devices/linux/DeviceLinuxSh.php and 1 other location - About 6 hrs to fix
                        devices/linux/DeviceLinux.php on lines 83..102

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 208.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        File Federation.php has 421 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        
                        /*
                         * *****************************************************************************
                         * Contributions to this work were made on behalf of the GÉANT project, a 
                        Severity: Minor
                        Found in core/Federation.php - About 6 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language