IBM-Swift/Kitura

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    static var allTests: [(String, (TestCodablePathParams) -> () throws -> Void)] {
        return [
            ("testJoinPath", testJoinPath),
            ("testRouteWithTrailingSlash", testRouteWithTrailingSlash),
            ("testInvalidRouteParameters", testInvalidRouteParameters),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        customRouter.put("/customCoder2") { (middleware: UserMiddleware, middleware2: UserMiddleware, id: Int, inDate: CodableDate, respondWith: (CodableDate?, RequestError?) -> Void) in
            print("PUT on /customCoder/\(id)")
            XCTAssertEqual(inDate, codableDate)
            respondWith(codableDate, nil)
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        customRouter.patch("/customCoder2") { (middleware: UserMiddleware, middleware2: UserMiddleware, id: Int, inDate: CodableDate, respondWith: (CodableDate?, RequestError?) -> Void) in
            print("PATCH on /customCoder/\(id)")
            XCTAssertEqual(inDate, codableDate)
            respondWith(codableDate, nil)
        }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    static var allTests: [(String, (TestRouteRegex) -> () throws -> Void)] {
        return [
            ("testBuildRegexFromPattern", testBuildRegexFromPattern),
            ("testSimplePaths", testSimplePaths),
            ("testSimpleMatches", testSimpleMatches),

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    static var allTests: [(String, (TestServerOptions) -> () throws -> Void)] {
        return [
            ("testSmallPostSucceeds", testSmallPostSucceeds),
            ("testLargePostExceedsLimit", testLargePostExceedsLimit),
            ("testRequestSizeLimitCustomResponse", testRequestSizeLimitCustomResponse),

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        delete(route) { request, response, next in
            Log.verbose("Received DELETE (plural with middleware) type-safe request")
            self.handleMiddleware(T1.self, T2.self, request: request, response: response) { typeSafeMiddleware1, typeSafeMiddleware2 in
                guard let typeSafeMiddleware1 = typeSafeMiddleware1, let typeSafeMiddleware2 = typeSafeMiddleware2 else {
                    return next()

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        get(route) { request, response, next in
            Log.verbose("Received GET(Array) with identifier typed middleware request")
            self.handleMiddleware(T1.self, T2.self, request: request, response: response) { typeSafeMiddleware1, typeSafeMiddleware2 in
                guard let typeSafeMiddleware1 = typeSafeMiddleware1, let typeSafeMiddleware2 = typeSafeMiddleware2 else {
                    return next()

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        get(route) { request, response, next in
            Log.verbose("Received GET(Single) typed middleware request")
            self.handleMiddleware(T1.self, T2.self, request: request, response: response) { typeSafeMiddleware1, typeSafeMiddleware2 in
                guard let typeSafeMiddleware1 = typeSafeMiddleware1, let typeSafeMiddleware2 = typeSafeMiddleware2 else {
                    return next()

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        get(route) { request, response, next in
            Log.verbose("Received GET(Array) typed middleware request")
            self.handleMiddleware(T1.self, T2.self, request: request, response: response) { typeSafeMiddleware1, typeSafeMiddleware2 in
                guard let typeSafeMiddleware1 = typeSafeMiddleware1, let typeSafeMiddleware2 = typeSafeMiddleware2 else {
                    return next()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        buildServerTest(router, timeout: 30)
            .request("delete", path: "/userMiddleware/1", headers: ["TestHeader": "Hello"])
            .hasStatus(.noContent)
            .hasNoData()
            .has { _ in XCTAssertNil(self.userStore[1]) }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        buildServerTest(router, timeout: 30)
            .request("delete", path: "/userMiddleware?id=1", headers: ["TestHeader": "Hello"])
            .hasStatus(.noContent)
            .hasNoData()
            .has { _ in XCTAssertNil(self.userStore[1]) }

• Read up
  Read up

Function testBasicGetSingle has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testBasicGetSingle() {
        router.get("/users") { (id: Int, respondWith: (User?, RequestError?) -> Void) in
            print("GET on /users/\(id)")
            guard let user = self.userStore[id] else {
                XCTFail("ERROR!!! Couldn't find user with id \(id)")

Function process has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func process(request: RouterRequest, response: RouterResponse, parameterWalker: RouterParameterWalker, next: @escaping () -> Void) {
        guard let path = request.parsedURLPath.path else {
            Log.error("Failed to process request (path is nil)")
            next()
            return

Function handle has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public func handle(request: ServerRequest, response: ServerResponse) {
        var decoder: (() -> BodyDecoder)?
        if let contentType = request.headers["Content-Type"]?[0], let mediaType = MediaType(contentTypeHeader: contentType) {
            decoder = decoders[mediaType]
        }

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        performServerTest(router, asyncTasks: { expectation in
            self.performRequest("get", path: "/test", callback: { response in
                XCTAssertEqual(response?.statusCode, .OK)

                do {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        performServerTest(router, asyncTasks: { expectation in
            self.performRequest("get", path: "/123/abc/456/def", callback: { response in
                XCTAssertEqual(response?.statusCode, .OK)

                do {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        performServerTest(router, asyncTasks: { expectation in
            self.performRequest("get", path: "", callback: { response in
                XCTAssertEqual(response?.statusCode, .OK)

                do {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        performServerTest(router, asyncTasks: { expectation in
            self.performRequest("get", path: "/helloworld", callback: { response in
                XCTAssertEqual(response?.statusCode, .OK)

                do {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        performServerTest(router, asyncTasks: { expectation in
            self.performRequest("get", path: "", callback: { response in
                XCTAssertEqual(response?.statusCode, .OK)

                do {

• Read up
  Read up

Function testCodableDeleteQueryParameters has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testCodableDeleteQueryParameters() {
        /// Currently the milliseconds are cut off by our date formatter
        /// This synchronizes it for testing with the codable route
        let date: Date = Coder.defaultDateFormatter.date(from: Coder.defaultDateFormatter.string(from: Date()))!