IBM-Swift/Kitura

Function update has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            update: function update(query) {
                var that = this, canceled = false, syncCalled = false, rendered = 0;
                this.cancel();
                this.cancel = function cancel() {
                    canceled = true;

Function testDataIsNotCorrupted has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testDataIsNotCorrupted() {
        // Corrupted files will have more bytes or less bytes than required
        // So we check the file is intact after reconstructing it (after various range requests)
        performServerTest(router) { expectation in
            self.performRequest("get", path: "/qwer/index.html", callback: { response in

Function update has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            update: function update(query) {
                var that = this, canceled = false, syncCalled = false, rendered = 0;
                this.cancel();
                this.cancel = function cancel() {
                    canceled = true;

Function performSimpleMatch has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private func performSimpleMatch(path: String, request: RouterRequest, response: RouterResponse, next: @escaping () -> Void) {
        guard let pattern = pattern else {
            next()
            return
        }

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    @discardableResult
    public func send(json: [Any]) -> RouterResponse {
        guard !state.invokedEnd else {
            Log.warning("RouterResponse send(json:) invoked after end() for \(self.request.urlURL)")
            return self

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    @discardableResult
    public func send(json: [String: Any]) -> RouterResponse {
        guard !state.invokedEnd else {
            Log.warning("RouterResponse send(json:) invoked after end() for \(self.request.urlURL)")
            return self

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        init<T: Encodable>(_ test: KituraTest, _ method: String, _ path: String, _ data: T, headers: [String:String]? = nil) {
            self.test = test
            self.invoker = { callback in
                let data = try JSONEncoder().encode(data)
                test.performRequest(method, path: path, callback: callback, headers: headers, requestModifier: { request in

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        init<T: Encodable>(_ test: KituraTest, _ method: String, _ path: String, _ data: T, headers: [String:String]? = nil, encoder: @escaping () -> BodyEncoder, mediaType: MediaType = .json) {
            self.test = test
            self.invoker = { callback in
                let data = try encoder().encode(data)
                test.performRequest(method, path: path, callback: callback, headers: headers, requestModifier: { request in

• Read up
  Read up

Function testConnectionRejectionCustomResponse has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testConnectionRejectionCustomResponse() {
        let numClients = 5  // Number of clients to connect
        let maxClients = 2  // Maximum number of concurrent clients

        // Create client status objects and expectations

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        buildServerTest(router, timeout: 30)
            .request("get", path: "/userMiddleware", headers: ["TestHeader": "Hello"])
            .hasStatus(.OK)
            .hasContentType(withPrefix: "application/json")
            .hasData(user)

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        buildServerTest(router, timeout: 30)
            .request("get", path: "/userMiddleware/1", headers: ["TestHeader": "Hello"])
            .hasStatus(.OK)
            .hasContentType(withPrefix: "application/json")
            .hasData(user)

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        buildServerTest(router, timeout: 30)
            .request("get", path: "/userMiddleware?id=2", headers: ["TestHeader": "Hello"])
            .hasStatus(.OK)
            .hasContentType(withPrefix: "application/json")
            .hasData(expectedArray)

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        buildServerTest(router, timeout: 30)
            .request("get", path: "/userMiddleware", headers: ["TestHeader": "Hello"])
            .hasStatus(.OK)
            .hasContentType(withPrefix: "application/json")
            .hasData(userArray)

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        buildServerTest(router, timeout: 30)
            .request("get", path: "/userMiddleware", headers: ["TestHeader": "Hello"])
            .hasStatus(.OK)
            .hasContentType(withPrefix: "application/json")
            .hasData(expectedIntData)

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        buildServerTest(router, timeout: 30)
            .request("get", path: "/userMiddleware?id=1", headers: ["TestHeader": "Hello"])
            .hasStatus(.OK)
            .hasContentType(withPrefix: "application/json")
            .hasData(user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public init(withCACertificateDirectory caCertificateDirPath: String?, usingCertificateFile certificateFilePath: String?, withKeyFile keyFilePath: String? = nil, usingSelfSignedCerts selfSigned: Bool = true, cipherSuite: String? = nil) {

        config = SSLService.Configuration(withCACertificateDirectory:caCertificateDirPath, usingCertificateFile: certificateFilePath, withKeyFile: keyFilePath, usingSelfSignedCerts: selfSigned, cipherSuite: cipherSuite)
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        performServerTest(customRouter) { expectation in
            self.performRequest("get", path: "/sendjson", callback: { response in
                if let response = response,
                   let responseJson = try? CodableDateAsTimeInterval(response: response) {
                    XCTAssertEqual(responseJson.date, 1519206456)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public init(withCACertificateFilePath caCertificateFilePath: String?, usingCertificateFile certificateFilePath: String?, withKeyFile keyFilePath: String? = nil, usingSelfSignedCerts selfSigned: Bool = true, cipherSuite: String? = nil) {

        config = SSLService.Configuration(withCACertificateFilePath: caCertificateFilePath, usingCertificateFile: certificateFilePath, withKeyFile:keyFilePath, usingSelfSignedCerts: selfSigned, cipherSuite: cipherSuite)
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        performServerTest(customRouter) { expectation in
            self.performRequest("get", path: "/rawget", callback: { response in
                if let response = response,
                   let responseJson = try? CodableDateAsTimeInterval(response: response) {
                    XCTAssertEqual(responseJson.date, 1519206456)

• Read up
  Read up

Function testHeaderModifiers has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testHeaderModifiers() {

        router.get("/headerTest") { _, response, next in

            response.headers.append("Content-Type", value: "text/html")