IBM-Swift/Kitura

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        router.put("/fruit/") { (id: Int, fruit: Fruit, respondWith: (Fruit?, RequestError?) -> Void) in
            respondWith(Fruit(name: fruit.name, id: id), nil)
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        router.patch("/fruit/") { (id: Int, fruit: Fruit, respondWith: (Fruit?, RequestError?) -> Void) in
            respondWith(Fruit(name: fruit.name, id: id), nil)
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    func testRenderWithExtensionAndWithoutDefaultTemplateEngine() {
        let router = Router()
        router.add(templateEngine: MockTemplateEngine())

        do {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    func testMissingExtensionCodable() {
        let router = Router()
        router.setDefault(templateEngine: MockTemplateEngine())
        
        do {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        router.post("/error/users") { (user: User, respondWith: (Int?, User?, RequestError?) -> Void) in
            print("POST on /error/users for user \(user)")
            respondWith(nil, nil, .conflict)
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    func testRender() {
        let router = Router()
        router.setDefault(templateEngine: MockTemplateEngine())

        do {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        router.post("/noBody") { (data: User, respondWith: (Int?, User?, RequestError?) -> Void) in
            print("POST on /noBody")
            respondWith(1, nil, .noContent)
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    func testEmptyTemplateNameCodable() {
        let router = Router()
        router.setDefault(templateEngine: MockTemplateEngine())
        
        do {

• Read up
  Read up

Function testExternSub has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testExternSub() {
        router.all("/extern", middleware: ExternSubrouter.getRouter())

        performServerTest(router, asyncTasks: { expectation in
            self.performRequest("get", path:"/extern", callback: {response in

Function testVerifyLinuxTestCount has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        func testVerifyLinuxTestCount() {
            verifyCount(MiscellaneousTests.self)
            verifyCount(TestBridgingHTTPStatusCode.self)
            verifyCount(TestBridgingRequestError.self)
            verifyCount(TestCodablePathParams.self)

Function testBasicDelete has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testBasicDelete() {
        router.delete("/users") { (respondWith: (RequestError?) -> Void) in
            print("DELETE on /users")
            self.userStore.removeAll()
            respondWith(nil)

Function testConnectionRejection has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testConnectionRejection() {
        let numClients = 5  // Number of clients to connect
        let maxClients = 2  // Maximum number of concurrent clients

        // Create client status objects and expectations

Function testMultipleMiddlewareDeleteOptionalParameters has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testMultipleMiddlewareDeleteOptionalParameters() {
        var userArray1 = [User(id: 1, name: "Andy"), User(id: 2, name: "Dave"), User(id: 3, name: "Ian")]
        var userArray2 = [User(id: 1, name: "Andy"), User(id: 2, name: "Dave"), User(id: 3, name: "Ian")]
        
        router.delete("/userMultiMiddleware") { (middleware: UserMiddleware, middleware2: UserMiddleware2, middleware3: UserMiddleware3, query: MyQuery?, respondWith: (RequestError?) -> Void) in

Function testRawDataPost has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testRawDataPost() {
        performServerTest(router) { expectation in
            self.performRequest("post",
                                path: "/bodytest",
                                callback: { response in

Function setupRouter has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static func setupRouter() -> Router {
        let router = Router()

        router.get("/1/(plus)+") {_, response, next in
            do {

Function getPart has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private func getPart(_ componentPart: Data) -> Part? {
        guard let found = componentPart.range(of: endHeaderData, in: 0 ..< componentPart.count) else {
            return nil
        }

Function buildRegex has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    internal func buildRegex(fromPattern: String?, allowPartialMatch: Bool = false) -> (NSRegularExpression?, Bool, [String]?) {
        guard let pattern = fromPattern else {
            return (nil, false, nil)
        }

Function constructTupleArrayOutResultHandler has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static func constructTupleArrayOutResultHandler<Id: Identifier, OutputType: Codable>(successStatus: HTTPStatusCode = .OK, response: RouterResponse, completion: @escaping () -> Void) -> IdentifierCodableArrayResultClosure<Id, OutputType> {
        return { codableOutput, error in
            var status = successStatus
            if let error = error {
                status = httpStatusCode(from: error)

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        router.get("/fruit") { (id: Int, respondWith: (Fruit?, RequestError?) -> Void) in
            print("GET on /fruit (implicit :id)")
            respondWith(Fruit(name: "banana", id: id), nil)
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        router.get("/fruit/:id") { (id: Int, respondWith: (Fruit?, RequestError?) -> Void) in
            print("GET on /fruit/:id")
            respondWith(Fruit(name: "banana", id: id), nil)
        }

• Read up
  Read up