Sign upLogin

ICIJ/prophecies

View on GitHub
Star

Showing 70 of 79 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        migrations.AlterField(
            model_name='task',
            name='template_setting',
            field=models.OneToOneField(blank=True, help_text='Each template type has its own set of settings (generated after template template is known)', null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='task', to='core.tasktemplatesetting'),
Severity: Major
Found in prophecies/core/migrations/0030_alter_task_template_setting_alter_taskrecord_status_and_more.py and 1 other location - About 1 hr to fix
prophecies/core/migrations/0029_auto_20240112_1220.py on lines 77..80

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  async getUser(cache = true) {
    if (!User.exists() || !cache) {
      await User.api().me()
    }
    return User.me()
Severity: Major
Found in prophecies/apps/frontend/src/core/Core.js and 1 other location - About 1 hr to fix
prophecies/apps/frontend/src/core/Core.js on lines 246..251

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  async getSettings(cache = true) {
    if (!Setting.exists() || !cache) {
      await Setting.api().get()
    }
    return Setting.allAsObject()
Severity: Major
Found in prophecies/apps/frontend/src/core/Core.js and 1 other location - About 1 hr to fix
prophecies/apps/frontend/src/core/Core.js on lines 232..237

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            hasNotes: {
              name: 'Notes',
              param: 'task_record__has_notes',
              label: 'name',
              field: 'value',
Severity: Major
Found in prophecies/apps/frontend/src/mixins/task-record-review-filters.js and 3 other locations - About 1 hr to fix
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 48..57
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 82..91
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 92..101

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            hasDisagreements: {
              name: 'Disagreements',
              param: 'task_record__has_disagreements',
              label: 'name',
              field: 'value',
Severity: Major
Found in prophecies/apps/frontend/src/mixins/task-record-review-filters.js and 3 other locations - About 1 hr to fix
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 48..57
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 92..101
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 102..111

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            hasAllRoundsReviewed: {
              name: 'All rounds reviewed',
              param: 'task_record__all_rounds_reviewed',
              field: 'value',
              label: 'name',
Severity: Major
Found in prophecies/apps/frontend/src/mixins/task-record-review-filters.js and 3 other locations - About 1 hr to fix
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 82..91
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 92..101
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 102..111

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            locked: {
              name: 'Locked',
              param: 'task_record__locked',
              label: 'name',
              field: 'value',
Severity: Major
Found in prophecies/apps/frontend/src/mixins/task-record-review-filters.js and 3 other locations - About 1 hr to fix
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 48..57
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 82..91
prophecies/apps/frontend/src/mixins/task-record-review-filters.js on lines 102..111

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def unpublish(self):
        self.visibility, _created = SettingVisibility.objects.get_or_create(
            setting=self
        )
        self.visibility.public = False
Severity: Major
Found in prophecies/core/models/setting.py and 1 other location - About 1 hr to fix
prophecies/core/models/setting.py on lines 82..87

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def publish(self):
        self.visibility, _created = SettingVisibility.objects.get_or_create(
            setting=self
        )
        self.visibility.public = True
Severity: Major
Found in prophecies/core/models/setting.py and 1 other location - About 1 hr to fix
prophecies/core/models/setting.py on lines 89..94

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def save_model(self, request, obj, form, change):
        if not obj.creator:
            obj.creator = request.user
        super().save_model(request, obj, form, change)
Severity: Major
Found in prophecies/core/admin/project_admin.py and 1 other location - About 1 hr to fix
prophecies/core/admin/tip_admin.py on lines 21..24

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def save_model(self, request, obj, form, change):
        if not obj.creator:
            obj.creator = request.user
        super().save_model(request, obj, form, change)
Severity: Major
Found in prophecies/core/admin/tip_admin.py and 1 other location - About 1 hr to fix
prophecies/core/admin/project_admin.py on lines 10..13

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        migrations.AddField(
            model_name='task',
            name='choice_group',
            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL,
Severity: Major
Found in prophecies/core/migrations/0001_initial.py and 2 other locations - About 1 hr to fix
prophecies/core/migrations/0023_alter_task_choice_group.py on lines 12..16
prophecies/core/migrations/0030_alter_task_template_setting_alter_taskrecord_status_and_more.py on lines 28..31

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        migrations.AlterField(
            model_name='tasktemplatesetting',
            name='polymorphic_ctype',
            field=models.ForeignKey(editable=False, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='polymorphic_%(app_label)s.%(class)s_set+', to='contenttypes.contenttype'),
Severity: Major
Found in prophecies/core/migrations/0030_alter_task_template_setting_alter_taskrecord_status_and_more.py and 2 other locations - About 1 hr to fix
prophecies/core/migrations/0001_initial.py on lines 107..110
prophecies/core/migrations/0023_alter_task_choice_group.py on lines 12..16

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    operations = [
        migrations.AlterField(
            model_name='task',
            name='choice_group',
            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.RESTRICT,
Severity: Major
Found in prophecies/core/migrations/0023_alter_task_choice_group.py and 2 other locations - About 1 hr to fix
prophecies/core/migrations/0001_initial.py on lines 107..110
prophecies/core/migrations/0030_alter_task_template_setting_alter_taskrecord_status_and_more.py on lines 28..31

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if page is not None:
            serializer = ActionSerializer(page, many=True, context={"request": request})
            return self.get_paginated_response(serializer.data)
Severity: Major
Found in prophecies/apps/api/views/task_record.py and 1 other location - About 1 hr to fix
prophecies/apps/api/views/user.py on lines 75..77

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if page is not None:
            serializer = ActionSerializer(page, many=True, context={'request': request})
            return self.get_paginated_response(serializer.data)
Severity: Major
Found in prophecies/apps/api/views/user.py and 1 other location - About 1 hr to fix
prophecies/apps/api/views/task_record.py on lines 175..177

Similar blocks of code found in 2 locations. Consider refactoring.
Open

@extend_schema_view(
    list=extend_schema(
        operation_id="List TaskRecordReviews",
        description="Returns a list of TaskRecordReviews.",
    ),
Severity: Major
Found in prophecies/apps/api/views/task_record_review.py and 1 other location - About 1 hr to fix
prophecies/apps/api/views/project.py on lines 25..34

Similar blocks of code found in 2 locations. Consider refactoring.
Open

@extend_schema_view(
    list=extend_schema(
        operation_id="List Projects",
        description="Returns a list of Projects.",
    ),
Severity: Major
Found in prophecies/apps/api/views/project.py and 1 other location - About 1 hr to fix
prophecies/apps/api/views/task_record_review.py on lines 180..189

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def filter_actor_params(self, actor):
        content_type = ContentType.objects.get_for_model(actor)
        id = actor.id
        return dict(actor_content_type=content_type, actor_object_id=id)
Severity: Major
Found in prophecies/core/managers.py and 2 other locations - About 1 hr to fix
prophecies/core/managers.py on lines 12..15
prophecies/core/managers.py on lines 17..20

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def filter_target_params(self, target):
        content_type = ContentType.objects.get_for_model(target)
        id = target.id
        return dict(target_content_type=content_type, target_object_id=id)
Severity: Major
Found in prophecies/core/managers.py and 2 other locations - About 1 hr to fix
prophecies/core/managers.py on lines 7..10
prophecies/core/managers.py on lines 17..20
Severity
Category
Status
Source
Language