Sign upLogin

ICIJ/prophecies

View on GitHub
Star

Showing 70 of 79 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def filter_action_object_params(self, action_object):
        content_type = ContentType.objects.get_for_model(action_object)
        id = action_object.id
        return dict(action_object_content_type=content_type, action_object_object_id=id)
Severity: Major
Found in prophecies/core/managers.py and 2 other locations - About 1 hr to fix
prophecies/core/managers.py on lines 7..10
prophecies/core/managers.py on lines 12..15

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      search(query, config = {}) {
        const params = { ...config.params, 'filter[search]': query }
        return this.get('', { ...config, params })
      }
Severity: Major
Found in prophecies/apps/frontend/src/models/Tip.js and 1 other location - About 1 hr to fix
prophecies/apps/frontend/src/models/TaskRecordReview.js on lines 43..46

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      search(query, config = {}) {
        const params = { ...config.params, 'filter[search]': query }
        return this.get('', { ...config, params })
      },
Severity: Major
Found in prophecies/apps/frontend/src/models/TaskRecordReview.js and 1 other location - About 1 hr to fix
prophecies/apps/frontend/src/models/Tip.js on lines 33..36

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if has_choice:
                action.send(
                    user,
                    verb="reviewed",
                    target=self.instance,
Severity: Major
Found in prophecies/apps/api/views/task_record_review.py and 2 other locations - About 1 hr to fix
prophecies/apps/api/views/task_record_review.py on lines 152..158
prophecies/apps/api/views/task_record_review.py on lines 160..166

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def save(self, *args, **kwargs):
        if not self.value:
            self.value = self.name
        super().save(*args, **kwargs)
Severity: Major
Found in prophecies/core/models/alternative_value.py and 1 other location - About 1 hr to fix
prophecies/core/models/choice.py on lines 24..27

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if "note" in self.validated_data:
            action.send(
                user,
                verb="commented",
                target=self.instance,
Severity: Major
Found in prophecies/apps/api/views/task_record_review.py and 2 other locations - About 1 hr to fix
prophecies/apps/api/views/task_record_review.py on lines 137..143
prophecies/apps/api/views/task_record_review.py on lines 152..158

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def save(self, *args, **kwargs):
        if not self.value:
            self.value = self.name
        super().save(*args, **kwargs)
Severity: Major
Found in prophecies/core/models/choice.py and 1 other location - About 1 hr to fix
prophecies/core/models/alternative_value.py on lines 13..16

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if self.validated_data.get("alternative_value", None):
            action.send(
                user,
                verb="selected",
                target=self.instance,
Severity: Major
Found in prophecies/apps/api/views/task_record_review.py and 2 other locations - About 1 hr to fix
prophecies/apps/api/views/task_record_review.py on lines 137..143
prophecies/apps/api/views/task_record_review.py on lines 160..166

Function __init__ has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def __init__(self, dict_or_list):
        if type(dict_or_list) == dict:
            for key, value in dict_or_list.items():
                if type(value) == dict:
                    setattr(self, key, ExtendedNamespace(value))
Severity: Minor
Found in prophecies/core/contrib/namespace.py - About 55 mins to fix

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        migrations.AlterField(
            model_name='task',
            name='embeddable_record_link_template',
            field=models.CharField(blank=True,
Severity: Major
Found in prophecies/core/migrations/0017_auto_20220113_1634.py and 2 other locations - About 45 mins to fix
prophecies/core/migrations/0016_auto_20220113_1625.py on lines 12..15
prophecies/core/migrations/0026_auto_20231220_1628.py on lines 30..33

Function filter_choice_queryset has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def filter_choice_queryset(
Severity: Minor
Found in prophecies/apps/api/views/task_record_review.py - About 45 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            migrations.AddField(
                model_name='task',
                name='embeddable_record_link_template',
                field=models.CharField(blank=True, help_text='An option link template to use within the link preview.',
    Severity: Major
    Found in prophecies/core/migrations/0016_auto_20220113_1625.py and 2 other locations - About 45 mins to fix
    prophecies/core/migrations/0017_auto_20220113_1634.py on lines 19..22
    prophecies/core/migrations/0026_auto_20231220_1628.py on lines 30..33

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {
              name: 'user-retrieve-bookmarks',
              path: 'bookmarks',
              component: UserRetrieveBookmarks,
              props: (route) => ({ query: route.query, username: route.params.username })
    Severity: Minor
    Found in prophecies/apps/frontend/src/router/index.js and 1 other location - About 40 mins to fix
    prophecies/apps/frontend/src/router/index.js on lines 49..54

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {
              name: 'user-retrieve-activity',
              path: 'activity',
              component: UserRetrieveActivity,
              props: (route) => ({ query: route.query, username: route.params.username })
    Severity: Minor
    Found in prophecies/apps/frontend/src/router/index.js and 1 other location - About 40 mins to fix
    prophecies/apps/frontend/src/router/index.js on lines 61..66

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                    ('tasktemplatesetting_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='core.tasktemplatesetting')),
    Severity: Major
    Found in prophecies/core/migrations/0029_auto_20240112_1220.py and 2 other locations - About 40 mins to fix
    prophecies/core/migrations/0029_auto_20240112_1220.py on lines 55..55
    prophecies/core/migrations/0029_auto_20240112_1220.py on lines 69..69

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                    ('tasktemplatesetting_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='core.tasktemplatesetting')),
    Severity: Major
    Found in prophecies/core/migrations/0029_auto_20240112_1220.py and 2 other locations - About 40 mins to fix
    prophecies/core/migrations/0029_auto_20240112_1220.py on lines 40..40
    prophecies/core/migrations/0029_auto_20240112_1220.py on lines 55..55

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                    ('tasktemplatesetting_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='core.tasktemplatesetting')),
    Severity: Major
    Found in prophecies/core/migrations/0029_auto_20240112_1220.py and 2 other locations - About 40 mins to fix
    prophecies/core/migrations/0029_auto_20240112_1220.py on lines 40..40
    prophecies/core/migrations/0029_auto_20240112_1220.py on lines 69..69

    Function map_provider_groups has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def map_provider_groups(strategy, details, user, *args, **kwargs):
    Severity: Minor
    Found in prophecies/core/oauth2_provider.py - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          {
            name: 'dashboard',
            path: '/',
            component: Dashboard,
            meta: {
      Severity: Minor
      Found in prophecies/apps/frontend/src/router/index.js and 1 other location - About 35 mins to fix
      prophecies/apps/frontend/src/router/index.js on lines 30..37

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          {
            name: 'login',
            path: '/login',
            component: Login,
            meta: {
      Severity: Minor
      Found in prophecies/apps/frontend/src/router/index.js and 1 other location - About 35 mins to fix
      prophecies/apps/frontend/src/router/index.js on lines 22..29
      Severity
      Category
      Status
      Source
      Language