Sign upLogin

ICIJ/prophecies

View on GitHub
Star

Showing 70 of 79 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        migrations.AddField(
            model_name='taskrecord',
            name='embeddable_link',
            field=models.CharField(blank=True,
Severity: Minor
Found in prophecies/core/migrations/0017_auto_20220113_1634.py and 1 other location - About 30 mins to fix
prophecies/core/migrations/0010_auto_20211001_0921.py on lines 13..16

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        migrations.AlterField(
            model_name='choice',
            name='shortkeys',
            field=models.CharField(blank=True, help_text='Comma separated list of shortkeys to pick this choice',
Severity: Minor
Found in prophecies/core/migrations/0010_auto_20211001_0921.py and 1 other location - About 30 mins to fix
prophecies/core/migrations/0017_auto_20220113_1634.py on lines 12..15

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        for key, (value, _) in CONSTANCE_CONFIG.items():
            # Avoid overriding existing keys from the db
            if not self.key_exists(key):
                settings.append(Setting(key=key, value=value))
Severity: Minor
Found in prophecies/core/models/setting.py and 1 other location - About 30 mins to fix
prophecies/core/models/setting.py on lines 25..27

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if not self.key_exists(key):
                # Finally, add the setting to the list
                settings.append(Setting(key=key, value=value))
Severity: Minor
Found in prophecies/core/models/setting.py and 1 other location - About 30 mins to fix
prophecies/core/models/setting.py on lines 33..36

Function notify_mentioned_users has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def notify_mentioned_users(author, users, action_object):
    for user in users:
        if author != user:
            action, created = get_or_create_mention_action(author, user, action_object)
            if created:
Severity: Minor
Found in prophecies/core/contrib/mentions.py - About 25 mins to fix

Function get_path has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def get_path(mixed, path, default=None):
    def get(d, key):
        if isinstance(d, dict):
            return d.get(key, default)
        elif isinstance(d, list):
Severity: Minor
Found in prophecies/core/contrib/namespace.py - About 25 mins to fix

Function signal_notify_mentioned_users has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def signal_notify_mentioned_users(sender, instance, **kwargs):  # pylint: disable=unused-argument
        for mention in instance.mentions:
            user = mention.get('user')
            if user is not None:
                act, created = get_or_create_mention_action(instance.creator, user, instance)
Severity: Minor
Found in prophecies/core/models/tip.py - About 25 mins to fix

Function clean has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def clean(self):
        super().clean()
        if self.is_valid():
            for object in self.task_record_reviews():
                object.check_user_is_authorized()
Severity: Minor
Found in prophecies/core/forms/task_record_assign_form.py - About 25 mins to fix

Function save has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def save(self):
        user = self.context.get("request").user
        if "choice" in self.validated_data:
            choice = self.validated_data.get("choice", None)
            has_choice = not choice is None
Severity: Minor
Found in prophecies/apps/api/views/task_record_review.py - About 25 mins to fix

Function signal_notify_mentioned_users has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def signal_notify_mentioned_users(sender, instance, **kwargs):  # pylint: disable=unused-argument
        for mention in instance.mentions:
            user = mention.get('user')
            if user is not None:
                action, created = get_or_create_mention_action(instance.checker, user, instance)
Severity: Minor
Found in prophecies/core/models/task_record_review.py - About 25 mins to fix
Severity
Category
Status
Source
Language