Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star

Showing 47,251 of 47,256 total issues

The parameter $rank_id is not named in camelCase.
Open

    public function getRank($rank_id = 0, $posts = 0) {
        $rank_id = (int) $rank_id;
        $posts = (int) $posts;

        $criteria = new icms_db_criteria_Compo();
Severity: Minor
Found in htdocs/modules/system/admin/userrank/class/userrank.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $op. Configured minimum length is 3.
Open

    global $icms_rating_handler, $icmsAdminTpl, $op, $changedField;
Severity: Minor
Found in htdocs/modules/system/admin/rating/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    $db =& icms_db_Factory::instance();
Severity: Minor
Found in htdocs/modules/system/admin/smilies/smilies.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $login_name is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $page_id is not named in camelCase.
Open

    public function changeStatus($page_id) {
        $page = $this->get($page_id);
        $page->setVar('page_status', !$page->getVar('page_status'));
        return $this->insert($page, TRUE);
    }
Severity: Minor
Found in htdocs/modules/system/admin/pages/class/pages.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $user_sig is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    $db = &icms_db_Factory::instance();
Severity: Minor
Found in htdocs/modules/system/admin/smilies/smilies.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $rank_id is not named in camelCase.
Open

function edituserrank($showmenu = FALSE, $rank_id = 0, $clone = FALSE) {
    global $icms_userrank_handler, $icmsAdminTpl, $rank_id;

    icms_cp_header();
    $userrankObj = $icms_userrank_handler->get($rank_id);
Severity: Minor
Found in htdocs/modules/system/admin/userrank/main.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $_rateOptions is not named in camelCase.
Open

class SystemRatingHandler extends icms_ipf_Handler {

    public $_rateOptions = array();
    public $_moduleList = FALSE;
    public $pluginsObject;
Severity: Minor
Found in htdocs/modules/system/admin/rating/class/rating.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

function SmilesEdit($id) {
Severity: Minor
Found in htdocs/modules/system/admin/smilies/smilies.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public function __construct($db) {
Severity: Minor
Found in htdocs/modules/system/admin/userrank/class/userrank.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $user_avatar is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $user_yim is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

function synchronize($id, $type) {
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $user_from is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $notify_mode is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    $db =& icms_db_Factory::instance();
Severity: Minor
Found in htdocs/modules/system/autotask.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $user_msnm is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $user_icq is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $user_intrest is not named in camelCase.
Open

function updateUser($uid, $uname, $login_name, $name, $url, $email, $user_icq, $user_aim, $user_yim,
                    $user_msnm, $user_from, $user_occ, $user_intrest, $user_viewemail, $user_avatar,
                    $user_sig, $attachsig, $theme, $pass, $pass2, $rank, $bio, $uorder, $umode, $notify_method,
                    $notify_mode, $timezone_offset, $user_mailok, $language,
                    $pass_expired, $groups = array()
Severity: Minor
Found in htdocs/modules/system/admin/users/users.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Severity
Category
Status
Source
Language