Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star

Showing 47,251 of 47,256 total issues

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    $id = (!is_null($imgcat_id) ? $imgcat_id : 0);
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $g_id is not named in camelCase.
Open

function modifyGroup($g_id) {
    $userstart = $memstart = 0;
    if (!empty($_POST['userstart'])) {
        $userstart = (int) $_POST['userstart'];
    } elseif (!empty($_GET['userstart'])) {
Severity: Minor
Found in htdocs/modules/system/admin/groups/groups.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $form_action is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if (!$this->isNew() && $this->getVar('block_type') != 'C') {
            $this->hideFieldFromForm('content');
            $this->hideFieldFromForm('c_type');
        }
Severity: Minor
Found in htdocs/modules/system/admin/blocksadmin/class/blocksadmin.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public function __construct(& $db) {
Severity: Minor
Found in htdocs/modules/system/admin/blockspadmin/class/blockspadmin.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

function editblockposition($id = 0) {
Severity: Minor
Found in htdocs/modules/system/admin/blockspadmin/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $imgcat_id is not named in camelCase.
Open

function showAddImgForm($imgcat_id) {
    global $target, $type;
    $imgcat_handler = icms::handler('icms_image_category');
    $form = new icms_form_Theme(_ADDIMAGE, 'image_form', 'browser.php', 'post', TRUE);
    $form->setExtra('enctype="multipart/form-data"');
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $imgcat_id is not named in camelCase.
Open

function imanager_index($imgcat_id = NULL) {
    global $icmsAdminTpl, $icmsConfig, $limit;

    if (!is_object(icms::$user)) {
        $groups = array(ICMS_GROUP_ANONYMOUS);
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    $id = (NULL !== $imgcat_id ? $imgcat_id : 0);
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $sc. Configured minimum length is 3.
Open

        $sc = 0;
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $imgcat_id is not named in camelCase.
Open

function imanager_listimg($imgcat_id, $start = 0) {
    global $icmsAdminTpl, $query, $limit;

    if (!is_object(icms::$user)) {
        $groups = array(ICMS_GROUP_ANONYMOUS);
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $id. Configured minimum length is 3.
Open

function adminNav($id = NULL, $separador = "/", $list = FALSE, $style = "style='font-weight:bold'") {
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $fh. Configured minimum length is 3.
Open

                if ($fh = @fopen($categ_path . '/index.html', 'w')) fwrite($fh, '<script>history.go(-1);</script>');
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $sc. Configured minimum length is 3.
Open

    $sc = 0;
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $imgcat_id is not named in camelCase.
Open

function imanager_editcat($imgcat_id) {
    if ($imgcat_id <= 0) {
        redirect_header('admin.php?fct=images', 1);
    }
    $imgcat_handler = icms::handler('icms_image_category');
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $imgcat_id is not named in camelCase.
Open

function redir($imgcat_id, $msg = NULL) {
    global $target, $type;

    redirect_header('browser.php?op=listimg&imgcat_id=' . (int) $imgcat_id . '&target=' . $target . '&type=' . $type, 2, $msg);
}
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $js. Configured minimum length is 3.
Open

    $js = 'var fname = document.getElementById("imgcat_foldername");';
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $fp. Configured minimum length is 3.
Open

                    $fp = @fopen($uploader->getSavedDestination(), 'rb');
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    $id = (NULL !== $imgcat_id ? $imgcat_id : 0);
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $imgcat_id is not named in camelCase.
Open

function imanager_delcatok($imgcat_id) {
    if (!icms::$security->check()) {
        redirect_header('admin.php?fct=images', 3, implode('<br />', icms::$security->getErrors()));
    }
Severity: Minor
Found in htdocs/modules/system/admin/images/main.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $fp. Configured minimum length is 3.
Open

        $fp = @fopen(ICMS_IMANAGER_FOLDER_PATH . '/' . $image->getVar('image_name'), 'rb');
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Severity
Category
Status
Source
Language