Sign upLogin

Kinvey/swift-sdk

View on GitHub
Star

Showing 2,011 of 2,013 total issues

Function testPerformance has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    func testPerformance() {
        do {
            weak var expectationInit = expectation(description: "Init")
            
            Kinvey.sharedClient.initialize(
Severity: Minor
Found in Kinvey/KinveyMacAppTests/PerformanceTest.swift - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetchAll has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    private func fetchAll(multiRequest: MultiRequest<ResultType>) -> Promise<AnyRandomAccessCollection<T>> {
        return Promise<AnyRandomAccessCollection<T>> { resolver in
            let request = client.networkRequestFactory.appData.buildAppDataFindByQuery(
                collectionName: try! T.collectionName(),
                query: query,
Severity: Minor
Found in Kinvey/Kinvey/FindOperation.swift - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MongoDBPredicateAdaptor.swift has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Foundation

#if canImport(MapKit)
    import MapKit
#endif
Severity: Minor
Found in Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift - About 5 hrs to fix

    Function presentMICViewController has 131 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        open class func presentMICViewController<U: User>(
        redirectURI: URL,
        micUserInterface: MICUserInterface = MICUserInterface.default,
        currentViewController: UIViewController? = nil,
        options: Options? = nil,
    Severity: Major
    Found in Kinvey/Kinvey/User.swift - About 5 hrs to fix

      Function transform has 123 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private func transform(expression: Expression, optimize: Bool = true) -> [String : Any]? {
        switch expression {
        case .equality(let lhs, let rhs):
            return transform(lhs: lhs, operator: .equalTo, rhs: rhs, optimize: optimize)
        case .inequality(let lhs, let rhs):
      Severity: Major
      Found in Kinvey/Kinvey/Query.swift - About 4 hrs to fix

        Function testPerformance has 122 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            func testPerformance() {
        do {
            weak var expectationInit = expectation(description: "Init")
            
            Kinvey.sharedClient.initialize(
        Severity: Major
        Found in Kinvey/KinveyMacAppTests/PerformanceTest.swift - About 4 hrs to fix

          Function upload has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

              fileprivate func upload<ResultType>(
        _ file: FileType,
        fromSource source: InputSource,
        skip: Int?,
        options: Options?,
          Severity: Minor
          Found in Kinvey/Kinvey/FileStore.swift - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function testPerformanceAutoPaginationEnabled has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

              func testPerformanceAutoPaginationEnabled() {
        do {
            weak var expectationInit = expectation(description: "Init")
            
            Kinvey.sharedClient.initialize(
          Severity: Minor
          Found in Kinvey/KinveyMacAppTests/PerformanceTest.swift - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function saveSingleRequest has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
          Open

              private func saveSingleRequest(newItems: AnyRandomAccessCollection<T>, requests: MultiRequest<ResultType>) -> Promise<ResultType> {
        let objectIds = newItems.map({ $0.entityId })
        let request = client.networkRequestFactory.appData.buildAppDataSave(
            newItems,
            options: options,
          Severity: Minor
          Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function testPerformanceAutoPaginationEnabled has 115 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              func testPerformanceAutoPaginationEnabled() {
        do {
            weak var expectationInit = expectation(description: "Init")
            
            Kinvey.sharedClient.initialize(
          Severity: Major
          Found in Kinvey/KinveyMacAppTests/PerformanceTest.swift - About 4 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            //
//  Query.swift
//  Kinvey
//
//  Created by Victor Barros on 2015-12-08.
            Severity: Major
            Found in Kinvey/Kinvey/Query.swift and 1 other location - About 4 hrs to fix
            Kinvey/Kinvey/Query.swift on lines 1..1229

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 286.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function downloadFileURL has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

                @discardableResult
    fileprivate func downloadFileURL(
        _ file: FileType,
        storeType: StoreType,
        downloadURL: URL,
            Severity: Minor
            Found in Kinvey/Kinvey/FileStore.swift - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for (sapCustomerNumber, expectedCount) in sapCustomerNumbers {
            weak var expectationFindLocal = expectation(description: "Find Local")
            weak var expectationFindNetwork = expectation(description: "Find Network")
            
            let query = Query(format: "sapCustomerNumber == %@", sapCustomerNumber)
            Severity: Major
            Found in Kinvey/KinveyMacAppTests/PerformanceTest.swift and 1 other location - About 4 hrs to fix
            Kinvey/KinveyMacAppTests/PerformanceTest.swift on lines 241..276

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 270.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for (sapCustomerNumber, expectedCount) in sapCustomerNumbers {
            weak var expectationFindLocal = expectation(description: "Find Local")
            weak var expectationFindNetwork = expectation(description: "Find Network")
            
            let query = Query(format: "sapCustomerNumber == %@", sapCustomerNumber)
            Severity: Major
            Found in Kinvey/KinveyMacAppTests/PerformanceTest.swift and 1 other location - About 4 hrs to fix
            Kinvey/KinveyMacAppTests/PerformanceTest.swift on lines 90..125

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 270.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File CustomEndpoint.swift has 339 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import Foundation
import PromiseKit

/// Class to interact with a custom endpoint in the backend.
open class CustomEndpoint {
            Severity: Minor
            Found in Kinvey/Kinvey/CustomEndpoint.swift - About 4 hrs to fix

              Function executeNetwork has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
              Open

                  func executeNetwork(_ completionHandler: CompletionHandler?) -> AnyRequest<ResultType> {
        guard client.activeUser != nil else {
            let result: Swift.Result<MultiSaveResultTuple<T>, Swift.Error> = .failure(Error.noActiveUser)
            completionHandler?(result)
            return AnyRequest(result)
              Severity: Minor
              Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function transform has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

                  private func transform(expression: Expression, optimize: Bool = true) -> [String : Any]? {
        switch expression {
        case .equality(let lhs, let rhs):
            return transform(lhs: lhs, operator: .equalTo, rhs: rhs, optimize: optimize)
        case .inequality(let lhs, let rhs):
              Severity: Minor
              Found in Kinvey/Kinvey/Query.swift - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function createBucket has 95 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  fileprivate func createBucket<ResultType>(
        _ file: FileType,
        fromSource source: InputSource,
        options: Options?,
        requests: MultiRequest<ResultType>
              Severity: Major
              Found in Kinvey/Kinvey/FileStore.swift - About 3 hrs to fix

                Function fetchDelta has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    private func fetchDelta(multiRequest: MultiRequest<ResultType>, sinceDate: Date) -> Promise<AnyRandomAccessCollection<T>> {
        return Promise<AnyRandomAccessCollection<T>> { resolver in
            let request = client.networkRequestFactory.appData.buildAppDataFindByQueryDeltaSet(
                collectionName: try! T.collectionName(),
                query: query,
                Severity: Minor
                Found in Kinvey/Kinvey/FindOperation.swift - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function testMICLoginSafariAuthenticationSession has 93 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    func testMICLoginSafariAuthenticationSession() {
        let app = XCUIApplication()
        let kid = "_kid_"
        let port: in_port_t = 8080
        app.launchEnvironment = [
                Severity: Major
                Found in Kinvey/KinveyAppUITests/KinveyAppUITests.swift - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language