Sign upLogin

Kinvey/swift-sdk

View on GitHub
Star

Showing 2,011 of 2,013 total issues

Function saveSingleRequest has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private func saveSingleRequest(newItems: AnyRandomAccessCollection<T>, requests: MultiRequest<ResultType>) -> Promise<ResultType> {
        let objectIds = newItems.map({ $0.entityId })
        let request = client.networkRequestFactory.appData.buildAppDataSave(
            newItems,
            options: options,
Severity: Major
Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 2 hrs to fix

    Function refreshToken has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        private func refreshToken(
        user: User,
        urlSession: URLSession,
        data: Data?,
        response: URLResponse?,
    Severity: Minor
    Found in Kinvey/Kinvey/HttpRequest.swift - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @discardableResult
    open class func resetPassword(
        usernameOrEmail: String,
        options: Options? = nil,
        completionHandler: ((Swift.Result<Void, Swift.Error>) -> Void)? = nil
    Severity: Major
    Found in Kinvey/Kinvey/User.swift and 2 other locations - About 2 hrs to fix
    Kinvey/Kinvey/User.swift on lines 472..490
    Kinvey/Kinvey/User.swift on lines 663..681

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @discardableResult
    open class func sendEmailConfirmation(
        forUsername username: String,
        options: Options? = nil,
        completionHandler: ((Swift.Result<Void, Swift.Error>) -> Void)? = nil
    Severity: Major
    Found in Kinvey/Kinvey/User.swift and 2 other locations - About 2 hrs to fix
    Kinvey/Kinvey/User.swift on lines 532..550
    Kinvey/Kinvey/User.swift on lines 663..681

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @discardableResult
    open class func forgotUsername(
        email: String,
        options: Options? = nil,
        completionHandler: ((Swift.Result<Void, Swift.Error>) -> Void)? = nil
    Severity: Major
    Found in Kinvey/Kinvey/User.swift and 2 other locations - About 2 hrs to fix
    Kinvey/Kinvey/User.swift on lines 472..490
    Kinvey/Kinvey/User.swift on lines 532..550

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function downloadFileURL has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @discardableResult
    fileprivate func downloadFileURL(
        _ file: FileType,
        storeType: StoreType,
        downloadURL: URL,
    Severity: Major
    Found in Kinvey/Kinvey/FileStore.swift - About 2 hrs to fix

      Function replaceAppDelegateMethods has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private func replaceAppDelegateMethods(
        options: Options?,
        completionHandler: ((Swift.Result<Bool, Swift.Error>) -> Void)?
    ) {
        func replaceAppDelegateMethods(_ completionHandler: ((Swift.Result<Bool, Swift.Error>) -> Void)?) {
      Severity: Minor
      Found in Kinvey/Kinvey/Push.swift - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File Metadata.swift has 266 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import Foundation
import Realm
import RealmSwift

/// This class represents the metadata information for a record
      Severity: Minor
      Found in Kinvey/Kinvey/Metadata.swift - About 2 hrs to fix

        Function executeNetwork has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            func executeNetwork(_ completionHandler: CompletionHandler?) -> AnyRequest<ResultType> {
        guard client.activeUser != nil else {
            let result: Swift.Result<MultiSaveResultTuple<T>, Swift.Error> = .failure(Error.noActiveUser)
            completionHandler?(result)
            return AnyRequest(result)
        Severity: Major
        Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 2 hrs to fix

          Function fetchAutoPagination has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private func fetchAutoPagination(multiRequest: MultiRequest<ResultType>, count: Int, requestStart: Date?) -> Promise<AnyRandomAccessCollection<T>> {
        return Promise<AnyRandomAccessCollection<T>> { resolver in
            let maxSizePerResultSet = options?.maxSizePerResultSet ?? MaxSizePerResultSet
            let nPages = Int64(ceil(Double(count) / Double(maxSizePerResultSet)))
            let progress = Progress(totalUnitCount: nPages + 1, parent: multiRequest.progress, pendingUnitCount: 99)
          Severity: Major
          Found in Kinvey/Kinvey/FindOperation.swift - About 2 hrs to fix

            Function group has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @discardableResult
    open func group<Avg: AddableType>(
        keys: [String],
        avg: String,
        avgType: Avg.Type? = nil,
            Severity: Major
            Found in Kinvey/Kinvey/DataStore.swift - About 2 hrs to fix

              Function group has 57 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  @discardableResult
    open func group<Max: MinMaxType>(
        keys: [String],
        max: String,
        maxType: Max.Type? = nil,
              Severity: Major
              Found in Kinvey/Kinvey/DataStore.swift - About 2 hrs to fix

                Function group has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @discardableResult
    open func group<Count: CountType>(
        count keys: [String],
        countType: Count.Type? = nil,
        condition: NSPredicate? = nil,
                Severity: Major
                Found in Kinvey/Kinvey/DataStore.swift - About 2 hrs to fix

                  Function group has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      @discardableResult
    open func group<Sum: AddableType>(
        keys: [String],
        sum: String,
        sumType: Sum.Type? = nil,
                  Severity: Major
                  Found in Kinvey/Kinvey/DataStore.swift - About 2 hrs to fix

                    Function group has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        @discardableResult
    open func group<Min: MinMaxType>(
        keys: [String],
        min: String,
        minType: Min.Type? = nil,
                    Severity: Major
                    Found in Kinvey/Kinvey/DataStore.swift - About 2 hrs to fix

                      Function fetchAll has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private func fetchAll(multiRequest: MultiRequest<ResultType>) -> Promise<AnyRandomAccessCollection<T>> {
        return Promise<AnyRandomAccessCollection<T>> { resolver in
            let request = client.networkRequestFactory.appData.buildAppDataFindByQuery(
                collectionName: try! T.collectionName(),
                query: query,
                      Severity: Major
                      Found in Kinvey/Kinvey/FindOperation.swift - About 2 hrs to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            @discardableResult
    open func upload(
        _ file: FileType,
        image: UIImage,
        imageRepresentation: ImageRepresentation = .png,
                        Severity: Major
                        Found in Kinvey/Kinvey/FileStore.swift and 1 other location - About 2 hrs to fix
                        Kinvey/Kinvey/FileStore.swift on lines 142..158

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 146.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            @discardableResult
    open func upload(
        _ file: FileType,
        image: NSImage,
        imageRepresentation: ImageRepresentation = .png,
                        Severity: Major
                        Found in Kinvey/Kinvey/FileStore.swift and 1 other location - About 2 hrs to fix
                        Kinvey/Kinvey/FileStore.swift on lines 202..218

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 146.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function login has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            @discardableResult
    open class func login<U: User>(
        authSource: AuthSource,
        _ authData: [String : Any],
        createIfNotExists: Bool = true,
                        Severity: Major
                        Found in Kinvey/Kinvey/User.swift - About 2 hrs to fix

                          Function save has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              func save(entities: AnyRandomAccessCollection<JsonDictionary>, syncQuery: SyncQuery?) {
        signpost(.begin, log: osLog, name: "Save Entities (JsonDictionary)")
        defer {
            signpost(.end, log: osLog, name: "Save Entities (JsonDictionary)")
        }
                          Severity: Major
                          Found in Kinvey/Kinvey/RealmDynamicCache.swift - About 2 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language