Sign upLogin

Kuangcp/JavaBase

View on GitHub
Star
gui/src/main/java/com/github/kuangcp/tank/domain/EnemyTank.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method finalShotAction has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void finalShotAction() {
        //判断坦克方向来 初始化子弹的起始发射位置
        final long nowMs = System.currentTimeMillis();
        if (lastShotMs != 0 && nowMs - lastShotMs < shotCDMs) {
            return;
Severity: Minor
Found in gui/src/main/java/com/github/kuangcp/tank/domain/EnemyTank.java - About 1 hr to fix

    Method finalMoveAction has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void finalMoveAction() {
        final boolean sameDirect = actionContext.getSameDirectCounter() > actionContext.getCurRoundStep();
        final boolean ablePassHero = PlayStageMgr.ablePassByHero(this);
        final boolean ablePassHinder = PlayStageMgr.ablePassByHinder(this);
    Severity: Minor
    Found in gui/src/main/java/com/github/kuangcp/tank/domain/EnemyTank.java - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  case DirectType.UP: {
                Bullet s = new Bullet(this.getX() - 1, this.getY() - 15, 0);
                bulletList.add(s);
                LoopEventExecutor.addLoopEvent(s);
                break;
      Severity: Minor
      Found in gui/src/main/java/com/github/kuangcp/tank/domain/EnemyTank.java and 1 other location - About 40 mins to fix
      gui/src/main/java/com/github/kuangcp/tank/domain/EnemyTank.java on lines 160..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  case DirectType.DOWN: {
                Bullet s = new Bullet(this.getX() - 2, this.getY() + 15, 1);
                bulletList.add(s);
                LoopEventExecutor.addLoopEvent(s);
                break;
      Severity: Minor
      Found in gui/src/main/java/com/github/kuangcp/tank/domain/EnemyTank.java and 1 other location - About 40 mins to fix
      gui/src/main/java/com/github/kuangcp/tank/domain/EnemyTank.java on lines 154..159

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status