Sign upLogin

RackHD/on-core

View on GitHub
Star

Showing 326 of 326 total issues

Function graphProgressFactory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function graphProgressFactory(
    Constants,
    _,
    assert
) {
Severity: Minor
Found in lib/common/graph-progress.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function UtilServiceFactory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function UtilServiceFactory(util, _) {
    function UtilService () {
    }

    _.forEach(_.methods(util), function(method) {
Severity: Minor
Found in lib/common/util.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function configurationServiceFactory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function configurationServiceFactory(
    Constants,
    assert,
    nconf,
    Promise,
Severity: Minor
Found in lib/services/configuration.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SubscriptionFactory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function SubscriptionFactory (Promise, Logger, assert) {
    var logger = Logger.initialize(SubscriptionFactory);

    /**
     * Creates a new subscription to a queue
Severity: Minor
Found in lib/common/subscription.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validatePatternsSkipped has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    JsonSchemaValidator.prototype.validatePatternsSkipped = function (schema, data, skipPatterns) {
        assert.equal(this.options.allErrors, true,
                  "option 'allErrors' need be enabled for validatePatternSkipped");
        assert.equal(this.options.verbose, true,
                 "option 'verbose' need be enabled for validatePatternSkipped");
Severity: Minor
Found in lib/common/json-schema-validator.js - About 1 hr to fix

    Function getTaskById has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        exports.getTaskById = function(data) {
        assert.object(data, 'data');
        assert.uuid(data.graphId, 'data.graphId');
        assert.uuid(data.taskId, 'data.taskId');
    Severity: Minor
    Found in lib/workflow/stores/mongo.js - About 1 hr to fix

      Function publishTaskProgress has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          GraphProgressService.prototype.publishTaskProgress = function(
        graphId,
        taskId,
        taskProgress,
        options
      Severity: Minor
      Found in lib/services/graph-progress.js - About 1 hr to fix

        Function start has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            HeartbeatService.prototype.start = function () {
        var self = this;
        if(this.intervalSec > 0) { // setting interval to 0 disables heartbeat
            return self.getFqdn().then(function(fqdn) {
                self.running = true;
        Severity: Minor
        Found in lib/services/heartbeat.js - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      toJSON: function() {
                // Remove waterline keys that we don't want in our dependency object
                var obj = this.toObject();
                delete obj.createdAt;
                delete obj.updatedAt;
          Severity: Major
          Found in lib/models/task-dependency.js and 2 other locations - About 1 hr to fix
          lib/models/graph-definition.js on lines 31..38
          lib/models/task-definition.js on lines 44..51

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  query.$or[0]['dependencies.'+data.taskId] = {
            $in: _.difference(Constants.Task.FinishedStates, [data.state])
        };
          Severity: Major
          Found in lib/workflow/stores/mongo.js and 1 other location - About 1 hr to fix
          lib/workflow/stores/mongo.js on lines 712..714

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      toJSON: function() {
                // Remove waterline keys that we don't want in our graph objects
                var obj = this.toObject();
                delete obj.createdAt;
                delete obj.updatedAt;
          Severity: Major
          Found in lib/models/graph-definition.js and 2 other locations - About 1 hr to fix
          lib/models/task-definition.js on lines 44..51
          lib/models/task-dependency.js on lines 65..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  query.$or[1]['dependencies.anyOf'+data.taskId] = {
            $in: _.difference(Constants.Task.FinishedStates, [data.state])
        };
          Severity: Major
          Found in lib/workflow/stores/mongo.js and 1 other location - About 1 hr to fix
          lib/workflow/stores/mongo.js on lines 709..711

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      toJSON: function() {
                // Remove waterline keys that we don't want in our graph objects
                var obj = this.toObject();
                delete obj.createdAt;
                delete obj.updatedAt;
          Severity: Major
          Found in lib/models/task-definition.js and 2 other locations - About 1 hr to fix
          lib/models/graph-definition.js on lines 31..38
          lib/models/task-dependency.js on lines 65..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function checkoutTimer has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              exports.checkoutTimer = function(leaseToken, criteria, leaseDuration) {
        var now = new Date();
        var query =  {
            $and: [
                criteria,
          Severity: Minor
          Found in lib/workflow/stores/mongo.js - About 1 hr to fix

            Function _updateCollection has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                var _updateCollection = function(templateServiceInstance, filepath, content, collectionName, filename, scope, hash){
        return waterline[collectionName].findOne({name: filename,
                path: filepath})
            .then(function(file) {
                if (file && file.scope !== scope) {
            Severity: Minor
            Found in lib/common/db-renderable-content.js - About 1 hr to fix

              Function setSucceeded has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      setSucceeded: function setSucceeded(leaseToken, alertMessage, workItems) {
            var self = this;
            var newState = "accessible";
            if (!Array.isArray(workItems)) {
                workItems = Array.prototype.slice.call(arguments, 2);
              Severity: Minor
              Found in lib/models/work-item.js - About 1 hr to fix

                Function load has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    DbRenderableContentService.prototype.load = function load() {
        var self = this;

        return self.loader.getAll(self.directory, true)
        .then(function(files) {
                Severity: Minor
                Found in lib/common/db-renderable-content.js - About 1 hr to fix

                  Function setFailed has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          setFailed: function setFailed(leaseToken, alertMessage, workItems) {
            var self = this;
            var newState = "inaccessible";
            if (!Array.isArray(workItems)) {
                workItems = Array.prototype.slice.call(arguments, 2);
                  Severity: Minor
                  Found in lib/models/work-item.js - About 1 hr to fix

                    Function load has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        ConfigurationService.prototype.load = function() {
        nconf.use('memory');

        // TODO: Move the remaining code to start once deprecation warnings are fixed.
                    Severity: Minor
                    Found in lib/services/configuration.js - About 1 hr to fix

                      Function WaterlineServiceFactory has 8 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          Promise,
    configuration,
    assert,
    Waterline,
    MongoAdapter,
                      Severity: Major
                      Found in lib/services/waterline.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language