Sign upLogin

RackHD/on-core

View on GitHub
Star

Showing 326 of 326 total issues

Function loggerFactory has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    events,
    Constants,
    assert,
    _,
    util,
Severity: Major
Found in lib/common/logger.js - About 50 mins to fix

    Function taskProtocolFactory has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function taskProtocolFactory (Promise, assert, Constants, Errors, messenger, _, Result) {
    Severity: Major
    Found in lib/protocol/task.js - About 50 mins to fix

      Function dhcpProtocolFactory has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          Promise,
    Constants,
    messenger,
    assert,
    IpAddress,
      Severity: Major
      Found in lib/protocol/dhcp.js - About 50 mins to fix

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                    id: {
                type: 'string',
                uuidv4: true,
                primaryKey: true,
                unique: true,
        Severity: Major
        Found in lib/models/renderable.js and 4 other locations - About 50 mins to fix
        lib/models/catalog.js on lines 25..32
        lib/models/hooks.js on lines 20..27
        lib/models/sku.js on lines 36..43
        lib/models/tags.js on lines 37..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                    id: {
                type: 'string',
                uuidv4: true,
                primaryKey: true,
                unique: true,
        Severity: Major
        Found in lib/models/catalog.js and 4 other locations - About 50 mins to fix
        lib/models/hooks.js on lines 20..27
        lib/models/renderable.js on lines 14..21
        lib/models/sku.js on lines 36..43
        lib/models/tags.js on lines 37..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                    id: {
                type: 'string',
                uuidv4: true,
                primaryKey: true,
                unique: true,
        Severity: Major
        Found in lib/models/tags.js and 4 other locations - About 50 mins to fix
        lib/models/catalog.js on lines 25..32
        lib/models/hooks.js on lines 20..27
        lib/models/renderable.js on lines 14..21
        lib/models/sku.js on lines 36..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                    id: {
                type: 'string',
                uuidv4: true,
                primaryKey: true,
                unique: true,
        Severity: Major
        Found in lib/models/sku.js and 4 other locations - About 50 mins to fix
        lib/models/catalog.js on lines 25..32
        lib/models/hooks.js on lines 20..27
        lib/models/renderable.js on lines 14..21
        lib/models/tags.js on lines 37..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                    id: {
                type: 'string',
                uuidv4: true,
                primaryKey: true,
                unique: true,
        Severity: Major
        Found in lib/models/hooks.js and 4 other locations - About 50 mins to fix
        lib/models/catalog.js on lines 25..32
        lib/models/renderable.js on lines 14..21
        lib/models/sku.js on lines 36..43
        lib/models/tags.js on lines 37..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function statsdServiceFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            util,
    Promise,
    configuration,
    statsd,
    assert,
        Severity: Minor
        Found in lib/services/statsd.js - About 45 mins to fix

          Function mongoStoreFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function mongoStoreFactory(waterline, Promise, Constants, Errors, assert, _) {
          Severity: Minor
          Found in lib/workflow/stores/mongo.js - About 45 mins to fix

            Function arpCacheFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                Logger,
    Promise,
    assert,
    util,
    _,
            Severity: Minor
            Found in lib/common/arp.js - About 45 mins to fix

              Function heartbeatServiceFactory has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              function heartbeatServiceFactory(
    Promise,
    configuration,
    assert,
    Constants,
              Severity: Minor
              Found in lib/services/heartbeat.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function logPublisherFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function logPublisherFactory(Constants, events, LogEvent, Messenger, EventEmitter, util) {
              Severity: Minor
              Found in lib/services/log-publisher.js - About 45 mins to fix

                Function taskGraphRunnerProtocolFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    Promise,
    messenger,
    Constants,
    assert,
    _,
                Severity: Minor
                Found in lib/protocol/task-graph-runner.js - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  return taskGraphStore.updatePollerStatus(workItem.id, {
                    status: Constants.Task.States.Succeeded,
                    nextScheduled: nextScheduled,
                    lastFinished: now,
                    state: newState
                  Severity: Minor
                  Found in lib/models/work-item.js and 1 other location - About 40 mins to fix
                  lib/models/work-item.js on lines 158..163

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  return taskGraphStore.updatePollerStatus(workItem.id, {
                    status: Constants.Task.States.Failed,
                    nextScheduled: nextScheduled,
                    lastFinished: now,
                    state: newState
                  Severity: Minor
                  Found in lib/models/work-item.js and 1 other location - About 40 mins to fix
                  lib/models/work-item.js on lines 187..192

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Consider simplifying this complex logical expression.
                  Open

                        if(isFunction(obj) && (exists(obj.$provide) || exists(obj.$inject) || provide || injects)){
        var instance = Object.create(obj.prototype);
        return obj.apply(instance,arguments) || instance;
      }
                  Severity: Major
                  Found in lib/di.js - About 40 mins to fix

                    Function ErrorPublisherFactory has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        Constants,
    Promise,
    events,
    eventsProtocol,
    Logger
                    Severity: Minor
                    Found in lib/services/error-publisher.js - About 35 mins to fix

                      Function templateServiceFactory has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          Constants, 
    Promise, 
    _, 
    DbRenderable,
    Util )
                      Severity: Minor
                      Found in lib/common/template.js - About 35 mins to fix

                        Function ChildProcess has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            function ChildProcess (command, args, env, code, maxBuffer) {
                        Severity: Minor
                        Found in lib/common/child-process.js - About 35 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language