RackHD/on-http

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        {
            service: 'apc-obm-service',
            config: {
                host: {
                    default: 'localhost',

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

var templatesMetaGetByName = controller(function(req) {
    return templateApiService.templatesMetaGetByName(req.swagger.params.name.value,
        req.swagger.query.scope);
});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        return Promise.try(function () {
            if (!configuration.name || !_.isString(configuration.name)) {
                throw new Errors.BadRequestError('Graph name is missing or in wrong format');
            }
        })

• Read up
  Read up

Function onHttpContextFactory has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function onHttpContextFactory(di, directory) {
    di = di || _di;

    var core = onCore(di, directory),
        helper = core.helper;

Function listManagerEthernetInterfaces has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var listManagerEthernetInterfaces = controller(function(req, res) {
    var identifier = req.swagger.params.identifier.value;
    var options = redfish.makeOptions(req, res, identifier);

    return redfish.getVendorNameById(identifier)

Function taskApiServiceFactory has 10 arguments (exceeds 4 allowed). Consider refactoring.

Open

    taskProtocol,
    waterline,
    Errors,
    util,
    configuration,

Similar blocks of code found in 3 locations. Consider refactoring.

Open

var nodesGetCatalogSourceById = controller(function(req) {
    return nodes.getNodeCatalogSourceById(req.swagger.params.identifier.value,
                                          req.swagger.params.source.value);
});

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

var obmsPatchById = controller( function(req) {
    return obmsService.updateObmById(
        req.swagger.params.identifier.value, req.swagger.params.body.value);

});

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

var skusPatch = controller( function (req) {
    return   skuPack.patchSku(req.swagger.params.identifier.value, req.swagger.params.body.value);
});

• Read up
  Read up

Function createSubscription has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var createSubscription = controller(function(req, res) {
    var options = redfish.makeOptions(req, res);
    var event = req.swagger.params.payload.value;
    return redfish.validateSchema(event,
        'EventDestination.v1_1_1.json#/definitions/EventDestination'

Function ibmsPatchById has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var ibmsPatchById = controller( function(req) {
    var ibmId = req.swagger.params.identifier.value;
    var values = req.swagger.params.body.value;
    return waterline.ibms.needByIdentifier(ibmId)
        .then(function(oldIbm) {

Function skuChassisParamHandler has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var skuChassisParamHandler = function(context, value) {
    var injector = require('../../index.js').injector;
    var nodeServiceApi = injector.get('Http.Services.Api.Nodes');
    return nodeServiceApi.getAllNodes({
        or: [

Function _onMetadata has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    var _onMetadata = function(stream, query, filename, id, metadata) {
        var self = this;

        return self.createOrUpdateEntry({
            basename: query,

Function editNodeRelations has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    NodeApiService.prototype.editNodeRelations = function(id, body, handler) {
        var self = this;
        return waterline.nodes.needByIdentifier(id).bind({})
        .then(function(node) {
            this.parentNode = node;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if( Object.keys(_.omit(req.swagger.params.body.value, configureUsersAllows)).length !== 0 ) {
                throw new Errors.BadRequestError('Bad Request');
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            return Promise.props({
                id: user.id,
                username: user.username,
                role: user.role,
                privileges: self.aclMethod('_rolesParents', [user.role])

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            return Promise.props({
                id: user.id,
                username: user.username,
                role: user.role,
                privileges: self.aclMethod('_rolesParents', [user.role])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if( Object.keys(_.omit(req.swagger.params.body.value, configureSelfAllows)).length !== 0 ) {
                throw new Errors.BadRequestError('Bad Request');
            }

• Read up
  Read up

Function publishTaskProgress has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    NotificationApiService.prototype.publishTaskProgress = function(message) {
        var progressData;
        return Promise.try(function() {
            message.value = parseInt(message.value);
            message.maximum = parseInt(message.maximum);

Function updateObmById has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    ObmApiService.prototype.updateObmById = function(obmId, values) {
        return waterline.obms.needByIdentifier(obmId)
        .then(function(oldObm) {
            /* Get nodes that need to publish events */
            if (oldObm.node && !values.nodeId) {