RackHD/on-http

Function getLcLogService has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var getLcLogService = controller(function(req, res)  {
    var identifier = req.swagger.params.identifier.value;

    return redfish.getVendorNameById(identifier)
    .then(function(result){

Function listVolume has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var listVolume = controller(function(req, res)  {
    var identifier = req.swagger.params.identifier.value;
    var index = req.swagger.params.index.value;

    return redfish.getVendorNameById(identifier)

Function handleError has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    rest.handleError = function () {
        return function handleErrorMiddleware(err, req, res, next) {
            // TODO - implement custom error type serializers
            if (err instanceof Error || err instanceof ErrorEvent) {
                var message = err.message || http.STATUS_CODES[err.status] || 'Unspecified Error';

Identical blocks of code found in 5 locations. Consider refactoring.

Open

    return redfish.getVendorNameById(identifier)
    .catch(function() {return{};})
    .then(function(result) {
    if (result.vendor === 'Redfish') {
            return getRedfishDeviceResponse(identifier, req);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    Boot.schema = {
        id: 'Serializables.V1.Boot',
        type: 'object',
        properties: {
            profile: {

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

    return Promise.try(function() {
        return fs.readFileAsync(fromRoot + '/static/redfishMetadata.xml', 'utf8');
    })
    .then(function(fileContent) {
        return fileContent;

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

    return Promise.try(function() {
        if(identifier === reservedId) {
            return waterline.nodes.find({type: 'compute'});
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(result.vendor === 'Dell'){
            return wsman.getLog(node, options.type)
            .then(function(selData) {
                options.logEntries = selData;
                return redfish.render('wsman.1.0.0.logentrycollection.json',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var removeRole = controller({ success: 204 }, function (req) {
    var name = req.swagger.params.name.value;
    return accountService.removeRoleByName(name);
});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    Obm.schema = {
        id: 'Serializables.V1.Obm',
        type: 'object',
        properties: {
            service: {

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

    return redfish.getVendorNameById(identifier)
    .catch(function() {return{};})
    .then(function(result) {
    if (result.vendor === 'Redfish') {
            return getRedfishDeviceResponse(identifier, req);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(result.vendor === 'Dell'){
            return wsman.getLog(node, options.type)
            .then(function(lcData) {
                options.logEntries = lcData;
                return redfish.render('wsman.1.0.0.lclogentrycollection.json',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var removeUser = controller({success: 204}, function(req) {
    var name = req.swagger.params.name.value;
    return accountService.removeUserByName(name);
});

• Read up
  Read up

Identical blocks of code found in 5 locations. Consider refactoring.

Open

                    return Promise.props({
                        hostname: os.hostname(),
                        fqdn: dnsGetFQDN(),
                        services: services
                    })

• Read up
  Read up

Function workflowApiServiceFactory has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

    eventsProtocol,
    Logger,
    Errors,
    Promise,
    Constants,

Function NotificationApiServiceFactory has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

    eventsProtocol,
    Logger,
    waterline,
    Errors,
    Promise,

Function restFactory has 9 arguments (exceeds 4 allowed). Consider refactoring.

Open

    Serializable,
    Promise,
    _,
    assert,
    util,

Function rest has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function rest(callback, options) {
        assert.func(callback, 'callback function is required');
        assert.optionalObject(options, 'options should be an optional object');

        options = options || {};

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var listDCIMCoolingDefault = controller(function (req, res) {
    var identifier = req.swagger.params.identifier.value;
    return nodeApi.getNodeCatalogSourceById(identifier, req.url);
});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

module.exports = {
    pollersLibGet: pollersLibGet,
    pollersLibByIdGet: pollersLibByIdGet,
    pollersGet: pollersGet,
    pollersIdGet: pollersIdGet,

• Read up
  Read up