Sign upLogin

Risoluto/Risoluto-Core

View on GitHub
Star

Showing 128 of 128 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * ValidateTest4IsLeapYear
 *
 * Validate::IsLeapYear用テストケース
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/ValidateTest/ValidateTest4IsLeapYear.php and 1 other location - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/ValidateTest/ValidateTest4IsEmailAddr.php on lines 1..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function test_setAttribute_Empty1st()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php and 2 other locations - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 102..121
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 154..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function test_setAttribute_EmptyBoth()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php and 2 other locations - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 128..147
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 154..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function test_setAttribute_Empty2nd()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php and 2 other locations - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 102..121
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 128..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (isset( $target[ 'status' ] )) {
            // フォーマットチェック
            if (!preg_match( '/\d{1,}/', $target[ 'status' ] )) {
                // フォーマットにそぐわない場合はエラーにする
                $retval[ 'error' ][ 'msg' ][ ] = 'invalid_status';
Severity: Major
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php and 2 other locations - About 1 hr to fix
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 181..193
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 197..209

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (isset( $target[ 'groupno' ] )) {
            // フォーマットチェック
            if (!preg_match( '/\d{1,}/', $target[ 'groupno' ] )) {
                // フォーマットにそぐわない場合はエラーにする
                $retval[ 'error' ][ 'msg' ][ ] = 'invalid_groupno';
Severity: Major
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php and 2 other locations - About 1 hr to fix
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 197..209
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 295..307

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (isset( $target[ 'status' ] )) {
            // フォーマットチェック
            if (!preg_match( '/\d{1,}/', $target[ 'status' ] )) {
                // フォーマットにそぐわない場合はエラーにする
                $retval[ 'error' ][ 'msg' ][ ] = 'invalid_status';
Severity: Major
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php and 2 other locations - About 1 hr to fix
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 181..193
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 295..307

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function run( array $options )
    {
        // 引数がなければ使用方法を表示する
        if (empty( $options ) or ( count( $options ) > 1 )) {
            $this->usage();
Severity: Minor
Found in risoluto/cli/RisolutoCli/AuthManager.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run( array $options )
    {
        // 引数がなければ使用方法を表示する
        if (empty( $options ) or ( count( $options ) > 1 )) {
            $this->usage();
Severity: Minor
Found in risoluto/cli/RisolutoCli/AuthManager.php - About 1 hr to fix

Method test_ExecAndTransaction_ExecWithInTrans has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_ExecAndTransaction_ExecWithInTrans()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4ExecAndTransactions.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function delUser()
    {
        // 削除に必要な情報を順番に取得していく
        do {
            $option[ 'userid' ] = $this->readFromStdin( "Enter user id: " );
Severity: Major
Found in risoluto/cli/RisolutoCli/AuthManager.php and 1 other location - About 1 hr to fix
risoluto/cli/RisolutoCli/AuthManager.php on lines 330..348

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function delGroup()
    {
        // ユーザ登録に必要な情報を順番に取得していく
        do {
            $option[ 'groupid' ] = $this->readFromStdin( "Enter group id: " );
Severity: Major
Found in risoluto/cli/RisolutoCli/AuthManager.php and 1 other location - About 1 hr to fix
risoluto/cli/RisolutoCli/AuthManager.php on lines 299..317

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method test_genDay_Args1 has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args1()
    {
        $want = [
            '' => '',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method checkEnteredSelfData has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function checkEnteredSelfData( $target, $csrf_token, $no )
    {
        // 戻り値を初期化
        $retval = [ ];
        $retval[ 'entered' ] = [ ];
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php - About 1 hr to fix

Method test_genDay_Args2 has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args2()
    {
        $want = [
            '--' => '',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_Args4_January has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args4_January()
    {
        $want = [
            '--' => '--',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_Args3 has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args3()
    {
        $want = [
            '--' => '--',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_NoArgs has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_NoArgs()
    {
        $want = [
            '01' => '01',
            '02' => '02',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_Args4_June has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args4_June()
    {
        $want = [
            '--' => '--',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_DoQuery_WithSqlAndParam has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_DoQuery_WithSqlAndParam()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DoQuery.php - About 1 hr to fix
Severity
Category
Status
Source
Language