Sign upLogin

Risoluto/Risoluto-Core

View on GitHub
Star

Showing 128 of 128 total issues

Method test_genDay_Args4_November has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args4_November()
    {
        $want = [
            '--' => '--',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_Args4_June has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args4_June()
    {
        $want = [
            '--' => '--',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_NoArgs has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_NoArgs()
    {
        $want = [
            '01' => '01',
            '02' => '02',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_Args4_September has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args4_September()
    {
        $want = [
            '--' => '--',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_Args4_February_LY has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args4_February_LY()
    {
        $want = [
            '--' => '--',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Method test_genDay_Args4_February has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_genDay_Args4_February()
    {
        $want = [
            '--' => '--',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenDay.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function test_DisConnect_with_force()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php and 1 other location - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php on lines 146..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function test_DisConnect_without_force()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php and 1 other location - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php on lines 124..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method play has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function play()
    {
        // セッションをスタート
        $sess = new \Risoluto\Session();
        $sess->start();
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/Auth.php - About 1 hr to fix

Method play has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function play()
    {
        // セッションをスタート
        $sess = new \Risoluto\Session();
        $sess->start();
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/GroupMng/DelConfirm.php - About 1 hr to fix

Method test_GenHour_Args2 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_Args2()
    {
        $want = [
            '--' => '',
            '00' => '00',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method play has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function play()
    {
        // セッションをスタート
        $sess = new \Risoluto\Session();
        $sess->start();
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/SelfComplete.php - About 1 hr to fix

Method test_GenHour_Args3 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_Args3()
    {
        $want = [
            '--' => '--',
            '00' => '00',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method test_GenHour_Args4 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_Args4()
    {
        $want = [
            '--' => '--',
            '00' => '午前00',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method play has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function play()
    {
        // パラメタを取得し、空だった時はデフォルトの画面を取得する
        $params = $this->getParam();
        if (empty( $params ) or !preg_match( '/^[[:alnum:]_-].*$/', $params[ 0 ] )) {
Severity: Minor
Found in risoluto/apps/RisolutoApps/Pages/View.php - About 1 hr to fix

Method test_getIni_NoArgs has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getIni_NoArgs()
    {
        $want = [
            "SEQ" => [
                "default" => "RisolutoApps\\Pages\\View",
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/ConfTest/ConfTest4GetIni.php - About 1 hr to fix

Method test_GenHour_Args1 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_Args1()
    {
        $want = [
            '' => '',
            '00' => '00',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method modUser has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function modUser()
    {
        // 変更処理に必要な情報を順番に取得していく
        $option[ 'by_who' ] = 'Risoluto CLI - ' . RISOLUTOCLI_SELF;
Severity: Minor
Found in risoluto/cli/RisolutoCli/AuthManager.php - About 1 hr to fix

Method test_getAttribute_SERVER_VERSION has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_SERVER_VERSION()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_CLIENT_VERSION has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_CLIENT_VERSION()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix
Severity
Category
Status
Source
Language