Sign upLogin

Risoluto/Risoluto-Core

View on GitHub
Star

Showing 128 of 128 total issues

Method test_getAttribute_ALL has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_ALL()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_AUTOCOMMIT has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_AUTOCOMMIT()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_SERVER_INFO has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_SERVER_INFO()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_ORACLE_NULLS has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_ORACLE_NULLS()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_ERRMODE has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_ERRMODE()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_CASE has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_CASE()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_NoArgs has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_NoArgs()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_CONNECTION_STATUS has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_CONNECTION_STATUS()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_SERVER_VERSION has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_SERVER_VERSION()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_DEFAULT_FETCH_MODE has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_DEFAULT_FETCH_MODE()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method modUser has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function modUser()
    {
        // 変更処理に必要な情報を順番に取得していく
        $option[ 'by_who' ] = 'Risoluto CLI - ' . RISOLUTOCLI_SELF;
Severity: Minor
Found in risoluto/cli/RisolutoCli/AuthManager.php - About 1 hr to fix

Method test_getAttribute_DRIVER_NAME has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_DRIVER_NAME()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_PERSISTENT has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_PERSISTENT()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_CLIENT_VERSION has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_CLIENT_VERSION()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_STATEMENT_CLASS has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_STATEMENT_CLASS()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_GenHour_NoArgs has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_NoArgs()
    {
        $want = [
            '00' => '00',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method play has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function play()
    {
        // セッションをスタート
        $sess = new \Risoluto\Session();
        $sess->start();
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/UserMng/AddComplete.php - About 1 hr to fix

Function checkEnteredSelfData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function checkEnteredSelfData( $target, $csrf_token, $no )
    {
        // 戻り値を初期化
        $retval = [ ];
        $retval[ 'entered' ] = [ ];
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * Error
 *
 * エラー画面を実現するためのクラス
Severity: Minor
Found in risoluto/apps/RisolutoApps/Error.php and 1 other location - About 40 mins to fix
risoluto/apps/RisolutoApps/ServiceStop.php on lines 1..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * ServiceStop
 *
 * サービスストップ画面を実現するためのクラス
Severity: Minor
Found in risoluto/apps/RisolutoApps/ServiceStop.php and 1 other location - About 40 mins to fix
risoluto/apps/RisolutoApps/Error.php on lines 1..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language