Sign upLogin

SAREhub/EasyECA

View on GitHub
Star

Showing 47 of 50 total issues

Avoid using static access to class '\SAREhub\Client\Processor\Processors' in method '__construct'.
Open

        $this->router = Processors::router($routingFunction);
Severity: Minor
Found in src/SAREhub/EasyECA/Util/MulticastGroupsRouter.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Commons\Misc\ArrayHelper' in method 'groupRulesByEventType'.
Open

        return ArrayHelper::groupByKey($rules, "event");
Severity: Minor
Found in src/SAREhub/EasyECA/Event/DefaultEventTypeRuleGroupsSplittingStrategy.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\DI\Processor\ProcessorDefinitionHelper' in method 'wrapCallableFunction'.
Open

        return $function instanceof \Closure ? ProcessorDefinitionHelper::closureValue($function) : $function;
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/Processor/ReloadRuleGroup/ReloadRuleGroupProcessorDefinitions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\Processor\Processors' in method 'get'.
Open

        return Processors::split($this->eventTypeRulesSplittingStrategy, $this->addEventRuleGroup);
Severity: Minor
Found in src/SAREhub/EasyECA/Event/AddEventRuleGroupsProcessorProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$action'.
Open

    public function create(ActionDefinition $action): Processor
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Action/NopActionProcessorFactory.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/RuleHelper.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/SAREhub/EasyECA/Event/DefaultEventTypeRuleGroupsSplittingStrategy.php by phpcodesniffer
Severity
Category
Status
Source
Language