Sign upLogin

SAREhub/EasyECA

View on GitHub
Star

Showing 47 of 50 total issues

Missing class import via use statement (line '42', column '23').
Open

            throw new \InvalidArgumentException("ActionProcessorFactory to action: '$action' not found");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Action/ActionParser.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '32', column '23').
Open

            throw new \SAREhub\EasyECA\Rule\Asserter\RuleAssertException("Hoa assert exception occurred", 500, $e);
Severity: Minor
Found in src/SAREhub/EasyECA/Hoa/Rule/Asserter/HoaRuleAsserter.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '47', column '19').
Open

        throw new \InvalidArgumentException("RuleGroupDefinition data is invalid: $message");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/RuleGroupDefinitionFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '31', column '24').
Open

            throw  new \InvalidArgumentException("RuleDefinition data is invalid: empty condition");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/RuleDefinitionFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '42', column '23').
Open

            throw new \InvalidArgumentException("ActionProcessorFactory to action: '$action' not found");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Action/ActionParser.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '14', column '23').
Open

            throw new \InvalidArgumentException("ActionDefinition data is invalid: empty action");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Action/ActionDefinitionFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '47', column '19').
Open

        throw new \InvalidArgumentException("RuleGroupDefinition data is invalid: $message");
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/RuleGroupDefinitionFactory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '32', column '23').
Open

            throw new \SAREhub\EasyECA\Rule\Asserter\RuleAssertException("Hoa assert exception occurred", 500, $e);
Severity: Minor
Found in src/SAREhub/EasyECA/Hoa/Rule/Asserter/HoaRuleAsserter.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\SAREhub\Client\Processor\Processors' in method 'get'.
Open

        return Processors::split($this->eventTypeRulesSplittingStrategy, $this->addEventRuleGroup);
Severity: Minor
Found in src/SAREhub/EasyECA/Event/AddEventRuleGroupsProcessorProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\DI\Processor\ProcessorDefinitionHelper' in method 'actionTransformToRuleGroupEventRouter'.
Open

        return ProcessorDefinitionHelper::router($routingFunction, $routes);
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/Processor/ReloadRuleGroup/ReloadRuleGroupProcessorDefinitions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Commons\Misc\ArrayHelper' in method 'groupRulesByEventType'.
Open

        return ArrayHelper::groupByKey($rules, "event");
Severity: Minor
Found in src/SAREhub/EasyECA/Event/DefaultEventTypeRuleGroupsSplittingStrategy.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\EasyECA\Rule\Action\ActionDefinition' in method '__construct'.
Open

        $this->onFail = $onFail ?? ActionDefinition::createNopDefinition();
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Definition/RuleDefinition.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\DI\Processor\ProcessorDefinitionHelper' in method 'processor'.
Open

        return ProcessorDefinitionHelper::pipeline([
            static::actionTransformToRuleGroupEventRouter(),
            factory(ReconfigureRuleGroupProcessorProvider::class)
        ]);
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/Processor/ReloadRuleGroup/ReloadRuleGroupProcessorDefinitions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\Message\BasicMessage' in method 'splitRulesByEventType'.
Open

            $splits[] = BasicExchange::withIn(BasicMessage::withBody($definition));
Severity: Minor
Found in src/SAREhub/EasyECA/Event/DefaultEventTypeRuleGroupsSplittingStrategy.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\DI\Processor\ProcessorDefinitionHelper' in method 'eventTypeRoutingFunction'.
Open

        return ProcessorDefinitionHelper::closureValue(function (Exchange $exchange) {
            return EventHelper::extract($exchange->getIn())->getType();
        });
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/Processor/EventRules/EventRulesProcessorDefinitions.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\Processor\Processors' in method '__construct'.
Open

        $this->router = Processors::router($routingFunction);
Severity: Minor
Found in src/SAREhub/EasyECA/Util/MulticastGroupsRouter.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Client\Message\BasicExchange' in method 'splitRulesByEventType'.
Open

            $splits[] = BasicExchange::withIn(BasicMessage::withBody($definition));
Severity: Minor
Found in src/SAREhub/EasyECA/Event/DefaultEventTypeRuleGroupsSplittingStrategy.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$action'.
Open

    public function create(ActionDefinition $action): Processor
Severity: Minor
Found in src/SAREhub/EasyECA/Rule/Action/NopActionProcessorFactory.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\SAREhub\Client\Processor\Processors' in method 'add'.
Open

            $this->router->addRoute($routingKey, Processors::multicast());
Severity: Minor
Found in src/SAREhub/EasyECA/Util/MulticastGroupsRouter.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\SAREhub\Commons\Misc\EnvironmentHelper' in method 'get'.
Open

        $uri = EnvironmentHelper::getRequiredVar($this->requestUriEnvVar);
Severity: Minor
Found in src/SAREhub/EasyECA/DI/Rule/Loader/Http/EnvRulesGetRequestCommandProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language