Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star

Showing 1,375 of 1,375 total issues

Function addChildrenQueries has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private function addChildrenQueries($query, CategoryInterface $category, $excludedCategories = []): QueryInterface
    {
        $childrenCategories    = $this->getChildrenCategories($category, $excludedCategories);
        $childrenCategoriesIds = [];
Severity: Minor
Found in src/module-elasticsuite-virtual-category/Model/Rule.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if (array_key_exists('all', $reportData)) {
                $data['rows'][] = [
                    'c' => [
                        ['v' => __('All sessions')],
                        ['v' => (float) $reportData['all'] * 100.0],
Severity: Major
Found in src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php and 2 other locations - About 2 hrs to fix
src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php on lines 102..110
src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php on lines 112..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php
/**
 * DISCLAIMER
 *
 * Do not edit or add to this file if you wish to upgrade Smile ElasticSuite to newer
Severity: Major
Found in src/module-elasticsuite-core/Search/Request/Query/QueryFactory.php and 2 other locations - About 2 hrs to fix
src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Collection/ProviderFactory.php on lines 1..56
src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Functions/ProviderFactory.php on lines 1..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if (array_key_exists('searches', $reportData)) {
                $data['rows'][] = [
                    'c' => [
                        ['v' => __('With search')],
                        ['v' => (float) $reportData['searches'] * 100.0],
Severity: Major
Found in src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php and 2 other locations - About 2 hrs to fix
src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php on lines 92..100
src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php on lines 112..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if (array_key_exists('no_searches', $reportData)) {
                $data['rows'][] = [
                    'c' => [
                        ['v' => __('Without search')],
                        ['v' => (float) $reportData['no_searches'] * 100.0],
Severity: Major
Found in src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php and 2 other locations - About 2 hrs to fix
src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php on lines 92..100
src/module-elasticsuite-analytics/Block/Adminhtml/Search/Usage/Chart/ConversionRates.php on lines 102..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php
/**
 * DISCLAIMER
 *
 * Do not edit or add to this file if you wish to upgrade Smile ElasticSuite to newer
Severity: Major
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Collection/ProviderFactory.php and 2 other locations - About 2 hrs to fix
src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Functions/ProviderFactory.php on lines 1..56
src/module-elasticsuite-core/Search/Request/Query/QueryFactory.php on lines 1..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php
/**
 * DISCLAIMER
 *
 * Do not edit or add to this file if you wish to upgrade Smile ElasticSuite to newer
Severity: Major
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Functions/ProviderFactory.php and 2 other locations - About 2 hrs to fix
src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Collection/ProviderFactory.php on lines 1..56
src/module-elasticsuite-core/Search/Request/Query/QueryFactory.php on lines 1..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method 'observe' has a complexity of 9.
Open

        observe: function(target, options) {
Severity: Minor
Found in src/module-elasticsuite-core/view/base/web/js/MutationObserver.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Consider simplifying this complex logical expression.
Open

            if (!options.childList && !options.attributes && !options.characterData ||

                // 1.2
                options.attributeOldValue && !options.attributes ||
Severity: Critical
Found in src/module-elasticsuite-core/view/base/web/js/MutationObserver.js - About 2 hrs to fix

    Function json2html has 65 lines of code (exceeds 40 allowed). Consider refactoring.
    Open

      function json2html(json, options) {
    var html = '';
    if (typeof json === 'string') {
      // Escape tags and quotes
      json = json
    Severity: Major
    Found in src/module-elasticsuite-indices/view/adminhtml/web/js/jquery.json-viewer.js - About 2 hrs to fix

      Method _initElement has 65 lines of code (exceeds 40 allowed). Consider refactoring.
      Open

          protected function _initElement(
        \Magento\Config\Model\Config\Structure\Element\Field $field,
        \Magento\Framework\Data\Form\Element\Fieldset $fieldset,
        $path,
        $fieldPrefix = '',
      Severity: Major
      Found in src/module-elasticsuite-core/Block/Adminhtml/Search/Request/RelevanceConfig/Form.php - About 2 hrs to fix

        Method __construct has 16 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Context $context,
        Registry $registry,
        FormFactory             $formFactory,
        TimezoneInterface       $localeDate,
        CombineConditionFactory $combineConditionsFactory,
        Severity: Major
        Found in src/module-elasticsuite-virtual-category/Model/Rule.php - About 2 hrs to fix

          Function _refreshValue has 64 lines of code (exceeds 40 allowed). Consider refactoring.
          Open

                  _refreshValue: function () {
            var lastValPercent, valPercent, value, valueMin, valueMax,
                oRange = this.options.range,
                o = this.options,
                that = this,
          Severity: Major
          Found in src/module-elasticsuite-catalog/view/frontend/web/js/slider.js - About 1 hr to fix

            Function _drawColorBox has 63 lines of code (exceeds 40 allowed). Consider refactoring.
            Open

                    _drawColorBox(ctx, pt, i, rtlHelper, options) {
            const me = this;
            const labelColors = me.labelColors[i];
            const labelPointStyle = me.labelPointStyles[i];
            const {boxHeight, boxWidth} = options;
            Severity: Major
            Found in src/module-elasticsuite-core/view/adminhtml/web/js/lib/chart.js - About 1 hr to fix

              Function getSearchQuery has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getSearchQuery(ProductCondition $productCondition)
    {
        $query = null;

        $query = $this->getSpecialAttributesSearchQuery($productCondition);
              Severity: Minor
              Found in src/module-elasticsuite-catalog-rule/Model/Rule/Condition/Product/QueryBuilder.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function applyPostFilters has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function applyPostFilters(array $filters = [], array $indices = [])
    {
        $filtered = [];

        foreach ($indices as $index) {
              Severity: Minor
              Found in src/module-elasticsuite-indices/Model/Index/Collection.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function saveIndex has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function saveIndex($dimensions, \Traversable $documents)
    {
        foreach ($dimensions as $dimension) {
            $storeId   = $dimension->getValue();
              Severity: Minor
              Found in src/module-elasticsuite-core/Indexer/GenericIndexerHandler.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getLanguageStemmers has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function getLanguageStemmers(\DOMXPath $xpath, \DomNode $rootNode, $defaultStemmer = null)
    {
        $stemmers = [];

        $searchPath = sprintf("./%s", self::STEMMER_TYPE_NODE);
              Severity: Minor
              Found in src/module-elasticsuite-core/Index/Analysis/Config/Converter.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getItems has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getItems()
    {
        if ($this->items === null) {
            $this->items = [];
              Severity: Minor
              Found in src/module-elasticsuite-core/Model/Autocomplete/Terms/DataProvider.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function loadVariationByFallback has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function loadVariationByFallback(Product $parentProduct, array $attributes)
    {
        $variation = false;

        if ($this->isProductHasSwatch($parentProduct) && $parentProduct->getDocumentSource() !== null) {
              Severity: Minor
              Found in src/module-elasticsuite-swatches/Helper/Swatches.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language