Showing 446 of 446 total issues
Avoid too many return
statements within this function. Open
return super().post(request, *args, **kwargs)
Avoid too many return
statements within this function. Open
return gettext("result unknown")
Avoid too many return
statements within this function. Open
return obj.reference
Avoid too many return
statements within this function. Open
return self.error_page(_("It looks like the sides for this debate haven't yet been confirmed, "
Avoid too many return
statements within this function. Open
return "danger", "still-bad", 2
Avoid too many return
statements within this function. Open
return "<error displaying %s>" % model_name
Avoid too many return
statements within this function. Open
return obj.adjudicator.name + " (" + str(obj.score) + ")"
Avoid too many return
statements within this function. Open
return GraphPowerPairedWithAllocatedSidesDrawGenerator
Avoid too many return
statements within this function. Open
return None if omit_tournament else obj.name
Avoid too many return
statements within this function. Open
return SwapRandomWithAllocatedSidesDrawGenerator
Avoid too many return
statements within this function. Open
return SwapRandomDrawGenerator
Avoid too many return
statements within this function. Open
return obj.adjudicator.name
Avoid too many return
statements within this function. Open
return str(obj)
Avoid too many return
statements within this function. Open
return AustralsPowerPairedWithAllocatedSidesDrawGenerator
Avoid too many return
statements within this function. Open
return AustralsPowerPairedDrawGenerator
Similar blocks of code found in 4 locations. Consider refactoring. Open
class IntegerAnswer(Answer):
ANSWER_TYPE = int
answer = models.IntegerField(verbose_name=_("answer"))
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 50.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 4 locations. Consider refactoring. Open
class BooleanAnswer(Answer):
ANSWER_TYPE = bool
# Note: by convention, if no answer is chosen for a boolean answer, an
# instance of this object should not be created. This way, there is no need
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 50.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid too many return
statements within this function. Open
return redirect_round('availability-index', self.round.next)
Avoid too many return
statements within this function. Open
return gettext('Team %d') % (side + 1)
Avoid too many return
statements within this function. Open
return perm