Sign upLogin

TabbycatDebate/tabbycat

View on GitHub
Star

Showing 446 of 446 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

class StringAnswer(Answer):
    ANSWER_TYPE = str
    answer = models.TextField(verbose_name=_("answer"))

    class Meta(Answer.Meta):
Severity: Major
Found in tabbycat/adjfeedback/models.py and 3 other locations - About 30 mins to fix
tabbycat/adjfeedback/models.py on lines 49..59
tabbycat/adjfeedback/models.py on lines 62..69
tabbycat/adjfeedback/models.py on lines 72..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

                return redirect_tournament('tournament-public-index', t)
Severity: Major
Found in tabbycat/tournaments/mixins.py - About 30 mins to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    class FloatAnswer(Answer):
    ANSWER_TYPE = float

    answer = models.FloatField(verbose_name=_("answer"))
    Severity: Major
    Found in tabbycat/adjfeedback/models.py and 3 other locations - About 30 mins to fix
    tabbycat/adjfeedback/models.py on lines 49..59
    tabbycat/adjfeedback/models.py on lines 62..69
    tabbycat/adjfeedback/models.py on lines 82..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

                return None
    Severity: Major
    Found in tabbycat/adjallocation/allocation.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return cached_perm
      Severity: Major
      Found in tabbycat/users/permissions.py - About 30 mins to fix

        Function make_pairings has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def make_pairings(self, rooms, indices):
        """Creates the PolyPairing objects. Also flags pull-up rooms."""
        teams_in_room = [[None, None, None, None] for i in range(len(indices) // 4)]
        for t, r in indices:
            teams_in_room[r // 4][r % 4] = self.teams[t]
        Severity: Minor
        Found in tabbycat/draw/generator/bphungarian.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function assignment_cost has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def assignment_cost(self, t1, t2, size, bracket=None):
        penalty = super().assignment_cost(t1, t2, size)
        if penalty is None:
            return None
        Severity: Minor
        Found in tabbycat/draw/generator/powerpair.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def __init__(self, view=None, **kwargs):
        """Constructor.
        - If `tournament` is specified, it becomes the default tournament for
          the builder.
        - If `admin` is True (default is False), then relevant links will go
        Severity: Minor
        Found in tabbycat/utils/tables.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _collate_elim_motion_annotations has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def _collate_elim_motion_annotations(self):
        """Collect annotations (which will be attributes) and convert them to
        dictionaries to allow for easy iteration in the template."""

        for motion in self.elim_motions_dict.values():
        Severity: Minor
        Found in tabbycat/motions/statistics.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _pullup has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def _pullup(self, brackets, pos):
        """'brackets' is what is returned by _make_raw_brackets().
        'pos' is a function taking the number of teams to choose from,
        and returning an index for which team to take as the pullup.
        Operates in-place. Does not remove empty brackets."""
        Severity: Minor
        Found in tabbycat/draw/generator/powerpair.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_result_display has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def get_result_display(self):
        if self.team.tournament.pref('teams_in_debate') == 4:
            if self.points is not None:
                return gettext("placed %(place)s") % {'place': ordinal(4 - self.points)}
            else:
        Severity: Minor
        Found in tabbycat/draw/models.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_table has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def get_table(cls, view, participant):
        """On team record pages, the table is the results table."""

        table = TeamResultTableBuilder(view=view, title=view.table_title, sort_key="round")
        Severity: Minor
        Found in tabbycat/participants/tables.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function add_debate_side_history_columns has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def add_debate_side_history_columns(self, debates, round):
        # Teams should be prefetched in debates, so don't use a new Team queryset to collate teams

        def get_team_or_none(debate: 'Debate', side: int) -> Optional['Team']:
            try:
        Severity: Minor
        Found in tabbycat/draw/tables.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function side_and_position_names has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

        def side_and_position_names(tournament):
    """Yields 2-tuples (side, positions), where position is a list of position
    names, all being translated human-readable names. This should eventually
    be extended to return an appropriate list for the tournament configuration.
    """
        Severity: Minor
        Found in tabbycat/results/utils.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function import_motions has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def import_motions(self):
        # Can cause data consistency problems if motions are re-used between rounds: See #645
        self.motions = {}

        motions_by_round = {}
        Severity: Minor
        Found in tabbycat/importer/archive.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_context_data has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def get_context_data(self, **kwargs):
        t = self.tournament
        updates = 10 # Number of items to fetch

        kwargs["round"] = t.current_round
        Severity: Minor
        Found in tabbycat/tournaments/views.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _fetch_conflicts_from_db has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def _fetch_conflicts_from_db(self):
        """Fetches relevant conflicts from the database, based on `self.teams`
        and `self.adjudicators`."""

        # Refresh `self.adjudicator_ids` and `self.team_ids`
        Severity: Minor
        Found in tabbycat/adjallocation/conflicts.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function form_valid has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def form_valid(self, form: TestEmailForm) -> 'HttpResponseRedirect':
        host = self.request.get_host()

        try:
            recipient = form.send_email(host)
        Severity: Minor
        Found in tabbycat/notifications/views.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_queryset has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def get_queryset(self):
        qs = super().get_queryset().prefetch_related(Prefetch('team__debateteam_set', queryset=DebateTeam.objects.all().select_related('debate__round__tournament')))
        data = {s.id: s for s in qs.all()}

        speaker_scores = SpeakerScore.objects.select_related('speaker', 'ballot_submission',
        Severity: Minor
        Found in tabbycat/api/views.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setUp has a Cognitive Complexity of 9 (exceeds 8 allowed). Consider refactoring.
        Open

            def setUp(self):
        super().setUp()
        # add test models
        self.tournament = Tournament.objects.create(slug="tournament")
        for i in range(4):
        Severity: Minor
        Found in tabbycat/utils/tests.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language