Sign upLogin

Talentica/AndroidWithKotlin

View on GitHub
Star

Showing 83 of 83 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (event.sensor.type == Sensor.TYPE_MAGNETIC_FIELD) {
                // mGeomagnetic = event.values;
                mGeomagnetic[0] = alpha * mGeomagnetic[0] + (1 - alpha) * event.values[0]
                mGeomagnetic[1] = alpha * mGeomagnetic[1] + (1 - alpha) * event.values[1]
                mGeomagnetic[2] = alpha * mGeomagnetic[2] + (1 - alpha) * event.values[2]
Severity: Major
Found in sensors/src/main/java/com/talentica/androidkotlin/sensors/Compass.kt and 1 other location - About 3 hrs to fix
sensors/src/main/java/com/talentica/androidkotlin/sensors/Compass.kt on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 248.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (event.sensor.type == Sensor.TYPE_ACCELEROMETER) {
                mGravity[0] = alpha * mGravity[0] + (1 - alpha) * event.values[0]
                mGravity[1] = alpha * mGravity[1] + (1 - alpha) * event.values[1]
                mGravity[2] = alpha * mGravity[2] + (1 - alpha) * event.values[2]
                // mGravity = event.values;
Severity: Major
Found in sensors/src/main/java/com/talentica/androidkotlin/sensors/Compass.kt and 1 other location - About 3 hrs to fix
sensors/src/main/java/com/talentica/androidkotlin/sensors/Compass.kt on lines 56..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 248.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method setProductList has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
Open

    fun setProductList(productList: List<ProductEntity?>?) {
        if (mProductList == null) {
            mProductList = productList
            if (productList != null) {
                notifyItemRangeInserted(0, productList.size)
Severity: Minor
Found in app/src/main/java/com/talentica/androidkotlin/ui/ProductAdapter.kt - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setCommentList has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
Open

    fun setCommentList(comments: List<CommentEntity?>?) {
        if (mCommentList == null) {
            mCommentList = comments
            if (comments != null) {
                notifyItemRangeInserted(0, comments.size)
Severity: Minor
Found in app/src/main/java/com/talentica/androidkotlin/ui/CommentAdapter.kt - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    override fun onCreateView(
        inflater: LayoutInflater, container: ViewGroup?,
        savedInstanceState: Bundle?
    ): View? {
        mBinding = DataBindingUtil.inflate(inflater, R.layout.list_fragment, container, false)
Severity: Major
Found in app/src/main/java/com/talentica/androidkotlin/ProductListFragment.kt and 1 other location - About 2 hrs to fix
app/src/main/java/com/talentica/androidkotlin/ProductFragment.kt on lines 34..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 164.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    override fun onCreateView(
        inflater: LayoutInflater, container: ViewGroup?,
        savedInstanceState: Bundle?
    ): View? {
        // Inflate this data binding layout
Severity: Major
Found in app/src/main/java/com/talentica/androidkotlin/ProductFragment.kt and 1 other location - About 2 hrs to fix
app/src/main/java/com/talentica/androidkotlin/ProductListFragment.kt on lines 35..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 164.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Class CameraAdapter has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class CameraAdapter constructor() : Camera.PictureCallback {

    companion object {
        private val ROTATION_DEGREE = 90
        private val MIN_AUTO_FOCUS_COUNT = 1
Severity: Minor
Found in customcamera/src/main/java/com/talentica/androidkotlin/customcamera/model/camera/CameraAdapter.kt - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    override fun areItemsTheSame(oldItemPosition: Int, newItemPosition: Int): Boolean {
                    val old = mCommentList!![oldItemPosition]
                    val comment = comments?.get(newItemPosition)
                    return if (old != null && comment != null) {
                        old.id == comment.id
    Severity: Major
    Found in app/src/main/java/com/talentica/androidkotlin/ui/CommentAdapter.kt and 1 other location - About 2 hrs to fix
    app/src/main/java/com/talentica/androidkotlin/ui/ProductAdapter.kt on lines 47..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 150.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    override fun areItemsTheSame(oldItemPosition: Int, newItemPosition: Int): Boolean {
                    val old = mProductList!![oldItemPosition]
                    val new = productList?.get(newItemPosition)
                    return if (old != null && new != null) {
                        old.id == new.id
    Severity: Major
    Found in app/src/main/java/com/talentica/androidkotlin/ui/ProductAdapter.kt and 1 other location - About 2 hrs to fix
    app/src/main/java/com/talentica/androidkotlin/ui/CommentAdapter.kt on lines 47..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 150.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): CommentViewHolder {
        val binding: CommentItemBinding = DataBindingUtil
            .inflate(
                LayoutInflater.from(parent.context), R.layout.comment_item,
                parent, false
    Severity: Major
    Found in app/src/main/java/com/talentica/androidkotlin/ui/CommentAdapter.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/talentica/androidkotlin/ui/ProductAdapter.kt on lines 77..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 146.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ProductViewHolder {
        val binding: ProductItemBinding = DataBindingUtil
            .inflate(
                LayoutInflater.from(parent.context), R.layout.product_item,
                parent, false
    Severity: Major
    Found in app/src/main/java/com/talentica/androidkotlin/ui/ProductAdapter.kt and 1 other location - About 1 hr to fix
    app/src/main/java/com/talentica/androidkotlin/ui/CommentAdapter.kt on lines 75..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 146.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method addUserObservers has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private fun addUserObservers() {
        // Manage the response from the server to "Search", turn the JsonObject into a User,
        // if the response is "ok"
        mUserObservable
                .observeOn(AndroidSchedulers.mainThread())
    Severity: Minor
    Found in sqlitedatabase/src/main/java/com/talentica/androidkotlin/sqlitedatabase/ui/SearchActivity.kt - About 1 hr to fix

      Method setProductList has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          fun setProductList(productList: List<ProductEntity?>?) {
        if (mProductList == null) {
            mProductList = productList
            if (productList != null) {
                notifyItemRangeInserted(0, productList.size)
      Severity: Minor
      Found in app/src/main/java/com/talentica/androidkotlin/ui/ProductAdapter.kt - About 1 hr to fix

        Method setCommentList has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            fun setCommentList(comments: List<CommentEntity?>?) {
        if (mCommentList == null) {
            mCommentList = comments
            if (comments != null) {
                notifyItemRangeInserted(0, comments.size)
        Severity: Minor
        Found in app/src/main/java/com/talentica/androidkotlin/ui/CommentAdapter.kt - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  observableProduct = databaseCreator?.let {
            Transformations.switchMap(
                it.isDatabaseCreated
            ) { isDbCreated ->
                if (!isDbCreated!!) {
          Severity: Major
          Found in app/src/main/java/com/talentica/androidkotlin/viewmodel/ProductViewModel.kt and 1 other location - About 1 hr to fix
          app/src/main/java/com/talentica/androidkotlin/viewmodel/ProductViewModel.kt on lines 72..82

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  comments = databaseCreator?.let {
            Transformations.switchMap(
                it.isDatabaseCreated
            ) { isDbCreated ->
                if (!isDbCreated!!) {
          Severity: Major
          Found in app/src/main/java/com/talentica/androidkotlin/viewmodel/ProductViewModel.kt and 1 other location - About 1 hr to fix
          app/src/main/java/com/talentica/androidkotlin/viewmodel/ProductViewModel.kt on lines 83..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  model.comments?.observe(viewLifecycleOwner, { commentEntities ->
            if (commentEntities != null) {
                mBinding.isLoading = false
                mCommentAdapter!!.setCommentList(commentEntities)
            } else {
          Severity: Major
          Found in app/src/main/java/com/talentica/androidkotlin/ProductFragment.kt and 1 other location - About 1 hr to fix
          app/src/main/java/com/talentica/androidkotlin/ProductListFragment.kt on lines 55..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 117.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  viewModel.products?.observe(viewLifecycleOwner, { myProducts ->
            if (myProducts != null) {
                mBinding.isLoading = false
                mProductAdapter!!.setProductList(myProducts)
            } else {
          Severity: Major
          Found in app/src/main/java/com/talentica/androidkotlin/ProductListFragment.kt and 1 other location - About 1 hr to fix
          app/src/main/java/com/talentica/androidkotlin/ProductFragment.kt on lines 72..79

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 117.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method addSearchFieldObservers has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private fun addSearchFieldObservers() {
        // Whenever a new character is typed
        WidgetObservable.text(editText)
                .doOnNext { e: OnTextChangeEvent ->
                    addFriendButton?.setEnabled(false)
          Severity: Minor
          Found in sqlitedatabase/src/main/java/com/talentica/androidkotlin/sqlitedatabase/ui/SearchActivity.kt - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private fun configPictureRatioAndSize(params: Camera.Parameters, ratio: Ratio) {
        val selected = ratio.extractFourByThreeSize(camera.parameters?.supportedPictureSizes!!)
        params.setPictureSize(selected.width, selected.height)
    }
            Severity: Major
            Found in customcamera/src/main/java/com/talentica/androidkotlin/customcamera/model/camera/CameraAdapter.kt and 1 other location - About 1 hr to fix
            customcamera/src/main/java/com/talentica/androidkotlin/customcamera/model/camera/CameraAdapter.kt on lines 172..175

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language