Sign upLogin

Talentica/AndroidWithKotlin

View on GitHub
Star

Showing 83 of 83 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    constructor(product: Product) {
        id = product.id
        name = product.name
        description = product.description
        price = product.price
Severity: Minor
Found in app/src/main/java/com/talentica/androidkotlin/db/entity/ProductEntity.kt and 1 other location - About 55 mins to fix
app/src/main/java/com/talentica/androidkotlin/db/entity/CommentEntity.kt on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    constructor(comment: Comment) {
        id = comment.id
        productId = comment.productId
        text = comment.text
        postedAt = comment.postedAt
Severity: Minor
Found in app/src/main/java/com/talentica/androidkotlin/db/entity/CommentEntity.kt and 1 other location - About 55 mins to fix
app/src/main/java/com/talentica/androidkotlin/db/entity/ProductEntity.kt on lines 31..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method createChannel has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    fun createChannel(id: String?, name: CharSequence?, importance: Int,
                      showBadge: Boolean, group: String, color: Int, vibrationPattern: LongArray) {
Severity: Major
Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/utils/NotificationHelper.kt - About 50 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        override fun onBindViewHolder(holder: CommentViewHolder, position: Int) {
        holder.binding.comment = mCommentList!![position]
        holder.binding.executePendingBindings()
    }
    Severity: Minor
    Found in app/src/main/java/com/talentica/androidkotlin/ui/CommentAdapter.kt and 1 other location - About 50 mins to fix
    app/src/main/java/com/talentica/androidkotlin/ui/ProductAdapter.kt on lines 87..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        override fun onBindViewHolder(holder: ProductViewHolder, position: Int) {
        holder.binding.product = mProductList!![position]
        holder.binding.executePendingBindings()
    }
    Severity: Minor
    Found in app/src/main/java/com/talentica/androidkotlin/ui/ProductAdapter.kt and 1 other location - About 50 mins to fix
    app/src/main/java/com/talentica/androidkotlin/ui/CommentAdapter.kt on lines 85..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fun w(tag: String, t: Throwable, vararg messages: Any) {
        log(tag, Log.WARN, t, *messages)
    }
    Severity: Minor
    Found in audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt and 1 other location - About 50 mins to fix
    audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt on lines 59..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        fun e(tag: String, t: Throwable, vararg messages: Any) {
        log(tag, Log.ERROR, t, *messages)
    }
    Severity: Minor
    Found in audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt and 1 other location - About 50 mins to fix
    audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt on lines 51..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class LandingActivity : SlowkaActivity<LandingActivityView>(), LandingActivityView,
        HasComponent<LandingActivityComponent?>, AdapterView.OnItemClickListener {
    Severity: Minor
    Found in customcamera/src/main/java/com/talentica/androidkotlin/customcamera/ui/landing/LandingActivity.kt and 1 other location - About 50 mins to fix
    customcamera/src/main/java/com/talentica/androidkotlin/customcamera/ui/camera/CameraActivity.kt on lines 21..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class CameraActivity : SlowkaActivity<CameraActivityView>(), CameraActivityView ,
        HasComponent<CameraActivityComponent?>, View.OnClickListener {
    Severity: Minor
    Found in customcamera/src/main/java/com/talentica/androidkotlin/customcamera/ui/camera/CameraActivity.kt and 1 other location - About 50 mins to fix
    customcamera/src/main/java/com/talentica/androidkotlin/customcamera/ui/landing/LandingActivity.kt on lines 26..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method createNotification has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        fun createNotification(channelId: String, title: String, body: String, ticker: String, onGoing:
    Boolean, color: Int): Int {
    Severity: Minor
    Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/utils/NotificationHelper.kt - About 45 mins to fix

      Method createChannel has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              fun createChannel(id: String, name: CharSequence, importance: Int, showBadge: Boolean,
                          group: String = "Personal", vibrationPattern: LongArray = longArrayOf
        (100, 200, 300, 100, 200, 300, 100, 200, 300))
      Severity: Minor
      Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationContract.kt - About 45 mins to fix

        Method createChannel has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            override fun createChannel(id: String, name: CharSequence, importance: Int, showBadge:
    Boolean, group: String, vibrationPattern: LongArray) {
        Severity: Minor
        Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationPresenter.kt - About 45 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              fun e(tag: String, vararg messages: Any) {
        log(tag, Log.ERROR, null, *messages)
    }
          Severity: Minor
          Found in audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt and 2 other locations - About 40 mins to fix
          audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt on lines 43..45
          audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt on lines 47..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              fun i(tag: String, vararg messages: Any) {
        log(tag, Log.INFO, null, *messages)
    }
          Severity: Minor
          Found in audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt and 2 other locations - About 40 mins to fix
          audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt on lines 47..49
          audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt on lines 55..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              fun w(tag: String, vararg messages: Any) {
        log(tag, Log.WARN, null, *messages)
    }
          Severity: Minor
          Found in audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt and 2 other locations - About 40 mins to fix
          audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt on lines 43..45
          audioplayer/src/main/java/com/talentica/androidkotlin/audioplayer/utils/LogHelper.kt on lines 55..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 68.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method createNotification has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              override fun createNotification(channel: String, title: String, body: String, onGoing:
    Boolean, color: Int) {
          Severity: Minor
          Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationPresenter.kt - About 35 mins to fix

            Method createNotification has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    fun createNotification(channel: String, title: String, body: String, onGoing: Boolean,
                               color: Int = Color.GREEN)
            Severity: Minor
            Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationContract.kt - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  override fun createChannel(id: String, name: CharSequence, importance: Int, showBadge:
    Boolean, group: String, vibrationPattern: LongArray) {
              Severity: Minor
              Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationPresenter.kt and 1 other location - About 35 mins to fix
              o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/utils/NotificationHelper.kt on lines 52..53

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 67.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              } else {
                    view.displayError(context.getString(R.string.some_error_occured))
                    view.hideLoading()
                    view.destroy()
                }
              Severity: Minor
              Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoPresenter.kt and 1 other location - About 35 mins to fix
              networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoPresenter.kt on lines 136..140

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 67.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              } else {
                    view.displayError(context.getString(R.string.some_error_occured))
                    view.hideLoading()
                    view.destroy()
                }
              Severity: Minor
              Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoPresenter.kt and 1 other location - About 35 mins to fix
              networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoPresenter.kt on lines 86..90

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 67.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language