Talentica/AndroidWithKotlin

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private fun configPreviewRatioAndSize(params: Camera.Parameters, ratio: Ratio) {
        val selected = ratio.extractFourByThreeSize(camera.parameters?.supportedPreviewSizes!!)
        params.setPreviewSize(selected.width, selected.height)
    }

• Read up
  Read up

Method createDb has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    /**
     * Creates or returns a previously-created database.
     *
     *
     * Although this uses an AsyncTask which currently uses a serial executor, it's thread-safe.

Method loadWithRetrofit has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private fun loadWithRetrofit(username: String) {
        val retrofit = Retrofit.Builder().baseUrl("https://api.github.com/")
                .addConverterFactory(GsonConverterFactory.create()).build()
 
        val retrofitService = retrofit.create(RetrofitService::class.java)

Similar blocks of code found in 2 locations. Consider refactoring.

Open

package com.talentica.androidkotlin.networking
 
import androidx.test.platform.app.InstrumentationRegistry
import androidx.test.runner.AndroidJUnit4
import org.junit.Assert.assertEquals

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

package com.talentica.androidkotlin.sensors
 
import androidx.test.platform.app.InstrumentationRegistry
import androidx.test.runner.AndroidJUnit4
import org.junit.Assert.assertEquals

• Read up
  Read up

Method generateData has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private fun generateData(
        products: MutableList<ProductEntity>,
        comments: MutableList<CommentEntity>
    ) {
        val rnd = Random()

Method getTestData has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static String getTestData(Context context) {
 
        StringBuilder returnString = new StringBuilder();
        InputStream fIn = null;
        InputStreamReader isr = null;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (ContextCompat.checkSelfPermission(activity, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
                //File write logic here
                if (ActivityCompat.shouldShowRequestPermissionRationale(activity, Manifest.permission.WRITE_EXTERNAL_STORAGE)) {
                    // Show an explanation to the user *asynchronously* -- don't block
                    // this thread waiting for the user's response! After the user

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private fun requestCameraPermission() {
        // Here, thisActivity is the current activity
        // Should we show an explanation?
        if (ActivityCompat.shouldShowRequestPermissionRationale(activity, Manifest.permission.CAMERA)) {
            // Show an explanation to the user *asynchronously* -- don't block

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private fun createOk(key: String? = null, value: String? = null) : com.google.gson.JsonObject {
        return create("ok", key, value)
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private fun createError(key: String? = null, value: String? = null) : com.google.gson.JsonObject {
        return create("error", key, value)
    }

• Read up
  Read up

Method loadWithOkHttp has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private fun loadWithOkHttp(username: String) {
        OkHttpService.httpGet(username, object : okhttp3.Callback {
            override fun onFailure(call: okhttp3.Call, e: IOException) {
 
                if (!isAlive) {

Method onSensorChanged has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    override fun onSensorChanged(event: SensorEvent) {
        val alpha = 0.97f
 
        synchronized(this) {
            if (event.sensor.type == Sensor.TYPE_ACCELEROMETER) {

Method onResult has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    //If using emulator then send the location from Emulator's Extended Controls. :)
    override fun onResult(locationSettingsResult: LocationSettingsResult) {
        val status: Status = locationSettingsResult.getStatus();
        when (status.getStatusCode()) {
            LocationSettingsStatusCodes.SUCCESS -> {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    override fun showLoading() {
        val handler = Handler(Looper.getMainLooper())
        handler.post({
            progressBar.visibility = View.VISIBLE
            repoList.alpha = 0.4f

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    override fun hideLoading() {
        val handler = Handler(Looper.getMainLooper())
        handler.post({
            progressBar.visibility = View.GONE
            repoList.alpha = 1.0f

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    fun d(tag: String, vararg messages: Any) {
        // Only log DEBUG if build type is DEBUG
        if (BuildConfig.DEBUG) {
            log(tag, Log.DEBUG, null, *messages)
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            override fun onFailure(call: okhttp3.Call, e: IOException) {
 
                if (!isAlive) {
                    return
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    fun v(tag: String, vararg messages: Any) {
        // Only log VERBOSE if build type is DEBUG
        if (BuildConfig.DEBUG) {
            log(tag, Log.VERBOSE, null, *messages)
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            override fun onFailure(call: Call<Array<Repository>>?, t: Throwable?) {
 
                if (!isAlive) {
                    return
                }

• Read up
  Read up