Sign upLogin

TestingResearchIllinois/NonDex

View on GitHub
Star

Showing 156 of 156 total issues

Method visitMethod has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public MethodVisitor visitMethod(int access, String name, String desc, String signature, String[] exceptions) {
        if ("<init>".equals(name)) {
            return new MethodVisitor(Opcodes.ASM9, super.visitMethod(access, name, desc, signature, exceptions)) {
                @Override
Severity: Minor
Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/HashMapShufflingAdder.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getInvocationCount has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public int getInvocationCount() {
        if (this.invoCount == null) {
            File failed = Paths.get(this.nondexDir, this.executionId,
                    ConfigurationDefaults.INVOCATIONS_FILE).toFile();
Severity: Minor
Found in nondex-common/src/main/java/edu/illinois/nondex/common/Configuration.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addNextEntry has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void addNextEntry() {
        MethodVisitor mv = super.visitMethod(Opcodes.ACC_PUBLIC, "nextEntry", "()Ljava/util/WeakHashMap$Entry;",
                "()Ljava/util/WeakHashMap$Entry<TK;TV;>;", null);
        mv.visitCode();
        mv.visitVarInsn(Opcodes.ALOAD, 0);
Severity: Minor
Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/WeakHashMapShufflingAdder.java - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            private String tryDebugSeeds() {
            List<Configuration> debuggedOnes = this.debugWithConfigurations(this.failingConfigurations);

            if (debuggedOnes.size() > 0) {
                return makeResultString(debuggedOnes);
    Severity: Major
    Found in nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java and 1 other location - About 1 hr to fix
    nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java on lines 96..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        private String tryDebugSeeds() {
        List<Configuration> debuggedOnes = this.debugWithConfigurations(this.failingConfigurations);

        if (debuggedOnes.size() > 0) {
            return makeResultString(debuggedOnes);
    Severity: Major
    Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java and 1 other location - About 1 hr to fix
    nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java on lines 165..183

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method startDebugLinear has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public List<Configuration> startDebugLinear(Configuration config, long start, long end) {
        List<Configuration> allFailingConfigurations = new LinkedList<Configuration>();

        List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<Pair<Pair<Long, Long>, Configuration>>();
        pairs.add((Pair<Pair<Long, Long>, Configuration>)Pair.of((Pair<Long, Long>)Pair.of(start, end),
    Severity: Minor
    Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java - About 1 hr to fix

      Method startDebugBinary has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public List<Configuration> startDebugBinary(Configuration config) {
        List<Configuration> allFailingConfigurations = new LinkedList<Configuration>();

        List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<Pair<Pair<Long, Long>, Configuration>>();
        pairs.add((Pair<Pair<Long, Long>, Configuration>)Pair.of((Pair<Long, Long>)Pair.of(0L,
      Severity: Minor
      Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/DebugTask.java - About 1 hr to fix

        Method startDebugLinear has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private List<Configuration> startDebugLinear(Configuration config, long start, long end) {
            List<Configuration> allFailingConfigurations = new LinkedList<>();

            List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<>();
            pairs.add(Pair.of(Pair.of(start, end),
        Severity: Minor
        Found in nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java - About 1 hr to fix

          Method startDebugBinary has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  private List<Configuration> startDebugBinary(Configuration config) {
            List<Configuration> allFailingConfigurations = new LinkedList<>();

            List<Pair<Pair<Long, Long>, Configuration>> pairs = new LinkedList<>();
            pairs.add(Pair.of(Pair.of(0L, (long) config.getInvocationCount()), config));
          Severity: Minor
          Found in nondex-gradle-plugin/plugin/src/main/java/edu/illinois/nondex/gradle/tasks/NonDexDebug.java - About 1 hr to fix

            Method visitMethod has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @Override
    public MethodVisitor visitMethod(int access, String name, String desc,
                                     String signature, String[] exceptions) {
        if ("<init>".equals(name)) {
            return new MethodVisitor(Opcodes.ASM9, super.visitMethod(access, name, desc, signature, exceptions)) {
            Severity: Minor
            Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/ConcurrentHashMapShufflingAdder.java - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              /*
The MIT License (MIT)
Copyright (c) 2015 Alex Gyori
Copyright (c) 2022 Kaiyao Ke
Copyright (c) 2015 Owolabi Legunsen
              Severity: Major
              Found in nondex-test/src/test/java/edu/illinois/nondex/core/DateFormatSymbolsTest.java and 1 other location - About 1 hr to fix
              nondex-gradle-plugin/plugin/src/functionalTest/resources/comprehensive-it/src/test/java/edu/illinois/nondex/functionalTest/DateFormatSymbolsTest.java on lines 1..31

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 87.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              package edu.illinois.nondex.functionalTest;

import static org.hamcrest.core.IsEqual.equalTo;
import static org.hamcrest.core.IsNot.not;
import static org.junit.Assert.assertThat;
              Severity: Major
              Found in nondex-gradle-plugin/plugin/src/functionalTest/resources/comprehensive-it/src/test/java/edu/illinois/nondex/functionalTest/DateFormatSymbolsTest.java and 1 other location - About 1 hr to fix
              nondex-test/src/test/java/edu/illinois/nondex/core/DateFormatSymbolsTest.java on lines 1..60

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 87.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method process has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void process(String outJar)
            throws IOException, NoSuchAlgorithmException {

        final Set<String> classesToCopy = this.filterCached(outJar);
              Severity: Minor
              Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/Instrumenter.java - About 1 hr to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if ("getDeclaredAnnotations".equals(name)) {
            return new MethodVisitor(Opcodes.ASM9, super.visitMethod(access, name, desc, signature, exceptions)) {
                @Override
                public void visitInsn(int opcode) {
                    if (opcode == Opcodes.ARETURN) {
                Severity: Major
                Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java and 2 other locations - About 1 hr to fix
                nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java on lines 46..59
                nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java on lines 60..73

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 86.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if ("getGenericExceptionTypes".equals(name)) {
            return new MethodVisitor(Opcodes.ASM9, super.visitMethod(access, name, desc, signature, exceptions)) {
                @Override
                public void visitInsn(int opcode) {
                    if (opcode == Opcodes.ARETURN) {
                Severity: Major
                Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java and 2 other locations - About 1 hr to fix
                nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java on lines 46..59
                nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java on lines 74..87

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 86.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if ("getExceptionTypes".equals(name)) {
            return new MethodVisitor(Opcodes.ASM9, super.visitMethod(access, name, desc, signature, exceptions)) {
                @Override
                public void visitInsn(int opcode) {
                    if (opcode == Opcodes.ARETURN) {
                Severity: Major
                Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java and 2 other locations - About 1 hr to fix
                nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java on lines 60..73
                nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/MethodShufflingAdder.java on lines 74..87

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 86.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static ClassVisitor construct(ClassVisitor cv, String clzToInstrument)
            throws NoSuchAlgorithmException {
        if (clzToInstrument.equals(Instrumenter.concurrentHashMapName)) {
            return new ConcurrentHashMapShufflingAdder(cv);
        } else if (clzToInstrument.equals(Instrumenter.hashMapName)) {
                Severity: Minor
                Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/CVFactory.java - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method addNext has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public void addNext() {
        MethodVisitor mv = super.visitMethod(Opcodes.ACC_PUBLIC, "next", "()Ljava/lang/Object;", "()TE;", null);
        mv.visitCode();
        mv.visitVarInsn(Opcodes.ALOAD, 0);
        mv.visitFieldInsn(Opcodes.GETFIELD, "java/util/PriorityQueue$Itr", "expectedModCount", "I");
                Severity: Minor
                Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/PriorityQueueShufflingAdder.java - About 1 hr to fix

                  Method getClassInputStream has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private InputStream getClassInputStream(String className)
            throws IOException {
        InputStream clInputStream;
        if (rtZipFile != null) {
            try {
                  Severity: Minor
                  Found in nondex-instrumentation/src/main/java/edu/illinois/nondex/instr/Instrumenter.java - About 1 hr to fix

                    Method execute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        @Override
    public void execute() throws MojoExecutionException, MojoFailureException {
        Logger.getGlobal().setLoggingLevel(Level.parse(this.loggingLevel));
        String rtPathStr = "";
        if (Utils.checkJDK8()) {
                    Severity: Minor
                    Found in nondex-maven-plugin/src/main/java/edu/illinois/nondex/plugin/AbstractNonDexMojo.java - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language