Sign upLogin

XoopsModules25x/mylinks

View on GitHub
Star

Showing 370 of 370 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function mylinks_qrcode_convert_encoding($str, $to = 'SJIS', $from = _CHARSET)
{
    if (function_exists('mb_convert_encoding')) {
        if (is_array($str)) {
            foreach ($str as $key => $val) {
Severity: Major
Found in qrcode.php and 1 other location - About 1 hr to fix
bookmark.php on lines 109..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function bookmark_convert_encoding($str, $to = 'SJIS', $from = _CHARSET)
{
    if (function_exists('mb_convert_encoding')) {
        if (is_array($str)) {
            foreach ($str as $key => $val) {
Severity: Major
Found in bookmark.php and 1 other location - About 1 hr to fix
qrcode.php on lines 106..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method load has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function load($data, &$datLen)
  {
    $datLen = 0;

    while(true) {
Severity: Minor
Found in fpdf/gif.php - About 1 hr to fix

    Method _beginpage has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function _beginpage($orientation)
{
  $this->page++;
  $this->pages[$this->page]='';
  $this->state=2;
    Severity: Minor
    Found in fpdf/fpdf.php - About 1 hr to fix

      Method skipExt has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function skipExt(&$data, &$extLen)
  {
    $extLen = 0;

    $b = ord($data{0});
      Severity: Minor
      Found in fpdf/gif.php - About 1 hr to fix

        Method _putType0 has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function _putType0($font)
{
  //Type0
  $this->_out('/Subtype /Type0');
  $this->_out('/BaseFont /'.$font['name'].'-'.$font['CMap']);
        Severity: Minor
        Found in fpdf/chinese.php - About 1 hr to fix

          Method CheckTTF has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function CheckTTF($file)
{
  //Check if font license allows embedding
  $f=fopen($file,'rb');
  if(!$f)
          Severity: Minor
          Found in fpdf/font/makefont/makefont.php - About 1 hr to fix

            Method changeModReq has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function changeModReq()
{
    global $xoopsDB, $myts;

    $requestid = MylinksUtility::mylinks_cleanVars($_POST, 'requestid', 0, 'int', array('min' => 0));
            Severity: Minor
            Found in admin/main.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  $xoopsTpl->assign(array(
                          'lang_description'  => _MD_MYLINKS_DESCRIPTIONC,
                          'lang_lastupdate'   => _MD_MYLINKS_LASTUPDATEC,
                          'lang_hits'         => _MD_MYLINKS_HITSC,
                          'lang_rating'       => _MD_MYLINKS_RATINGC,
              Severity: Major
              Found in viewcat.php and 1 other location - About 1 hr to fix
              index.php on lines 107..120

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              $xoopsTpl->assign(array(
                      'lang_description'    => _MD_MYLINKS_DESCRIPTIONC,
                      'lang_lastupdate'     => _MD_MYLINKS_LASTUPDATEC,
                      'lang_hits'           => _MD_MYLINKS_HITSC,
                      'lang_rating'         => _MD_MYLINKS_RATINGC,
              Severity: Major
              Found in index.php and 1 other location - About 1 hr to fix
              viewcat.php on lines 182..195

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function _parsejpg has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

              function _parsejpg($file)
{
  //Extract info from a JPEG file
  $a=GetImageSize($file);
  if(!$a)
              Severity: Minor
              Found in fpdf/fpdf.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function CloseTag has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                function CloseTag($tag)
  {
      //Closing tag
      if($tag=='STRONG')
          $tag='B';
              Severity: Minor
              Found in fpdf/makepdf_class.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function b_system_notification_show has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

              function b_system_notification_show()
{
    global $xoopsConfig, $xoopsUser, $xoopsModule;
    include_once XOOPS_ROOT_PATH . '/include/notification_functions.php';
    include_once XOOPS_ROOT_PATH . '/language/' . $xoopsConfig['language'] . '/notification.php';
              Severity: Minor
              Found in extras/XOOPS_2.5.x/htdocs/modules/system/blocks/system_blocks.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function load has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                function load($data, &$datLen)
  {
    $datLen = 0;

    while(true) {
              Severity: Minor
              Found in fpdf/gif.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function mylinks_cleanVars has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function mylinks_cleanVars(&$global, $key, $default = '', $type = 'int', $limit = null)
    {
        switch ($type) {
            case 'string':
                $ret = isset($global[$key]) ? filter_var($global[$key], FILTER_SANITIZE_MAGIC_QUOTES) : $default;
              Severity: Minor
              Found in class/utility.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function myblocksadmin_update_blockinstance has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

              function myblocksadmin_update_blockinstance(
    $id,
    $bside,
    $bweight,
    $bvisible,
              Severity: Minor
              Found in include/blocksadmin.inc.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method myblocksadmin_update_block has 10 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  $bid,
    $bside,
    $bweight,
    $bvisible,
    $btitle,
              Severity: Major
              Found in include/blocksadmin.inc.php - About 1 hr to fix

                Method _putType0 has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function _putType0($font)
{
  //Type0
  $this->_out('/Subtype /Type0');
  $this->_out('/BaseFont /'.$font['name'].'-'.$font['CMap']);
                Severity: Minor
                Found in fpdf/korean.php - About 1 hr to fix

                  Method deInterlace has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    function deInterlace()
  {
    $data = $this->m_data;

    for($i = 0; $i < 4; $i++) {
                  Severity: Minor
                  Found in fpdf/gif.php - About 1 hr to fix

                    Method _putType0 has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function _putType0($font)
{
  //Type0
  $this->_out('/Subtype /Type0');
  $this->_out('/BaseFont /'.$font['name'].'-'.$font['CMap']);
                    Severity: Minor
                    Found in fpdf/japanese.php - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language