Sign upLogin

appuio/appuio-cloud-agent

View on GitHub
Star

Showing 34 of 37 total issues

Function main has 184 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    metricsAddr := flag.String("metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
    enableLeaderElection := flag.Bool("leader-elect", false,
        "Enable leader election for controller manager. "+
            "Enabling this will ensure there is only one active controller manager.")
Severity: Major
Found in main.go - About 6 hrs to fix

    Method NamespaceQuotaValidator.Handle has 73 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (v *NamespaceQuotaValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
    l := log.FromContext(ctx).
        WithName("webhook.validate-namespace-quota.appuio.io").
        WithValues("id", req.UID, "user", req.UserInfo.Username).
        WithValues("namespace", req.Namespace, "name", req.Name,
    Severity: Minor
    Found in webhooks/namespace_quota_validator.go - About 1 hr to fix

      Method RatioValidator.Handle has 73 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (v *RatioValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
    l := log.FromContext(ctx).
        WithName("webhook.validate-request-ratio.appuio.io").
        WithValues("id", req.UID, "user", req.UserInfo.Username).
        WithValues("namespace", req.Namespace, "name", req.Name, "kind", req.Kind.Kind)
      Severity: Minor
      Found in webhooks/ratio_validator.go - About 1 hr to fix

        Function main has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
        Open

        func main() {
    metricsAddr := flag.String("metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
    enableLeaderElection := flag.Bool("leader-elect", false,
        "Enable leader election for controller manager. "+
            "Enabling this will ensure there is only one active controller manager.")
        Severity: Minor
        Found in main.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method GroupSyncReconciler.Reconcile has 72 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (r *GroupSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
    l := log.FromContext(ctx)
    l.Info("Reconciling Group")

    finalizerName := UpstreamFinalizerPrefix + r.ControlAPIFinalizerZoneName
        Severity: Minor
        Found in controllers/groupsync_controller.go - About 1 hr to fix

          Method GroupSyncReconciler.Reconcile has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
          Open

          func (r *GroupSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
    l := log.FromContext(ctx)
    l.Info("Reconciling Group")

    finalizerName := UpstreamFinalizerPrefix + r.ControlAPIFinalizerZoneName
          Severity: Minor
          Found in controllers/groupsync_controller.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method PodNodeSelectorMutator.Handle has 58 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (v *PodNodeSelectorMutator) Handle(ctx context.Context, req admission.Request) admission.Response {
    l := log.FromContext(ctx).
        WithName("webhook.mutate-pod-node-selector.appuio.io").
        WithValues("id", req.UID, "user", req.UserInfo.Username).
        WithValues("namespace", req.Namespace, "name", req.Name,
          Severity: Minor
          Found in webhooks/pod_node_selector_mutator.go - About 1 hr to fix

            Method NamespaceQuotaValidator.Handle has 13 return statements (exceeds 8 allowed).
            Open

            func (v *NamespaceQuotaValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
    l := log.FromContext(ctx).
        WithName("webhook.validate-namespace-quota.appuio.io").
        WithValues("id", req.UID, "user", req.UserInfo.Username).
        WithValues("namespace", req.Namespace, "name", req.Name,
            Severity: Major
            Found in webhooks/namespace_quota_validator.go - About 55 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (r *UserAttributeSyncReconciler) SetupWithManagerAndForeignCluster(mgr ctrl.Manager, foreign clustersource.ClusterSource) error {
    return ctrl.NewControllerManagedBy(mgr).
        For(&userv1.User{}).
        WatchesRawSource(foreign.SourceFor(&controlv1.User{}), &handler.EnqueueRequestForObject{}).
        Complete(r)
              Severity: Minor
              Found in controllers/userattributesync_controller.go and 1 other location - About 45 mins to fix
              controllers/zoneusageprofilesync_controller.go on lines 66..71

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (r *ZoneUsageProfileSyncReconciler) SetupWithManagerAndForeignCluster(mgr ctrl.Manager, foreign clustersource.ClusterSource) error {
    return ctrl.NewControllerManagedBy(mgr).
        For(&cloudagentv1.ZoneUsageProfile{}).
        WatchesRawSource(foreign.SourceFor(&controlv1.UsageProfile{}), &handler.EnqueueRequestForObject{}).
        Complete(r)
              Severity: Minor
              Found in controllers/zoneusageprofilesync_controller.go and 1 other location - About 45 mins to fix
              controllers/userattributesync_controller.go on lines 92..97

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method RatioValidator.Handle has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
              Open

              func (v *RatioValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
    l := log.FromContext(ctx).
        WithName("webhook.validate-request-ratio.appuio.io").
        WithValues("id", req.UID, "user", req.UserInfo.Username).
        WithValues("namespace", req.Namespace, "name", req.Name, "kind", req.Kind.Kind)
              Severity: Minor
              Found in webhooks/ratio_validator.go - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method GroupSyncReconciler.Reconcile has 11 return statements (exceeds 8 allowed).
              Open

              func (r *GroupSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
    l := log.FromContext(ctx)
    l.Info("Reconciling Group")

    finalizerName := UpstreamFinalizerPrefix + r.ControlAPIFinalizerZoneName
              Severity: Major
              Found in controllers/groupsync_controller.go - About 45 mins to fix

                Method RatioReconciler.warnNamespace has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func (r *RatioReconciler) warnNamespace(ctx context.Context, name string, nsRatio *ratio.Ratio, sel string, limit *resource.Quantity) error {
                Severity: Minor
                Found in controllers/ratio_controller.go - About 35 mins to fix

                  Method ZoneUsageProfileApplyReconciler.applyResourceToNamespace has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func (r *ZoneUsageProfileApplyReconciler) applyResourceToNamespace(ctx context.Context, name string, orgNs corev1.Namespace, resource runtime.RawExtension, profile cloudagentv1.ZoneUsageProfile) error {
                  Severity: Minor
                  Found in controllers/zoneusageprofileapply_controller.go - About 35 mins to fix

                    Method RatioReconciler.warnPod has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func (r *RatioReconciler) warnPod(ctx context.Context, name, namespace string, nsRatio *ratio.Ratio, sel string, limit *resource.Quantity) error {
                    Severity: Minor
                    Found in controllers/ratio_controller.go - About 35 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if err := (&controllers.UserAttributeSyncReconciler{
            Client:   mgr.GetClient(),
            Scheme:   mgr.GetScheme(),
            Recorder: mgr.GetEventRecorderFor("user-attribute-sync-controller"),
                      Severity: Minor
                      Found in main.go and 1 other location - About 35 mins to fix
                      main.go on lines 189..198

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 107.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if err := (&controllers.ZoneUsageProfileSyncReconciler{
            Client:   mgr.GetClient(),
            Scheme:   mgr.GetScheme(),
            Recorder: mgr.GetEventRecorderFor("usage-profile-sync-controller"),
                      Severity: Minor
                      Found in main.go and 1 other location - About 35 mins to fix
                      main.go on lines 158..167

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 107.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method PodNodeSelectorMutator.Handle has 9 return statements (exceeds 8 allowed).
                      Open

                      func (v *PodNodeSelectorMutator) Handle(ctx context.Context, req admission.Request) admission.Response {
    l := log.FromContext(ctx).
        WithName("webhook.mutate-pod-node-selector.appuio.io").
        WithValues("id", req.UID, "user", req.UserInfo.Username).
        WithValues("namespace", req.Namespace, "name", req.Name,
                      Severity: Major
                      Found in webhooks/pod_node_selector_mutator.go - About 35 mins to fix

                        comment on exported method UserAttributeSyncReconciler.SetupWithManagerAndForeignCluster should be of the form "SetupWithManagerAndForeignCluster ..."
                        Open

                        // SetupWithManager sets up the controller with the Manager.
                        Severity: Minor
                        Found in controllers/userattributesync_controller.go by golint

                        comment on exported method ZoneUsageProfileSyncReconciler.SetupWithManagerAndForeignCluster should be of the form "SetupWithManagerAndForeignCluster ..."
                        Open

                        // SetupWithManager sets up the controller with the Manager.
                        Severity: Minor
                        Found in controllers/zoneusageprofilesync_controller.go by golint
                        Severity
                        Category
                        Status
                        Source
                        Language