Showing 14 of 37 total issues
Function main
has 184 lines of code (exceeds 50 allowed). Consider refactoring. Open
func main() {
metricsAddr := flag.String("metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
enableLeaderElection := flag.Bool("leader-elect", false,
"Enable leader election for controller manager. "+
"Enabling this will ensure there is only one active controller manager.")
Method NamespaceQuotaValidator.Handle
has 73 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (v *NamespaceQuotaValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
l := log.FromContext(ctx).
WithName("webhook.validate-namespace-quota.appuio.io").
WithValues("id", req.UID, "user", req.UserInfo.Username).
WithValues("namespace", req.Namespace, "name", req.Name,
Method RatioValidator.Handle
has 73 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (v *RatioValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
l := log.FromContext(ctx).
WithName("webhook.validate-request-ratio.appuio.io").
WithValues("id", req.UID, "user", req.UserInfo.Username).
WithValues("namespace", req.Namespace, "name", req.Name, "kind", req.Kind.Kind)
Function main
has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring. Open
func main() {
metricsAddr := flag.String("metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
enableLeaderElection := flag.Bool("leader-elect", false,
"Enable leader election for controller manager. "+
"Enabling this will ensure there is only one active controller manager.")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method GroupSyncReconciler.Reconcile
has 72 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (r *GroupSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
l := log.FromContext(ctx)
l.Info("Reconciling Group")
finalizerName := UpstreamFinalizerPrefix + r.ControlAPIFinalizerZoneName
Method GroupSyncReconciler.Reconcile
has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring. Open
func (r *GroupSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
l := log.FromContext(ctx)
l.Info("Reconciling Group")
finalizerName := UpstreamFinalizerPrefix + r.ControlAPIFinalizerZoneName
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method PodNodeSelectorMutator.Handle
has 58 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (v *PodNodeSelectorMutator) Handle(ctx context.Context, req admission.Request) admission.Response {
l := log.FromContext(ctx).
WithName("webhook.mutate-pod-node-selector.appuio.io").
WithValues("id", req.UID, "user", req.UserInfo.Username).
WithValues("namespace", req.Namespace, "name", req.Name,
Method NamespaceQuotaValidator.Handle
has 13 return statements (exceeds 8 allowed). Open
func (v *NamespaceQuotaValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
l := log.FromContext(ctx).
WithName("webhook.validate-namespace-quota.appuio.io").
WithValues("id", req.UID, "user", req.UserInfo.Username).
WithValues("namespace", req.Namespace, "name", req.Name,
Method RatioValidator.Handle
has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring. Open
func (v *RatioValidator) Handle(ctx context.Context, req admission.Request) admission.Response {
l := log.FromContext(ctx).
WithName("webhook.validate-request-ratio.appuio.io").
WithValues("id", req.UID, "user", req.UserInfo.Username).
WithValues("namespace", req.Namespace, "name", req.Name, "kind", req.Kind.Kind)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method GroupSyncReconciler.Reconcile
has 11 return statements (exceeds 8 allowed). Open
func (r *GroupSyncReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
l := log.FromContext(ctx)
l.Info("Reconciling Group")
finalizerName := UpstreamFinalizerPrefix + r.ControlAPIFinalizerZoneName
Method RatioReconciler.warnNamespace
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
func (r *RatioReconciler) warnNamespace(ctx context.Context, name string, nsRatio *ratio.Ratio, sel string, limit *resource.Quantity) error {
Method ZoneUsageProfileApplyReconciler.applyResourceToNamespace
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
func (r *ZoneUsageProfileApplyReconciler) applyResourceToNamespace(ctx context.Context, name string, orgNs corev1.Namespace, resource runtime.RawExtension, profile cloudagentv1.ZoneUsageProfile) error {
Method RatioReconciler.warnPod
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
func (r *RatioReconciler) warnPod(ctx context.Context, name, namespace string, nsRatio *ratio.Ratio, sel string, limit *resource.Quantity) error {
Method PodNodeSelectorMutator.Handle
has 9 return statements (exceeds 8 allowed). Open
func (v *PodNodeSelectorMutator) Handle(ctx context.Context, req admission.Request) admission.Response {
l := log.FromContext(ctx).
WithName("webhook.mutate-pod-node-selector.appuio.io").
WithValues("id", req.UID, "user", req.UserInfo.Username).
WithValues("namespace", req.Namespace, "name", req.Name,