Sign upLogin

asteris-llc/converge

View on GitHub
Star

Showing 615 of 615 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        assert.True(t, strings.Contains(u.fetchContents[0], expF[2]) || strings.Contains(u.fetchContents[1], expF[2]) || strings.Contains(u.fetchContents[2], expF[2]) || strings.Contains(u.fetchContents[3], expF[2]))
Severity: Major
Found in resource/unarchive/unarchive_test.go and 3 other locations - About 40 mins to fix
resource/unarchive/unarchive_test.go on lines 702..702
resource/unarchive/unarchive_test.go on lines 703..703
resource/unarchive/unarchive_test.go on lines 705..705

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    t.Run("normal flow", func(t *testing.T) {
        lvm, m := testhelpers.MakeFakeLvm()
        setupNormalFlowApply(m, "", true, true)
        _ = simpleApplySuccess(t, lvm)
        m.AssertCalled(t, "Mkfs", "/dev/mapper/vg0-data", "xfs")
Severity: Minor
Found in resource/lvm/fs/fs_test.go and 2 other locations - About 40 mins to fix
resource/lvm/fs/fs_test.go on lines 104..112
resource/lvm/fs/fs_test.go on lines 114..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        assert.True(t, strings.Contains(u.fetchContents[0], expF[1]) || strings.Contains(u.fetchContents[1], expF[1]) || strings.Contains(u.fetchContents[2], expF[1]) || strings.Contains(u.fetchContents[3], expF[1]))
Severity: Major
Found in resource/unarchive/unarchive_test.go and 3 other locations - About 40 mins to fix
resource/unarchive/unarchive_test.go on lines 702..702
resource/unarchive/unarchive_test.go on lines 704..704
resource/unarchive/unarchive_test.go on lines 705..705

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    t.Run("no mkfs, only unit update and mount", func(t *testing.T) {
        lvm, m := testhelpers.MakeFakeLvm()
        setupNormalFlowApply(m, "xfs", true, false) // "xfs", no unit diffs, mount is NOT mounted
        _ = simpleApplySuccess(t, lvm)
        m.AssertNotCalled(t, "Mkfs", "/dev/mapper/vg0-data", "xfs")
Severity: Minor
Found in resource/lvm/fs/fs_test.go and 2 other locations - About 40 mins to fix
resource/lvm/fs/fs_test.go on lines 95..102
resource/lvm/fs/fs_test.go on lines 114..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    t.Run("when not installed", func(t *testing.T) {
        expected := ""
        a := &apt.Manager{Sys: newRunner("", makeExitError("", 1))}
        result, found := a.InstalledVersion("foo1")
        assert.False(t, found)
Severity: Minor
Found in resource/package/apt/package_manager_test.go and 1 other location - About 40 mins to fix
resource/package/rpm/package_manager_test.go on lines 41..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    t.Run("when not installed", func(t *testing.T) {
        expected := ""
        y := &rpm.YumManager{Sys: newRunner("", makeExitError("", 1))}
        result, found := y.InstalledVersion("foo1")
        assert.False(t, found)
Severity: Minor
Found in resource/package/rpm/package_manager_test.go and 1 other location - About 40 mins to fix
resource/package/apt/package_manager_test.go on lines 42..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function VertexSplitTraverse has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func VertexSplitTraverse(g *graph.Graph, toFind string, startingNode string, stop func(*graph.Graph, string) bool, history map[string]struct{}) (string, string, bool) {
Severity: Minor
Found in render/preprocessor/preprocessor.go - About 35 mins to fix

    Method Preparer.convertTime has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (p *Preparer) convertTime(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
    Severity: Minor
    Found in resource/preparer.go - About 35 mins to fix

      Method Preparer.convertPointer has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (p *Preparer) convertPointer(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
      Severity: Minor
      Found in resource/preparer.go - About 35 mins to fix

        Method Preparer.convertSlice has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (p *Preparer) convertSlice(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
        Severity: Minor
        Found in resource/preparer.go - About 35 mins to fix

          Method Preparer.convertDuration has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (p *Preparer) convertDuration(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
          Severity: Minor
          Found in resource/preparer.go - About 35 mins to fix

            Method Preparer.convertInterface has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (p *Preparer) convertInterface(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
            Severity: Minor
            Found in resource/preparer.go - About 35 mins to fix

              Method Preparer.convertMap has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func (p *Preparer) convertMap(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
              Severity: Minor
              Found in resource/preparer.go - About 35 mins to fix

                Method Preparer.convertValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func (p *Preparer) convertValue(typ reflect.Type, r Renderer, name string, val interface{}, base int) (out reflect.Value, err error) {
                Severity: Minor
                Found in resource/preparer.go - About 35 mins to fix

                  Method Preparer.convertNumber has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func (p *Preparer) convertNumber(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                  Severity: Minor
                  Found in resource/preparer.go - About 35 mins to fix

                    Function simpleApplySuccess has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func simpleApplySuccess(t *testing.T, lvm lowlevel.LVM, group string, name string, size *lowlevel.LvmSize) resource.TaskStatus {
                    Severity: Minor
                    Found in resource/lvm/lv/lv_test.go - About 35 mins to fix

                      Function NewResourceVG has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      func NewResourceVG(lvm lowlevel.LVM, name string, devs []string, remove bool, forceRemove bool) resource.Task {
                      Severity: Minor
                      Found in resource/lvm/vg/vg.go - About 35 mins to fix

                        Function newMockOS has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        func newMockOS(ownedFiles []ownershipRecord,
    users []*user.User,
    groups []*user.Group,
    defaultUser *user.User,
    defaultGroup *user.Group,
                        Severity: Minor
                        Found in resource/file/owner/helper_test.go - About 35 mins to fix

                          Function simpleCheckFailure has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          func simpleCheckFailure(t *testing.T, lvm lowlevel.LVM, group string, name string, size *lowlevel.LvmSize) resource.TaskStatus {
                          Severity: Minor
                          Found in resource/lvm/lv/lv_test.go - About 35 mins to fix

                            Function execPipeline has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            func execPipeline(ctx context.Context, in *graph.Graph, pipelineF MkPipelineF, renderingPlant *render.Factory, notify *graph.Notifier) (*graph.Graph, error) {
                            Severity: Minor
                            Found in apply/apply.go - About 35 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language