asteris-llc/converge

Function simpleCheckSuccess has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func simpleCheckSuccess(t *testing.T, lvm lowlevel.LVM, group string, name string, size *lowlevel.LvmSize) (resource.TaskStatus, resource.Task) {

Function simpleApplyFailure has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func simpleApplyFailure(t *testing.T, lvm lowlevel.LVM, group string, name string, size *lowlevel.LvmSize) resource.TaskStatus {

Function testDrawNodesCustomPrinter has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func testDrawNodesCustomPrinter(t *testing.T, h *human.Printer, id string, in Printable, out string) {

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    t.Run("when-name-null", func(t *testing.T) {
        p := &rpm.Preparer{Name: "", State: "present"}
        _, err := p.Prepare(context.Background(), fakerenderer.New())
        require.Error(t, err)
        assert.EqualError(t, err, "package name cannot be empty")

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func TestNodeGetStringSliceBadItem(t *testing.T) {
    t.Parallel()

    node, err := fromString(`module x y { a = [ 1 ] }`)
    require.NoError(t, err)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func TestNodeGetStringBad(t *testing.T) {
    t.Parallel()

    node, err := fromString(`module x y { a = 1 }`)
    require.NoError(t, err)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func TestNodeGetStringSliceBad(t *testing.T) {
    t.Parallel()

    node, err := fromString(`module x y { a = 1 }`)
    require.NoError(t, err)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    t.Run("when-name-space", func(t *testing.T) {
        p := &apt.Preparer{Name: " ", State: "present"}
        _, err := p.Prepare(context.Background(), fakerenderer.New())
        require.Error(t, err)
        assert.EqualError(t, err, "package name cannot be empty")

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    t.Run("when-name-space", func(t *testing.T) {
        p := &rpm.Preparer{Name: " ", State: "present"}
        _, err := p.Prepare(context.Background(), fakerenderer.New())
        require.Error(t, err)
        assert.EqualError(t, err, "package name cannot be empty")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        t.Run("alpha", func(t *testing.T) {
            t.Parallel()
            _, err := fromString(`test "abc" { value = 7 }`)
            assert.NoError(t, err)
            _, err = fromString(`test "もしもし" { }`)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        t.Run("numbers", func(t *testing.T) {
            t.Parallel()
            _, err := fromString(`test "abc123" { value = 7 }`)
            assert.NoError(t, err)
            _, err = fromString(`test "abc123xyz" { value = 7 }`)

• Read up
  Read up

Method pipelineGen.prepareNode has 5 return statements (exceeds 4 allowed).

Open

func (p pipelineGen) prepareNode(ctx context.Context, idi interface{}) (interface{}, error) {
    var metadataErr error

    res, ok := idi.(resource.Resource)
    if !ok {

Method Formatter.init has 5 return statements (exceeds 4 allowed).

Open

func (f *Formatter) init() {
    isColorTerminal := logrus.IsTerminal(os.Stderr) && (runtime.GOOS != "windows")
    f.fancy = (!f.DisableColors && isColorTerminal)

    f.replacer = strings.NewReplacer(

Method pipelineGen.DependencyCheck has 5 return statements (exceeds 4 allowed).

Open

func (g *pipelineGen) DependencyCheck(ctx context.Context, taskI interface{}) (interface{}, error) {
    task, ok := taskI.(taskWrapper)
    if !ok {
        return nil, errors.New("input node is not a task wrapper")
    }

Function newExportedField has 5 return statements (exceeds 4 allowed).

Open

func newExportedField(input interface{}, index int) (*ExportedField, bool) {
    if nil == input {
        return nil, false
    }

Method Preparer.convertTime has 5 return statements (exceeds 4 allowed).

Open

func (p *Preparer) convertTime(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
    if val == nil {
        return reflect.Zero(typ), nil
    }

Function AssertDiff has 5 return statements (exceeds 4 allowed).

Open

func AssertDiff(t *testing.T, diffs map[string]resource.Diff, name, original, current string) bool {
    var ok bool

    if ok = assert.NotEmpty(t, diffs); !ok {
        return false

Method Unarchive.readWrite has 5 return statements (exceeds 4 allowed).

Open

func (u *Unarchive) readWrite(file string) error {
    fileName := strings.TrimPrefix(file, u.fetchDir.Name())

    fStat, err := os.Stat(file)
    if err != nil {

Method Container.compareLinks has 5 return statements (exceeds 4 allowed).

Open

func (c *Container) compareLinks(container *dc.Container) (actual, expected string) {
    normalizeLink := func(link string) string {
        // internally links are stored as "/linkedcontainername:/containername/alias"
        parts := strings.Split(link, ":")
        if len(parts) == 1 {

Method executor.HealthCheck has 5 return statements (exceeds 4 allowed).

Open

func (e *executor) HealthCheck(in *pb.LoadRequest, stream pb.Executor_HealthCheckServer) error {
    logger, ctx := setIDLogger(stream.Context())
    logger = logger.WithField("function", "executor.Plan")

    loaded, err := in.Load(ctx)